LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* RE: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE
       [not found] <20190508094318.25849-1-wen.he_1@nxp.com>
@ 2019-05-08 10:33 ` Wen He
  0 siblings, 0 replies; 3+ messages in thread
From: Wen He @ 2019-05-08 10:33 UTC (permalink / raw)
  To: dri-devel, p.zabel, linux-kernel; +Cc: Leo Li



> -----Original Message-----
> From: Wen He
> Sent: 2019年5月8日 17:42
> To: dri-devel@lists.freedesktop.org; p.zabel@pengutronix.de
> Cc: Leo Li <leoyang.li@nxp.com>; Wen He <wen.he_1@nxp.com>
> Subject: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE
> 
> The new LS1028A DP driver code causes a link failure when DRM_IMX built-in,
> but platform is ARCH_LAYERSCAPE:
> 
> drivers/gpu/drm/imx/ipuv3-crtc.c:51: undefined reference to `ipu_prg_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:52: undefined reference to `ipu_dc_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:53: undefined reference to
> `ipu_dc_enable_channel'
> drivers/gpu/drm/imx/ipuv3-crtc.c:54: undefined reference to `ipu_di_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.o: In function `ipu_crtc_mode_set_nofb
> 
> Adding a Kconfig dependency allow to build if ARCH_LAYERSCAPE is enable.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  drivers/gpu/ipu-v3/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/ipu-v3/Kconfig b/drivers/gpu/ipu-v3/Kconfig index
> fe6f8c5b4445..51ea88c440df 100644
> --- a/drivers/gpu/ipu-v3/Kconfig
> +++ b/drivers/gpu/ipu-v3/Kconfig
> @@ -1,6 +1,6 @@
>  config IMX_IPUV3_CORE
>  	tristate "IPUv3 core support"
> -	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM ||
> COMPILE_TEST
> +	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM ||
> COMPILE_TEST
> +|| ARCH_LAYERSCAPE
>  	depends on DRM || !DRM # if DRM=m, this can't be 'y'
>  	select BITREVERSE
>  	select GENERIC_ALLOCATOR if DRM
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE
  2019-05-08 10:56 Wen He
@ 2019-07-05 10:32 ` Philipp Zabel
  0 siblings, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2019-07-05 10:32 UTC (permalink / raw)
  To: Wen He, linux-kernel, dri-devel; +Cc: Leo Li

Hi Wen,

On Wed, 2019-05-08 at 10:56 +0000, Wen He wrote:
> The new LS1028A DP driver code causes a link failure when DRM_IMX built-in,
> but platform is ARCH_LAYERSCAPE:
> 
> drivers/gpu/drm/imx/ipuv3-crtc.c:51: undefined reference to `ipu_prg_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:52: undefined reference to `ipu_dc_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.c:53: undefined reference to `ipu_dc_enable_channel'
> drivers/gpu/drm/imx/ipuv3-crtc.c:54: undefined reference to `ipu_di_enable'
> drivers/gpu/drm/imx/ipuv3-crtc.o: In function `ipu_crtc_mode_set_nofb
> 
> Adding a Kconfig dependency allow to build if ARCH_LAYERSCAPE is enable.
> 
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
>  drivers/gpu/ipu-v3/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/ipu-v3/Kconfig b/drivers/gpu/ipu-v3/Kconfig
> index fe6f8c5b4445..51ea88c440df 100644
> --- a/drivers/gpu/ipu-v3/Kconfig
> +++ b/drivers/gpu/ipu-v3/Kconfig
> @@ -1,6 +1,6 @@
>  config IMX_IPUV3_CORE
>  	tristate "IPUv3 core support"
> -	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST
> +	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST || ARCH_LAYERSCAPE
>  	depends on DRM || !DRM # if DRM=m, this can't be 'y'
>  	select BITREVERSE
>  	select GENERIC_ALLOCATOR if DRM
> -- 
> 2.17.1

Thank you for the patch, but this does not seem right.
ipuv3-crtc.c is part of DRM_IMX, which already depends on
IMX_IPUV3_CORE. How did you manage to make it try to compile imxdrm?

Since LS1028A does not have the IPUv3, keeping this under COMPILE_TEST
should be correct.

regards
Philipp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE
@ 2019-05-08 10:56 Wen He
  2019-07-05 10:32 ` Philipp Zabel
  0 siblings, 1 reply; 3+ messages in thread
From: Wen He @ 2019-05-08 10:56 UTC (permalink / raw)
  To: linux-kernel, dri-devel, p.zabel; +Cc: Leo Li, Wen He

The new LS1028A DP driver code causes a link failure when DRM_IMX built-in,
but platform is ARCH_LAYERSCAPE:

drivers/gpu/drm/imx/ipuv3-crtc.c:51: undefined reference to `ipu_prg_enable'
drivers/gpu/drm/imx/ipuv3-crtc.c:52: undefined reference to `ipu_dc_enable'
drivers/gpu/drm/imx/ipuv3-crtc.c:53: undefined reference to `ipu_dc_enable_channel'
drivers/gpu/drm/imx/ipuv3-crtc.c:54: undefined reference to `ipu_di_enable'
drivers/gpu/drm/imx/ipuv3-crtc.o: In function `ipu_crtc_mode_set_nofb

Adding a Kconfig dependency allow to build if ARCH_LAYERSCAPE is enable.

Signed-off-by: Wen He <wen.he_1@nxp.com>
---
 drivers/gpu/ipu-v3/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/ipu-v3/Kconfig b/drivers/gpu/ipu-v3/Kconfig
index fe6f8c5b4445..51ea88c440df 100644
--- a/drivers/gpu/ipu-v3/Kconfig
+++ b/drivers/gpu/ipu-v3/Kconfig
@@ -1,6 +1,6 @@
 config IMX_IPUV3_CORE
 	tristate "IPUv3 core support"
-	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST
+	depends on SOC_IMX5 || SOC_IMX6Q || ARCH_MULTIPLATFORM || COMPILE_TEST || ARCH_LAYERSCAPE
 	depends on DRM || !DRM # if DRM=m, this can't be 'y'
 	select BITREVERSE
 	select GENERIC_ALLOCATOR if DRM
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-05 10:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190508094318.25849-1-wen.he_1@nxp.com>
2019-05-08 10:33 ` [v1] gpu: ipu-v3: allow to build with ARCH_LAYERSCAPE Wen He
2019-05-08 10:56 Wen He
2019-07-05 10:32 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).