LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	Abel Vesa <abel.vesa@nxp.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
Date: Tue, 21 May 2019 11:03:57 +0000	[thread overview]
Message-ID: <AM0PR04MB6434C99FC1B4F12477F94064EE070@AM0PR04MB6434.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1558430013-18346-1-git-send-email-Anson.Huang@nxp.com>

On 5/21/2019 12:18 PM, Anson Huang wrote:
> of_node_put() is called after of_match_node() successfully called,
> then in the following error handling, of_node_put() is called again
> which is unnecessary, this patch adjusts the location of of_node_put()
> to avoid such scenario.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

For both:

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>

I was thinking that maybe you could of_node_put as soon as you were done 
with it but the model is read straight into soc_dev_attr so just freeing 
everything at the end makes more sense.

  parent reply	other threads:[~2019-05-21 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  9:18 Anson Huang
2019-05-21  9:18 ` [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error handle Anson Huang
2019-05-21 11:03 ` Leonard Crestez [this message]
2019-05-23 12:40 ` [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Shawn Guo
2019-05-24  5:53   ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR04MB6434C99FC1B4F12477F94064EE070@AM0PR04MB6434.eurprd04.prod.outlook.com \
    --to=leonard.crestez@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=anson.huang@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=viresh.kumar@linaro.org \
    --subject='Re: [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).