LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling
@ 2019-05-21  9:18 Anson Huang
  2019-05-21  9:18 ` [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error handle Anson Huang
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Anson Huang @ 2019-05-21  9:18 UTC (permalink / raw)
  To: shawnguo, s.hauer, kernel, festevam, Leonard Crestez, Abel Vesa,
	viresh.kumar, linux-arm-kernel, linux-kernel
  Cc: dl-linux-imx

of_node_put() is called after of_match_node() successfully called,
then in the following error handling, of_node_put() is called again
which is unnecessary, this patch adjusts the location of of_node_put()
to avoid such scenario.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/soc/imx/soc-imx8.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index b1bd8e2..944add2 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -86,8 +86,6 @@ static int __init imx8_soc_init(void)
 	if (!id)
 		goto free_soc;
 
-	of_node_put(root);
-
 	data = id->data;
 	if (data) {
 		soc_dev_attr->soc_id = data->name;
@@ -106,6 +104,8 @@ static int __init imx8_soc_init(void)
 	if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
 		platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
 
+	of_node_put(root);
+
 	return 0;
 
 free_rev:
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-24  5:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21  9:18 [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Anson Huang
2019-05-21  9:18 ` [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error handle Anson Huang
2019-05-21 11:03 ` [PATCH 1/2] soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling Leonard Crestez
2019-05-23 12:40 ` Shawn Guo
2019-05-24  5:53   ` Anson Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).