LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chuanhua Han <chuanhua.han@nxp.com>
To: Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
	Rob Herring <robh@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ying Zhang <ying.zhang22455@nxp.com>
Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
Date: Fri, 24 May 2019 09:48:52 +0000	[thread overview]
Message-ID: <AM6PR04MB4357072E079BDD8D1866595797020@AM6PR04MB4357.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AM6PR04MB5863FA1CE6D1E40F11B2E5008F000@AM6PR04MB5863.eurprd04.prod.outlook.com>

Hi, Rob Herring

> -----Original Message-----
> From: Leo Li
> Sent: 2019年5月22日 14:50
> To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> <shawnguo@kernel.org>; Rob Herring <robh@kernel.org>
> Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> <ying.zhang22455@nxp.com>
> Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node
> 
> 
> 
> > -----Original Message-----
> > From: Chuanhua Han
> > Sent: Wednesday, May 22, 2019 1:26 AM
> > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > <ying.zhang22455@nxp.com>
> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > device node
> >
> >
> >
> > > -----Original Message-----
> > > From: Leo Li
> > > Sent: 2019年5月22日 4:15
> > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > <shawnguo@kernel.org>
> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang
> > > <ying.zhang22455@nxp.com>
> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > device node
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Chuanhua Han
> > > > Sent: Tuesday, May 21, 2019 8:00 AM
> > > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>
> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > Zhang <ying.zhang22455@nxp.com>
> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > device node
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Leo Li
> > > > > Sent: 2019年5月18日 6:01
> > > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo
> > > > > <shawnguo@kernel.org>
> > > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org;
> > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying
> > > > > Zhang <ying.zhang22455@nxp.com>
> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > device node
> > > > >
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Chuanhua Han
> > > > > > Sent: Friday, May 17, 2019 1:11 AM
> > > > > > To: Shawn Guo <shawnguo@kernel.org>
> > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > > linux-arm- kernel@lists.infradead.org;
> > > > > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org;
> > > > > > Ying Zhang <ying.zhang22455@nxp.com>
> > > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix
> > > > > > watchdog device node
> > > > > >
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Shawn Guo <shawnguo@kernel.org>
> > > > > > > Sent: 2019年5月17日 10:38
> > > > > > > To: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com;
> > > > > > > linux-arm-kernel@lists.infradead.org;
> > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > > > > Ying Zhang <ying.zhang22455@nxp.com>
> > > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog
> > > > > > > device node
> > > > > > >
> > > > > > > Caution: EXT Email
> > > > > > >
> > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote:
> > > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16
> > > > > > > > platform clock as timer clock, this patch fix device tree node.
> > > > > > > >
> > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com>
> > > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > > > > > > > ---
> > > > > > > >  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19
> > > > > > > > ++++++++++++-------
> > > > > > > >  1 file changed, 12 insertions(+), 7 deletions(-)
> > > > > > > >
> > > > > > > > diff --git
> > > > > > > > a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > index b04581249f0b..1510b1858246 100644
> > > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > > > > > @@ -285,13 +285,18 @@
> > > > > > > >                       #interrupt-cells = <2>;
> > > > > > > >               };
> > > > > > > >
> > > > > > > > -             wdog0: watchdog@23c0000 {
> > > > > > > > -                     compatible = "fsl,ls1028a-wdt",
> > > "fsl,imx21-wdt";
> > > > > > > > -                     reg = <0x0 0x23c0000 0x0 0x10000>;
> > > > > > > > -                     interrupts = <GIC_SPI 59
> > > > > IRQ_TYPE_LEVEL_HIGH>;
> > > > > > > > -                     clocks = <&clockgen 4 1>;
> > > > > > > > -                     big-endian;
> > > > > > > > -                     status = "disabled";
> > > > > > > > +             cluster1_core0_watchdog: wdt@c000000 {
> > > > > > >
> > > > > > > Keep 'watchdog' as the node name,
> > > > > > Thanks for your replay
> > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’?
> > > > > > and keep nodes sort in unit-address.
> > > > > > What does this mean?
> > > > >
> > > > > That means order the nodes by the addresses (e.g. c000000,
> > > > > c010000)
> > > > The current order is correct(The first is c000000, then c000000).
> > >
> > > But they are added after gpio@2320000 and before sata@3200000.
> > I changed and made the second version of the patch, but I found the
> > following error when I executed ./scripts/checkpatch.pl xxx.patch to
> > check the patch:
> >
> > WARNING: DT compatible string vendor "arm" appears un-documented --
> > check ./Documentation/devicetree/bindings/vendor-prefixes.txt
> > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351:
> > + compatible = "arm,sp805", "arm,primecell";
> >
> > However, there is no vendor-prefixes.txt file in the
> > ./Documentation/devicetree/bindings/ directory, only vendor-
> > prefixes.yaml.
> > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml.
> 
> Added Rob Herring to the thread.
> 
> > Request help,thanks
How can I solve this patch check error? Ask for help, thank you!
> > >
> > > > >
> > > > > > >
> > > > > > > Shawn
> > > > > > >
> > > > > > > > +                     compatible = "arm,sp805",
> "arm,primecell";
> > > > > > > > +                     reg = <0x0 0xc000000 0x0 0x1000>;
> > > > > > > > +                     clocks = <&clockgen 4 15>,
> > > > > > > > + <&clockgen
> > > > > > > > + 4
> > > 15>;
> > > > > > > > +                     clock-names = "apb_pclk", "wdog_clk";
> > > > > > > > +             };
> > > > > > > > +
> > > > > > > > +             cluster1_core1_watchdog: wdt@c010000 {
> > > > > > > > +                     compatible = "arm,sp805",
> "arm,primecell";
> > > > > > > > +                     reg = <0x0 0xc010000 0x0 0x1000>;
> > > > > > > > +                     clocks = <&clockgen 4 15>,
> > > > > > > > + <&clockgen
> > > > > > > > + 4
> > > 15>;
> > > > > > > > +                     clock-names = "apb_pclk",
> > > > > > > > + "wdog_clk";
> > > > > > > >               };
> > > > > > > >
> > > > > > > >               sata: sata@3200000 {
> > > > > > > > --
> > > > > > > > 2.17.1
> > > > > > > >

  reply	other threads:[~2019-05-24  9:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  7:06 Chuanhua Han
2019-05-17  2:37 ` Shawn Guo
2019-05-17  6:10   ` [EXT] " Chuanhua Han
2019-05-17 22:01     ` Leo Li
2019-05-21 13:00       ` Chuanhua Han
2019-05-21 20:14         ` Leo Li
2019-05-22  6:26           ` Chuanhua Han
2019-05-22  6:50             ` Leo Li
2019-05-24  9:48               ` Chuanhua Han [this message]
2019-05-24 12:29                 ` Rob Herring
2019-05-30  3:09                   ` Chuanhua Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR04MB4357072E079BDD8D1866595797020@AM6PR04MB4357.eurprd04.prod.outlook.com \
    --to=chuanhua.han@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=ying.zhang22455@nxp.com \
    --subject='RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).