LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: 李扬韬 <frank.li@vivo.com>
To: Chao Yu <chao@kernel.org>
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string
Date: Sat, 14 Aug 2021 10:41:51 +0800 (GMT+08:00)	[thread overview]
Message-ID: <AOcAowBKDxRdEVGR5gjSrqq6.3.1628908911313.Hmail.frank.li@vivo.com> (raw)
In-Reply-To: <9b000232-c3dc-458c-2507-1dde8a8d985c@kernel.org>

>> HI Chao,
>> 
>> From: Chao Yu <chao@kernel.org>
>> Date: 2021-08-13 22:09:53
>> To:  Yangtao Li <frank.li@vivo.com>,jaegeuk@kernel.org
>> Cc:  linux-f2fs-devel@lists.sourceforge.net,linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string>On 2021/8/13 22:01, Yangtao Li wrote:
>>>> Do not use numbers but strings to improve readability when flag is set.
>>>
>>> This breaks output rule of sysfs entry, see below link:
>>>
>> Which rule? one entry should show one value?
>
>Yes, one value per file please, which is suggested by Greg.
>
>https://lkml.org/lkml/2021/6/3/319
>
>> 
>> But I see that:
>> # cat /sys/fs/f2fs/<disk>/features
>> encryption, quota_ino, verity, pin_file
>> 
>> So the format of features also wrong?
>
>  What:		/sys/fs/f2fs/<disk>/features
>  Date:		July 2017
>  Contact:	"Jaegeuk Kim" <jaegeuk@kernel.org>
>  Description:	<deprecated: should use /sys/fs/f2fs/<disk>/feature_list/

root@kvm-xfstests:~# cat /sys/fs/f2fs/nvme0n1/extension_list 
cold file extension:
jpg
gif
png
avi
divx
mp4
mp3
3gp
wmv
wma
mpeg
mkv
mov
asx
asf
wmx
svi
wvx
wm
mpg
mpe
rm
ogg
jpeg
video
apk
so
hot file extension:
db

So we need remove extension_list to proc fs?

MBR,
Yangtao 




      parent reply	other threads:[~2021-08-14  2:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 14:01 Yangtao Li
2021-08-13 14:09 ` Chao Yu
2021-08-13 14:17   ` 李扬韬
2021-08-13 14:41     ` Chao Yu
2021-08-13 14:55       ` 李扬韬
2021-08-14  2:41       ` 李扬韬 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AOcAowBKDxRdEVGR5gjSrqq6.3.1628908911313.Hmail.frank.li@vivo.com \
    --to=frank.li@vivo.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re:Re: [PATCH] f2fs: convert /sys/fs/f2fs/<disk>/stat/sb_status to use string' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).