LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ananiev, Leonid I" <leonid.i.ananiev@intel.com>
To: <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] aio: fix kernel bug when page is temporally busy
Date: Wed, 14 Feb 2007 20:51:33 +0300 [thread overview]
Message-ID: <B41635854730A14CA71C92B36EC22AAC83F228@mssmsx411> (raw)
-wrap lines are fixed. Sorry.
>From Leonid Ananiev
Fix kernel bug if IO page is temporally busy:
invalidate_inode_pages2_range() returns EIOCBRETRY but not EIO.
invalidate_inode_pages2() returns EIO as earlier.
Signed-off-by: Leonid Ananiev <leonid.i.ananiev@intel.com>
---
--- linux-2.6.20/mm/truncate.c 2007-02-04 10:44:54.000000000 -0800
+++ linux-2.6.20p/mm/truncate.c 2007-02-08 22:56:52.000000000 -0800
@@ -366,7 +366,7 @@ static int do_launder_page(struct addres
* Any pages which are found to be mapped into pagetables are unmapped prior to
* invalidation.
*This is path is modified so that invalidate_inode_pages2()
returns EIO as earlier.
Wrap lines are fixed
- From Leonid Ananiev
Fix kernel bug when IO page is temporally busy:
invalidate_inode_pages2_range() returns EIOCBRETRY but not EIO.
invalidate_inode_pages2() returns EIO as earlier.
Signed-off-by: Leonid Ananiev <leonid.i.ananiev@intel.com>
---
--- linux-2.6.20/mm/truncate.c 2007-02-04 10:44:54.000000000 -0800
+++ linux-2.6.20p/mm/truncate.c 2007-02-08 22:56:52.000000000 -0800
@@ -366,7 +366,7 @@ static int do_launder_page(struct addres
* Any pages which are found to be mapped into pagetables are unmapped prior to
* invalidation.
*
- * Returns -EIO if any pages could not be invalidated.
+ * Returns -EIOCBRETRY if any pages could not be invalidated.
*/
int invalidate_inode_pages2_range(struct address_space *mapping,
pgoff_t start, pgoff_t end)
@@ -423,7 +423,7 @@ int invalidate_inode_pages2_range(struct
}
ret = do_launder_page(mapping, page);
if (ret == 0 && !invalidate_complete_page2(mapping, page))
- ret = -EIO;
+ ret = -EIOCBRETRY;
unlock_page(page);
}
pagevec_release(&pvec);
@@ -444,6 +444,7 @@ EXPORT_SYMBOL_GPL(invalidate_inode_pages
*/
int invalidate_inode_pages2(struct address_space *mapping)
{
- return invalidate_inode_pages2_range(mapping, 0, -1);
+ int ret = invalidate_inode_pages2_range(mapping, 0, -1);
+ return (ret < 0)?-EIO:ret;
}
EXPORT_SYMBOL_GPL(invalidate_inode_pages2);
- * Returns -EIO if any pages could not be invalidated.
+ * Returns -EIOCBRETRY if any pages could not be invalidated.
*/
int invalidate_inode_pages2_range(struct address_space *mapping,
pgoff_t start, pgoff_t end)
@@ -423,7 +423,7 @@ int invalidate_inode_pages2_range(struct
}
ret = do_launder_page(mapping, page);
if (ret == 0 && !invalidate_complete_page2(mapping, page))
- ret = -EIO;
+ ret = -EIOCBRETRY;
unlock_page(page);
}
pagevec_release(&pvec);
@@ -444,6 +444,7 @@ EXPORT_SYMBOL_GPL(invalidate_inode_pages
*/
int invalidate_inode_pages2(struct address_space *mapping)
{
- return invalidate_inode_pages2_range(mapping, 0, -1);
+ int ret = invalidate_inode_pages2_range(mapping, 0, -1);
+ return (ret < 0)?-EIO:ret;
}
EXPORT_SYMBOL_GPL(invalidate_inode_pages2);
next reply other threads:[~2007-02-14 17:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 17:51 Ananiev, Leonid I [this message]
2007-02-15 3:30 ` [PATCH] aio: fix kernel bug when page is temporally busy Andrew Morton
2007-02-15 5:26 ` Ananiev, Leonid I
-- strict thread matches above, loose matches on Subject: below --
2007-02-10 19:36 Ananiev, Leonid I
2007-02-09 4:29 Ananiev, Leonid I
2007-02-09 4:35 ` Andrew Morton
2007-02-09 5:41 ` Ananiev, Leonid I
2007-02-09 5:52 ` Andrew Morton
2007-02-12 22:52 ` Ananiev, Leonid I
2007-02-12 23:21 ` Ananiev, Leonid I
2007-02-09 7:16 ` Suparna Bhattacharya
2007-02-09 9:52 ` Ananiev, Leonid I
2007-02-09 10:11 ` Jiri Kosina
2007-02-10 18:05 ` Ken Chen
2007-02-10 18:17 ` Ananiev, Leonid I
2007-02-10 18:27 ` Ananiev, Leonid I
2007-02-10 21:57 ` Ananiev, Leonid I
2007-02-15 9:16 ` Ananiev, Leonid I
2007-02-15 18:25 ` Zach Brown
2007-02-15 19:11 ` Ananiev, Leonid I
2007-02-15 19:22 ` Zach Brown
2007-02-15 21:06 ` Ananiev, Leonid I
2007-02-15 23:32 ` Ananiev, Leonid I
2007-02-16 0:01 ` Zach Brown
2007-02-16 12:18 ` Ananiev, Leonid I
2007-02-09 9:54 ` Jiri Kosina
2007-02-09 10:14 ` Andrew Morton
2007-02-09 10:40 ` Jiri Kosina
2007-02-09 11:05 ` Suparna Bhattacharya
2007-02-09 11:18 ` Ananiev, Leonid I
2007-02-09 17:02 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B41635854730A14CA71C92B36EC22AAC83F228@mssmsx411 \
--to=leonid.i.ananiev@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).