LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* RE: [patch] scsi: use lock per host instead of per device forshared queue tag host
@ 2007-01-25  3:25 Ed Lin
  0 siblings, 0 replies; only message in thread
From: Ed Lin @ 2007-01-25  3:25 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi, linux-kernel, jeff, Promise_Linux



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@SteelEye.com] 
> Sent: Wednesday, January 24, 2007 9:00 AM
> To: Ed Lin
> Cc: linux-scsi; linux-kernel; jeff; Promise_Linux
> Subject: Re: [patch] scsi: use lock per host instead of per 
> device forshared queue tag host
> 
...
> 
> This patch looks OK in principle.
> 
> However, are you sure you're not using a sledgehammer to crack a nut?
> If the only reason you're doing this is because of the shared tag map,
> then probably that should be the area you protect with a per-tag-map
> lock.   The net effect of what you've done will be to serialise all
> accesses to your storage devices.  For a small number of devices, this
> probably won't matter than much, but for large numbers of devices,
> you're probably going to introduce artificial performance 
> degredation in
> the I/O scheduler.
> 
> James
> 

Thanks.
Maybe this issue needs more discussion. I'll follow up.

Ed Lin

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-25  3:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-25  3:25 [patch] scsi: use lock per host instead of per device forshared queue tag host Ed Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).