LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Shane Huang" <Shane.Huang@amd.com>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
htejun@gmail.com, "Shane Huang" <Shane.Huang@amd.com>
Subject: [patch] PCI: disable the MSI of AMD RS690
Date: Thu, 24 Jan 2008 18:59:04 +0800 [thread overview]
Message-ID: <B90463BC30D2E446BA423D888DC85E501BF78E@sshaexmb1.amd.com> (raw)
In-Reply-To: <5CAB7B5D6F8AB84AA868A46B47A507055D8C1D@sshaexmb1.amd.com>
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
This patch recover Tejun's commit
4be8f906435a6af241821ab5b94b2b12cb7d57d8
because there is one MSI bug on RS690+SB600 board which will lead to
boot failure. This bug is NOT same as the one in SB700 SATA controller,
quirk_msi_intx_disable_bug does not work to SB600. Disablement the MSI
of RS690 is the workaround.
Signed-off-by: Shane Huang <shane.huang@amd.com>
Since there is some word wrapping problem with my mail client MS outlook
if I copy the patch into the text, so I'll also attach the patch as an
attachment. Please check it.
diff -ruN old/drivers/pci/quirks.c new/drivers/pci/quirks.c
--- old/drivers/pci/quirks.c 2008-01-07 05:45:38.000000000 +0800
+++ new/drivers/pci/quirks.c 2008-01-22 11:02:00.000000000 +0800
@@ -1623,6 +1623,7 @@
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS,
PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200,
quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480,
quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS690,
quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351,
quirk_disable_all_msi);
/* Disable MSI on chipsets that are known to not support it */
diff -ruN old/include/linux/pci_ids.h new/include/linux/pci_ids.h
--- old/include/linux/pci_ids.h 2008-01-07 05:45:38.000000000 +0800
+++ new/include/linux/pci_ids.h 2008-01-22 11:01:55.000000000 +0800
@@ -360,6 +360,7 @@
#define PCI_DEVICE_ID_ATI_RS400_166 0x5a32
#define PCI_DEVICE_ID_ATI_RS400_200 0x5a33
#define PCI_DEVICE_ID_ATI_RS480 0x5950
+#define PCI_DEVICE_ID_ATI_RS690 0x7910
/* ATI IXP Chipset */
#define PCI_DEVICE_ID_ATI_IXP200_IDE 0x4349
#define PCI_DEVICE_ID_ATI_IXP200_SMBUS 0x4353
Thanks
Best Regards
Shane
[-- Attachment #2: disable_RS690_MSI.patch --]
[-- Type: application/octet-stream, Size: 1295 bytes --]
diff -ruN old/drivers/pci/quirks.c new/drivers/pci/quirks.c
--- old/drivers/pci/quirks.c 2008-01-07 05:45:38.000000000 +0800
+++ new/drivers/pci/quirks.c 2008-01-22 11:02:00.000000000 +0800
@@ -1623,6 +1623,7 @@
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS400_200, quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS690, quirk_disable_all_msi);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351, quirk_disable_all_msi);
/* Disable MSI on chipsets that are known to not support it */
diff -ruN old/include/linux/pci_ids.h new/include/linux/pci_ids.h
--- old/include/linux/pci_ids.h 2008-01-07 05:45:38.000000000 +0800
+++ new/include/linux/pci_ids.h 2008-01-22 11:01:55.000000000 +0800
@@ -360,6 +360,7 @@
#define PCI_DEVICE_ID_ATI_RS400_166 0x5a32
#define PCI_DEVICE_ID_ATI_RS400_200 0x5a33
#define PCI_DEVICE_ID_ATI_RS480 0x5950
+#define PCI_DEVICE_ID_ATI_RS690 0x7910
/* ATI IXP Chipset */
#define PCI_DEVICE_ID_ATI_IXP200_IDE 0x4349
#define PCI_DEVICE_ID_ATI_IXP200_SMBUS 0x4353
next prev parent reply other threads:[~2008-01-24 11:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 9:14 [patch] PCI: disable MSI on more ATI NorthBridges Shane Huang
2007-10-18 10:19 ` David Miller
2007-10-18 10:37 ` Shane Huang
2007-10-18 11:46 ` David Miller
2007-10-18 15:24 ` Greg KH
2007-10-19 17:42 ` Daniel Barkalow
2008-01-24 10:59 ` Shane Huang [this message]
2008-01-24 11:12 ` [patch] PCI: modify SB700 SATA MSI quirk Shane Huang
2008-01-25 0:19 ` Tejun Heo
2008-01-25 3:26 ` Shane Huang
2008-01-25 3:35 ` Tejun Heo
2008-01-25 3:48 ` Shane Huang
2008-01-25 4:33 ` Greg KH
2008-01-24 11:15 ` [patch] PCI: disable the MSI of AMD RS690 Brice Goglin
2008-01-25 10:39 ` Shane Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B90463BC30D2E446BA423D888DC85E501BF78E@sshaexmb1.amd.com \
--to=shane.huang@amd.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--subject='Re: [patch] PCI: disable the MSI of AMD RS690' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).