LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Leech, Christopher" <christopher.leech@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
	"NeilBrown" <neilb@suse.de>, <linux-raid@vger.kernel.org>
Cc: "Evgeniy Polyakov" <johnpol@2ka.mipt.ru>,
	"Arjan van de Ven" <arjan@infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [RFC][PATCH 00/12] md raid acceleration and performance analysis
Date: Tue, 6 Feb 2007 15:49:03 -0800	[thread overview]
Message-ID: <BD524EA7912ED5469DFD0BAEF6BC752F0136DE23@orsmsx411.amr.corp.intel.com> (raw)
In-Reply-To: <e9c3a7c20701222016q6e06dee6y7977f1525eacf042@mail.gmail.com>

Hi Dan,

I've been looking over how your patches change the ioatdma driver.  I
like the idea of removing the multiple entry points for virtual address
vs. page struct arguments, and just using dma_addr_t for the driver
interfaces.

But, I don't think having both ioatdma and iop-adma implement map_page,
map_single, unmap_page, and unmap_single entry points is much better.
Do you see a reason why it wouldn't work to expose the generic device
for a DMA channel, and replace instances of

	dma_device->map_single(dma_chan, src, len, DMA_TO_DEVICE)

with

	dma_map_single(dma_device->dev, src, len, DMA_TO_DEVICE)

I am a little concerned about having the DMA mapping happen outside of
the driver, but the unmapping is still in the driver cleanup routine.
I'm not sure if it's really a problem, or how I'd change it though.

- Chris

       reply	other threads:[~2007-02-06 23:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e9c3a7c20701222016q6e06dee6y7977f1525eacf042@mail.gmail.com>
2007-02-06 23:49 ` Leech, Christopher [this message]
2007-02-07 22:36   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BD524EA7912ED5469DFD0BAEF6BC752F0136DE23@orsmsx411.amr.corp.intel.com \
    --to=christopher.leech@intel.com \
    --cc=arjan@infradead.org \
    --cc=dan.j.williams@intel.com \
    --cc=johnpol@2ka.mipt.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --subject='RE: [RFC][PATCH 00/12] md raid acceleration and performance analysis' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).