RE: cris: build creates links in the source directory

RE: cris: build creates links in the source directory

[Mikael Starvik]

That is correct and we have thoughts about using Makfiles and compiler flags
to resolve this instead as done for other architectures.

/Mikael

-----Original Message-----
From: Adrian Bunk [mailto:bunk@kernel.org] 
Sent: Wednesday, February 27, 2008 11:06 PM
To: Mikael Starvik; Jesper Nilsson
Cc: dev-etrax; Sam Ravnborg; linux-kernel@vger.kernel.org
Subject: cris: build creates links in the source directory


Especially when building with a separate object directory the following 
part of arch/cris/Makefile is not so nice since it creates links in the 
source directory:

<--  snip  -->

# Create some links to make all tools happy
$(SRC_ARCH)/.links:
        @rm -rf $(SRC_ARCH)/drivers
        @ln -sfn $(SARCH)/drivers $(SRC_ARCH)/drivers
        @rm -rf $(SRC_ARCH)/boot
        @ln -sfn $(SARCH)/boot $(SRC_ARCH)/boot
        @rm -rf $(SRC_ARCH)/lib
        @ln -sfn $(SARCH)/lib $(SRC_ARCH)/lib
        @rm -f $(SRC_ARCH)/arch/mach
        @rm -rf $(SRC_ARCH)/arch
        @ln -sfn $(SARCH) $(SRC_ARCH)/arch
ifdef CONFIG_ETRAX_ARCH_V32
        @ln -sfn ../$(SARCH)/$(MACH) $(SRC_ARCH)/arch/mach
endif
        @rm -rf $(SRC_ARCH)/kernel/vmlinux.lds.S
        @ln -sfn ../$(SARCH)/vmlinux.lds.S $(SRC_ARCH)/kernel/vmlinux.lds.S
        @rm -rf $(SRC_ARCH)/kernel/asm-offsets.c
        @ln -sfn ../$(SARCH)/kernel/asm-offsets.c
$(SRC_ARCH)/kernel/asm-offsets.c
        @touch $@

# Create link to sub arch includes
$(srctree)/include/asm-$(ARCH)/.arch: $(wildcard 
include/config/arch/*.h)
        @echo '  SYMLINK include/asm-$(ARCH)/arch ->
include/asm-$(ARCH)/$(SARCH)'
        @rm -f $(srctree)/include/asm-$(ARCH)/arch/mach
        @rm -f $(srctree)/include/asm-$(ARCH)/arch
        @ln -sf $(SARCH) $(srctree)/include/asm-$(ARCH)/arch
ifdef CONFIG_ETRAX_ARCH_V32
        @ln -sf $(MACH) $(srctree)/include/asm-$(ARCH)/arch/mach
endif
        @touch $@

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

cris: build creates links in the source directory

[Adrian Bunk]

Especially when building with a separate object directory the following 
part of arch/cris/Makefile is not so nice since it creates links in the 
source directory:

<--  snip  -->

# Create some links to make all tools happy
$(SRC_ARCH)/.links:
        @rm -rf $(SRC_ARCH)/drivers
        @ln -sfn $(SARCH)/drivers $(SRC_ARCH)/drivers
        @rm -rf $(SRC_ARCH)/boot
        @ln -sfn $(SARCH)/boot $(SRC_ARCH)/boot
        @rm -rf $(SRC_ARCH)/lib
        @ln -sfn $(SARCH)/lib $(SRC_ARCH)/lib
        @rm -f $(SRC_ARCH)/arch/mach
        @rm -rf $(SRC_ARCH)/arch
        @ln -sfn $(SARCH) $(SRC_ARCH)/arch
ifdef CONFIG_ETRAX_ARCH_V32
        @ln -sfn ../$(SARCH)/$(MACH) $(SRC_ARCH)/arch/mach
endif
        @rm -rf $(SRC_ARCH)/kernel/vmlinux.lds.S
        @ln -sfn ../$(SARCH)/vmlinux.lds.S $(SRC_ARCH)/kernel/vmlinux.lds.S
        @rm -rf $(SRC_ARCH)/kernel/asm-offsets.c
        @ln -sfn ../$(SARCH)/kernel/asm-offsets.c $(SRC_ARCH)/kernel/asm-offsets.c
        @touch $@

# Create link to sub arch includes
$(srctree)/include/asm-$(ARCH)/.arch: $(wildcard 
include/config/arch/*.h)
        @echo '  SYMLINK include/asm-$(ARCH)/arch -> include/asm-$(ARCH)/$(SARCH)'
        @rm -f $(srctree)/include/asm-$(ARCH)/arch/mach
        @rm -f $(srctree)/include/asm-$(ARCH)/arch
        @ln -sf $(SARCH) $(srctree)/include/asm-$(ARCH)/arch
ifdef CONFIG_ETRAX_ARCH_V32
        @ln -sf $(MACH) $(srctree)/include/asm-$(ARCH)/arch/mach
endif
        @touch $@

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed