LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Chen Weixiang <weixiangx.chen@outlook.com>
To: Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peng Tao <bergwolf@gmail.com>,
	Hema Prathaban <hemaklnce@gmail.com>,
	Jiayi Ye <yejiayily@gmail.com>,
	Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
	Chen Weixiang <weixiangx.chen@outlook.com>,
	Luca Ceresoli <luca@lucaceresoli.net>,
	Greg Donald <gdonald@gmail.com>, Joe Perches <joe@perches.com>,
	Julia Lawall <Julia.Lawall@lip6.fr>
Cc: HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] staging: lustre: lustre: libcfs: define symbols as static
Date: Thu, 5 Feb 2015 21:13:09 +0800	[thread overview]
Message-ID: <BLU436-SMTP8489A4E5C01DF6C4236BB2883B0@phx.gbl> (raw)

[-- Attachment #1: Type: text/plain, Size: 41 bytes --]


-- 
Best regards,
Chen Weixiang (Alex)


[-- Attachment #2: 0001-staging-lustre-lustre-libcfs-define-symbols-as-stati.patch --]
[-- Type: text/plain, Size: 1518 bytes --]

>From 8de8c7f65f4529e3febb384402344d062f64230b Mon Sep 17 00:00:00 2001
From: Chen Weixiang <weixiangx.chen@outlook.com>
Date: Thu, 5 Feb 2015 20:07:02 +0800
Subject: [PATCH] staging: lustre: lustre: libcfs: define symbols as static

This patch fixes the following warning using sparse
- warning: symbol 'libcfs_debug_mb' was not declared. Should it be
  static?
- warning: symbol 'portal_enter_debugger' was not declared. Should
  it be static?

Signed-off-by: Chen Weixiang <weixiangx.chen@outlook.com>
---
 drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/debug.c b/drivers/staging/lustre/lustre/libcfs/debug.c
index 7170088..76c62e8 100644
--- a/drivers/staging/lustre/lustre/libcfs/debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/debug.c
@@ -57,7 +57,7 @@ module_param(libcfs_debug, int, 0644);
 MODULE_PARM_DESC(libcfs_debug, "Lustre kernel debug mask");
 EXPORT_SYMBOL(libcfs_debug);
 
-unsigned int libcfs_debug_mb = 0;
+static unsigned int libcfs_debug_mb;
 module_param(libcfs_debug_mb, uint, 0644);
 MODULE_PARM_DESC(libcfs_debug_mb, "Total debug buffer size.");
 EXPORT_SYMBOL(libcfs_debug_mb);
@@ -93,7 +93,7 @@ EXPORT_SYMBOL(libcfs_debug_binary);
 unsigned int libcfs_stack = 3 * THREAD_SIZE / 4;
 EXPORT_SYMBOL(libcfs_stack);
 
-unsigned int portal_enter_debugger;
+static unsigned int portal_enter_debugger;
 EXPORT_SYMBOL(portal_enter_debugger);
 
 unsigned int libcfs_catastrophe;
-- 
2.2.2


             reply	other threads:[~2015-02-05 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 13:13 Chen Weixiang [this message]
2015-02-05 13:24 [PATCH] staging: lustre: lustre: libcfs: define symbols as static Chen Weixiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU436-SMTP8489A4E5C01DF6C4236BB2883B0@phx.gbl \
    --to=weixiangx.chen@outlook.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andreas.dilger@intel.com \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hemaklnce@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=oleg.drokin@intel.com \
    --cc=rickard_strandqvist@spectrumdigital.se \
    --cc=yejiayily@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).