LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Haiyang Zhang <haiyangz@microsoft.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
Date: Fri, 1 Oct 2021 22:11:09 +0000	[thread overview]
Message-ID: <BN8PR21MB1284A4B993EA1C8A51A043C7CAAB9@BN8PR21MB1284.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20211001135544.1823-1-andriy.shevchenko@linux.intel.com>



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, October 1, 2021 9:56 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> hyperv@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> Wei Liu <wei.liu@kernel.org>; Dexuan Cui <decui@microsoft.com>; Greg
> Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
> 
> There is no user of anything in uuid.h in the hyperv.h. Replace it with
> more appropriate types.h.
> 
> Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/uapi/linux/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 6135d92e0d47..daf82a230c0e 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -26,7 +26,7 @@
>  #ifndef _UAPI_HYPERV_H
>  #define _UAPI_HYPERV_H
> 
> -#include <linux/uuid.h>
> +#include <linux/types.h>
> 
>  /*

Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
linux/mod_devicetable.h:

./include/linux/mod_devicetable.h:#include <linux/uuid.h>
./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

So your patch looks fine. Thanks.

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

  reply	other threads:[~2021-10-01 22:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 13:55 Andy Shevchenko
2021-10-01 22:11 ` Haiyang Zhang [this message]
2021-10-02  7:46   ` Andy Shevchenko
2021-10-06 12:06     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR21MB1284A4B993EA1C8A51A043C7CAAB9@BN8PR21MB1284.namprd21.prod.outlook.com \
    --to=haiyangz@microsoft.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=decui@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=wei.liu@kernel.org \
    --subject='RE: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).