LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: KY Srinivasan <kys@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dexuan Cui <decui@microsoft.com>
Subject: RE: [PATCH v3] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors
Date: Mon, 26 Jan 2015 16:11:17 +0000	[thread overview]
Message-ID: <BY2PR0301MB07114BC53D10824940B55423A0350@BY2PR0301MB0711.namprd03.prod.outlook.com> (raw)
In-Reply-To: <87k309g729.fsf@vitty.brq.redhat.com>



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Monday, January 26, 2015 2:39 AM
> To: Greg Kroah-Hartman
> Cc: KY Srinivasan; devel@linuxdriverproject.org; Haiyang Zhang; linux-
> kernel@vger.kernel.org; Dexuan Cui
> Subject: Re: [PATCH v3] Drivers: hv: vmbus: prevent cpu offlining on newer
> hypervisors
> 
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Mon, Jan 12, 2015 at 05:50:11PM +0100, Vitaly Kuznetsov wrote:
> >> When an SMP Hyper-V guest is running on top of 2012R2 Server and
> >> secondary cpus are sent offline (with echo 0 >
> >> /sys/devices/system/cpu/cpu$cpu/online)
> >> the system freeze is observed. This happens due to the fact that on
> >> newer hypervisors (Win8, WS2012R2, ...) vmbus channel handlers are
> >> distributed across all cpus (see init_vp_index() function in
> >> drivers/hv/channel_mgmt.c) and on cpu offlining nobody reassigns them
> >> to CPU0. Prevent cpu offlining when vmbus is loaded until the issue is
> fixed host-side.
> >>
> >> This patch also disables hibernation but it is OK as it is also
> >> broken (MCE error is hit on resume). Suspend still works.
> >>
> >> Tested with WS2008R2 and WS2012R2.
> >>
> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> >> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> >> ---
> >> Changes since v2:
> >> - repair the build when vmbus is builded as a module [Greg KH] by saving
> >>   current cpu_disable pointer to previous_cpu_disable and restoring it on
> >>   unload;
> >> - return -ENOSYS (same as native_cpu_disable when
> !CONFIG_HOTPLUG_CPU) instead
> >>   of -1 in hyperv_cpu_disable().
> >>
> >> Changes since v1:
> >> - introduce hv_cpu_hotplug_quirk() function to not spread #ifdefs
> >> [Greg KH];
> >> - add pr_notice() message "hv_vmbus: CPU offlining is not supported by
> >>   hypervisor".
> >> ---
> >>  drivers/hv/vmbus_drv.c | 36
> ++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 36 insertions(+)
> >
> > Doesn't apply to my char-misc-test branch at all :(
> 
> Another mid-air collision with K.Y's "Drivers: hv: vmbus: Implement a
> clockevent device", please use the attached version. No functional changes
> are required, I just fixed the merge conflict (includes).
> 
> Othere than that (and sorry for meddling), would it it be better if you switch
> to 'pull requests' workflow with K.Y? There is a lot of ongoing work in hyperv
> nowdays and such collisions seem otherwise inevitable ...

I will co-ordinate and forward Hyper-V patches to Greg.

K. Y
> 
> --
>   Vitaly


  reply	other threads:[~2015-01-26 16:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 13:52 [PATCH] " Vitaly Kuznetsov
2014-11-27  3:02 ` Greg Kroah-Hartman
2014-11-27  3:24   ` Dexuan Cui
2014-11-27  9:52     ` Vitaly Kuznetsov
2014-12-01 10:52 ` [PATCH v2] " Vitaly Kuznetsov
2014-12-01 11:12   ` Dexuan Cui
2015-01-09 20:57   ` Greg Kroah-Hartman
2015-01-12 16:50   ` [PATCH v3] " Vitaly Kuznetsov
2015-01-12 18:54     ` KY Srinivasan
2015-01-25 13:36     ` Greg Kroah-Hartman
2015-01-26 10:38       ` Vitaly Kuznetsov
2015-01-26 16:11         ` KY Srinivasan [this message]
2015-01-26 22:54         ` Greg Kroah-Hartman
2015-01-26 23:53           ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY2PR0301MB07114BC53D10824940B55423A0350@BY2PR0301MB0711.namprd03.prod.outlook.com \
    --to=kys@microsoft.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    --subject='RE: [PATCH v3] Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).