From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933399AbbCPSPU (ORCPT ); Mon, 16 Mar 2015 14:15:20 -0400 Received: from mail-bn1bbn0104.outbound.protection.outlook.com ([157.56.111.104]:11701 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932903AbbCPSPL convert rfc822-to-8bit (ORCPT ); Mon, 16 Mar 2015 14:15:11 -0400 From: KY Srinivasan To: Vitaly Kuznetsov , "devel@linuxdriverproject.org" CC: Haiyang Zhang , "linux-kernel@vger.kernel.org" , Dexuan Cui , "Radim Krcmar" , Greg Kroah-Hartman , "linux-api@vger.kernel.org" Subject: RE: [PATCH RFCv2 00/21] Drivers: hv: utils: re-implement the kernel/userspace communication layer Thread-Topic: [PATCH RFCv2 00/21] Drivers: hv: utils: re-implement the kernel/userspace communication layer Thread-Index: AQHQW/9xt0KBe/yk1ES7PBtccAh/2J0fcTsg Date: Mon, 16 Mar 2015 18:15:08 +0000 Message-ID: References: <1426080574-9011-1-git-send-email-vkuznets@redhat.com> In-Reply-To: <1426080574-9011-1-git-send-email-vkuznets@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2001:4898:80e8:ee31::2] authentication-results: redhat.com; dkim=none (message not signed) header.d=none; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0775; x-forefront-antispam-report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(377454003)(13464003)(19580405001)(54356999)(86612001)(2656002)(2501003)(551934003)(19580395003)(50986999)(74316001)(33656002)(102836002)(2950100001)(86362001)(99286002)(46102003)(2900100001)(106116001)(92566002)(40100003)(122556002)(87936001)(77156002)(62966003)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0775;H:BY2PR0301MB0711.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:BY2PR0301MB0775;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0775; x-forefront-prvs: 05177D47DC Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: microsoft.onmicrosoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2015 18:15:08.6035 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0775 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com] > Sent: Wednesday, March 11, 2015 6:29 AM > To: KY Srinivasan; devel@linuxdriverproject.org > Cc: Haiyang Zhang; linux-kernel@vger.kernel.org; Dexuan Cui; Radim Krcmar; > Greg Kroah-Hartman; linux-api@vger.kernel.org > Subject: [PATCH RFCv2 00/21] Drivers: hv: utils: re-implement the > kernel/userspace communication layer > > Changes in RFCv2: > - Preserve backwards compatibility with netlink-speaking daemons. [K. Y. > Srinivasan] > - Introduce transport abstraction layer. [K. Y. Srinivasan] > - Get rid of ioctls [Radim Krcmar] > - Make the series reviewable by splitting it into smaller patches. > > Anatomy of the series: > Patches 01 - 07 are cleanup with minor functional change. > Patch 08 defines the state machine. > Patches 09-11 convert all 3 drivers to using the state machine. > Patch 12 fixes a bug in fcopy. This change is going away in Patch 15, I just > want to highlight the fix. > Patch 13 introduces a transport abstraction. > Patch 14-16 convert all drivers to using the transport abstraction. > Patches 17-18 switch KVP and VSS daemon to using char devices. > Patches 19-20 convert FCOPY and VSS to hull handshake (the same we have > in KVP). These two can be postponed till we really need to distinguish > between different kernels in the daemon code. > Patch 21 unifies log messages on daemons connect across all drivers and > moves these messages to debug level. > > I smoke-tested this series with both old (netlink) and new (char devices) > daemons and tested the daemon upgrade procedure. > > Original description: > This series converts kvp/vss daemons to use misc char devices instead of > netlink for userspace/kernel communication and then updates fcopy to be > consistent with kvp/vss. > > Userspace/kernel communication via netlink has a number of issues: > - It is hard for userspace to figure out if the kernel part was loaded or not > and this fact can change as there is a way to enable/disable the service from > host side. Racy daemon startup is also a problem. > - When the userspace daemon restarts/dies kernel part doesn't receive a > notification. > - Netlink communication is not stable under heavy load. > - ... > > Vitaly Kuznetsov (21): > Drivers: hv: util: move kvp/vss function declarations to > hyperv_vmbus.h > Drivers: hv: kvp: reset kvp_context > Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h > Drivers: hv: fcopy: process deferred messages when we complete the > transaction > Drivers: hv: vss: process deferred messages when we complete the > transaction > Drivers: hv: kvp: rename kvp_work -> kvp_timeout_work > Drivers: hv: fcopy: rename fcopy_work -> fcopy_timeout_work > Drivers: hv: util: introduce state machine for util drivers > Drivers: hv: kvp: switch to using the hvutil_device_state state > machine > Drivers: hv: vss: switch to using the hvutil_device_state state > machine > Drivers: hv: fcopy: switch to using the hvutil_device_state state > machine > Drivers: hv: fcopy: set .owner reference for file operations > Drivers: hv: util: introduce hv_utils_transport abstraction > Drivers: hv: vss: convert to hv_utils_transport > Drivers: hv: fcopy: convert to hv_utils_transport > Drivers: hv: kvp: convert to hv_utils_transport > Tools: hv: kvp: use misc char device to communicate with kernel > Tools: hv: vss: use misc char device to communicate with kernel > Drivers: hv: vss: full handshake support > Drivers: hv: fcopy: full handshake support > Drivers: hv: utils: unify driver registration reporting > > drivers/hv/Makefile | 2 +- > drivers/hv/hv_fcopy.c | 287 ++++++++++++++-------------------------- > drivers/hv/hv_kvp.c | 192 +++++++++++++-------------- > drivers/hv/hv_snapshot.c | 168 +++++++++++++++-------- > drivers/hv/hv_utils_transport.c | 276 > ++++++++++++++++++++++++++++++++++++++ > drivers/hv/hv_utils_transport.h | 51 +++++++ > drivers/hv/hyperv_vmbus.h | 29 ++++ > include/linux/hyperv.h | 8 -- > include/uapi/linux/hyperv.h | 8 +- > tools/hv/hv_fcopy_daemon.c | 15 +++ > tools/hv/hv_kvp_daemon.c | 166 +++++------------------ > tools/hv/hv_vss_daemon.c | 149 ++++++--------------- > 12 files changed, 752 insertions(+), 599 deletions(-) create mode 100644 > drivers/hv/hv_utils_transport.c create mode 100644 > drivers/hv/hv_utils_transport.h Vitaly, Thank you very much for taking on this project; very well done. I have mostly reviewed the code and I should be done shortly. Also, I am going to test this code as well. If there are no issues, I will send this out to Greg in my next installment of patches. Regards, K. Y > > -- > 1.9.3