LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Sanil, Shruthi" <shruthi.sanil@intel.com>
To: Rob Herring <robh@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"andriy.shevchenko@linux.intel.com" 
	<andriy.shevchenko@linux.intel.com>,
	"kris.pan@linux.intel.com" <kris.pan@linux.intel.com>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>,
	"Thokala, Srikanth" <srikanth.thokala@intel.com>,
	"Raja Subramanian,
	Lakshmi Bai"  <lakshmi.bai.raja.subramanian@intel.com>,
	"Sangannavar,
	Mallikarjunappa"  <mallikarjunappa.sangannavar@intel.com>
Subject: RE: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer
Date: Mon, 23 Aug 2021 06:02:08 +0000	[thread overview]
Message-ID: <BYAPR11MB3128DFAC405C1DAC5FD805EEF1C49@BYAPR11MB3128.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB3128F143273F060C33DCA9C8F1F99@BYAPR11MB3128.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Sanil, Shruthi
> Sent: Thursday, August 12, 2021 10:19 PM
> To: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Rob Herring <robh@kernel.org>; daniel.lezcano@linaro.org;
> tglx@linutronix.de; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; andriy.shevchenko@linux.intel.com;
> kris.pan@linux.intel.com; mgross@linux.intel.com; Thokala, Srikanth
> <Srikanth.Thokala@intel.com>; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@intel.com>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@intel.com>
> Subject: RE: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem
> Bay SoC Timer
> 
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Wednesday, August 4, 2021 1:08 PM
> > To: Sanil, Shruthi <shruthi.sanil@intel.com>
> > Cc: Rob Herring <robh@kernel.org>; daniel.lezcano@linaro.org;
> > tglx@linutronix.de; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; andriy.shevchenko@linux.intel.com;
> > kris.pan@linux.intel.com; mgross@linux.intel.com; Thokala, Srikanth
> > <srikanth.thokala@intel.com>; Raja Subramanian, Lakshmi Bai
> > <lakshmi.bai.raja.subramanian@intel.com>; Sangannavar, Mallikarjunappa
> > <mallikarjunappa.sangannavar@intel.com>
> > Subject: Re: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel
> > Keem Bay SoC Timer
> >
> > On Wed, Aug 4, 2021 at 8:35 AM Sanil, Shruthi
> > <shruthi.sanil@intel.com>
> > wrote:
> > > > From: Rob Herring <robh@kernel.org>
> > > > Sent: Tuesday, August 3, 2021 4:14 AM
> >
> > ...
> >
> > > > > +properties:
> > > >
> > > > You need a 'compatible' here. Otherwise, how does one know what
> 'reg'
> > > > contains. Also, without it, this schema will never be applied.
> > > >
> > >
> > > This is a parent block that has the common configuration register
> > > address
> > defined which we would need during the initialization of the child
> > nodes. This block in itself is not doing anything. We have this
> > because, we have a common register that is required to be accessed
> > during all the timers and counter initialization.
> > > The child nodes have the compatible string, which is used in the
> > > driver. I
> > have validated this on the Keem Bay HW and see that the timer probes
> > are being called and the timers are functional as expected.
> >
> > I think I understand now. The problem is that the current state of
> > affairs with this block is incorrect software representation. What you
> > need is to create an MFD device driver (for which the compatible will
> > exactly the one Rob is telling
> > about) and from it you register the rest of your drivers. The existing
> > drivers for this block should be converted to MFD schema.
> 
> Sure Andy, I shall check on this and get back.
> Thank You!
> 

Hi Rob,
Do you agree with the above proposal of creating a MFD device with compatible string "simple-mfd"? 

> >
> > --
> > With Best Regards,
> > Andy Shevchenko

  reply	other threads:[~2021-08-23  6:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  5:39 [PATCH v5 0/2] Add the driver for Intel Keem Bay SoC timer block shruthi.sanil
2021-07-29  5:39 ` [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer shruthi.sanil
2021-08-02 22:43   ` Rob Herring
2021-08-04  5:25     ` Sanil, Shruthi
2021-08-04  7:38       ` Andy Shevchenko
2021-08-12 16:49         ` Sanil, Shruthi
2021-08-23  6:02           ` Sanil, Shruthi [this message]
2021-07-29  5:39 ` [PATCH v5 2/2] clocksource: Add Intel Keem Bay timer support shruthi.sanil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3128DFAC405C1DAC5FD805EEF1C49@BYAPR11MB3128.namprd11.prod.outlook.com \
    --to=shruthi.sanil@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kris.pan@linux.intel.com \
    --cc=lakshmi.bai.raja.subramanian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mallikarjunappa.sangannavar@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=srikanth.thokala@intel.com \
    --cc=tglx@linutronix.de \
    --subject='RE: [PATCH v5 1/2] dt-bindings: timer: Add bindings for Intel Keem Bay SoC Timer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).