LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Andi Kleen <ak@suse.de>, <virtualization@lists.osdl.org>
Cc: Chris Wright <chrisw@sous-sol.org>,
	<xen-devel@lists.xensource.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch
Date: Wed, 21 Feb 2007 22:16:15 +0000	[thread overview]
Message-ID: <C202752F.26C4%Keir.Fraser@cl.cam.ac.uk> (raw)
In-Reply-To: <200702212310.02218.ak@suse.de>

On 21/2/07 22:10, "Andi Kleen" <ak@suse.de> wrote:

>> /*
>> +  * Temporary hack: zero gs now that we've saved it so that Xen
>> +  * doesn't try to reload the old value after changing the GDT
>> +  * during the context switch.  This can go away once Xen has
>> +  * been taught to only reload %gs when it absolutely must.
>> +  */
>> + loadsegment(gs, 0);
> 
> Sorry, but i don't really want that unconditionally in the context switch.
> Adding a paravirt ops for it would be also ugly. Can Xen be fixed?

This is not an issue for correctness so this can safely be removed and still
work with current Xen.

 -- Keir



  parent reply	other threads:[~2007-02-21 22:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070221205254.169835700@goop.org>
     [not found] ` <20070221205323.770169136@goop.org>
2007-02-21 22:10   ` Andi Kleen
2007-02-21 22:14     ` Jeremy Fitzhardinge
2007-02-21 22:16     ` Keir Fraser [this message]
2007-02-21 23:25     ` [Xen-devel] " Zachary Amsden
2007-02-21 23:29       ` Jeremy Fitzhardinge
     [not found] ` <20070221205322.869165491@goop.org>
2007-02-21 22:15   ` [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries Andi Kleen
2007-02-21 22:20     ` Jeremy Fitzhardinge
2007-02-21 23:20     ` Rusty Russell
2007-02-21 23:27       ` [Xen-devel] " Jeremy Fitzhardinge
     [not found] ` <20070221205323.842917348@goop.org>
2007-02-22  3:10   ` [patch 18/24] Xen-paravirt_ops: Some generic early printk & boot console fixups Andrew Morton
2007-02-22  5:48     ` Jeremy Fitzhardinge
2007-02-22  8:33       ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C202752F.26C4%Keir.Fraser@cl.cam.ac.uk \
    --to=keir.fraser@cl.cam.ac.uk \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    --subject='Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).