LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey Brodkin" <alexey.brodkin@synopsys.com>
Subject: Re: [PATCH v2] ARC: IOC: panic if kernel was started with previously enabled IOC
Date: Tue, 30 Oct 2018 16:05:51 +0000	[thread overview]
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075013A5892D6@us01wembx1.internal.synopsys.com> (raw)
In-Reply-To: <20181030085421.7657-1-Eugeniy.Paltsev@synopsys.com>

On 10/30/18 1:54 AM, Eugeniy Paltsev wrote:
> If IOC was already enabled (due to bootloader) it technically needs to
> be reconfigured with aperture base,size corresponding to Linux memory
> map which will certainly be different than uboot's. But disabling and
> reenabling IOC when DMA might be potentially active is tricky business.
> To avoid random memory issues later, just panic here and ask user to
> upgrade bootloader to one which doesn't enable IOC.
>
> This was actually seen as issue on some of the HSDK board with a version
> of uboot which enabled IOC. There were random issues later with starting
> of X or peripherals etc.
>
> Also while I'm at it, replace hardcoded bits in ARC_REG_IO_COH_PARTIAL
> and ARC_REG_IO_COH_ENABLE registers by definitions.
>
> Inspired by: https://lkml.org/lkml/2018/1/19/557
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> Changes v1->v2:
>  * Fix regression: check for IOC existence before accessing to any IOC
>    register.
>
...
...
>  		arc_slc_disable();
>  
> -	if (is_isa_arcv2() && ioc_enable)
> +	if (is_isa_arcv2() && ioc_exists)
>  		arc_ioc_setup();

Folded this hunk into existing patch in for-curr.

Thx,
-Vineet

      reply	other threads:[~2018-10-30 16:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30  8:54 Eugeniy Paltsev
2018-10-30 16:05 ` Vineet Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C2D7FE5348E1B147BCA15975FBA23075013A5892D6@us01wembx1.internal.synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=alexey.brodkin@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --subject='Re: [PATCH v2] ARC: IOC: panic if kernel was started with previously enabled IOC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).