LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Sterba <dsterba@suse.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Martin Steigerwald <martin@lichtvoll.de>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS
Date: Sat, 28 Apr 2018 17:33:57 +0000	[thread overview]
Message-ID: <CA+55aFzH=CjVD4kUXfPBjimsKhfphjOceDtcskWtj5Vk3ByB4Q@mail.gmail.com> (raw)
In-Reply-To: <20180428170504.16031-1-dsterba@suse.com>

On Sat, Apr 28, 2018 at 10:07 AM David Sterba <dsterba@suse.com> wrote:

> I volunteer to act as a maintainer of AFFS to collect any fixes that
> might show up and to guard fs/affs/ against another spring cleaning.

Hmm. Please be more careful.

> @@ -564,8 +564,10 @@ S: Maintained

The above says it adds two lines (8 -> 10), but the actual patch itself
only adds one, and modifies another:

> +M:     David Sterba <dsterba@suse.com>
> -S:     Orphan
> +S:     Odd Fixes

I'm used to editing patches for things like this, because I have years and
years of just hand-editing patches I didn't like for some reason, but it
looks like you tried to edit a patch without knowing all the rules for how
unified patches work.

So please don't edit patches by hand.  It's a skill nobody should have.

Anyway, I fixed the patch and applied it, but let's not make a habit of it.

               Linus

  reply	other threads:[~2018-04-28 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 17:05 David Sterba
2018-04-28 17:33 ` Linus Torvalds [this message]
2018-04-28 17:58   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFzH=CjVD4kUXfPBjimsKhfphjOceDtcskWtj5Vk3ByB4Q@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=dsterba@suse.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    --subject='Re: [PATCH] MAINTAINERS: add myself as maintainer of AFFS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).