LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Liu Ying <liu.y.victor@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select CONFIG_FB_MXS
Date: Thu, 8 Jan 2015 11:30:24 +0800	[thread overview]
Message-ID: <CA+8Hj82JWcb_+cvc6d75rd-2C_AiMmZwOAOFa2gTq2f1RpTz8A@mail.gmail.com> (raw)
In-Reply-To: <1420673754-6645-1-git-send-email-festevam@gmail.com>

2015-01-08 7:35 GMT+08:00 Fabio Estevam <festevam@gmail.com>:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_FB_MXS is the LCD driver for mx6solo-lite and mx6solox.
>
> Enable it by default.

I'm not sure if it is suitable to enable CONFIG_FB_MXS by default.
At least, I have no strong objections.

I am considering to add a LCDIF CRTC driver to the imx-drm framework
so that we may use the existing LDB drm driver to support the mx6solox
LVDS interface.

I see the i915 and omap2 fb drivers depend on !DRM_XXXX:

grep DRM_ drivers/video/fbdev/ -nr
drivers/video/fbdev/omap2/omapfb/Kconfig:3:        depends on FB &&
OMAP2_DSS && !DRM_OMAP
drivers/video/fbdev/Kconfig:1197:       depends on !DRM_I915

So, similarly, we'll probably have two LCDIF drivers and make the DRM
one enabled by default - finally, CONFIG_FB_MXS is disabled.

Another concern is the compatibility. Since both the framebuffer driver
and the imx-drm driver would export the framebuffer interface to the
user space, we'd better to keep the interface behavior the same.
Maybe, this is not a big problem, because we need to keep the compatibility
anyway...

Regards,
Liu Ying

>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 9575af8..1f36977 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -203,6 +203,7 @@ CONFIG_DRM_PANEL_SIMPLE=y
>  CONFIG_LCD_CLASS_DEVICE=y
>  CONFIG_LCD_L4F00242T03=y
>  CONFIG_LCD_PLATFORM=y
> +CONFIG_FB_MXS=y
>  CONFIG_BACKLIGHT_PWM=y
>  CONFIG_BACKLIGHT_GPIO=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Best Regards,
Liu Ying

  reply	other threads:[~2015-01-08  3:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 23:35 Fabio Estevam
2015-01-08  3:30 ` Liu Ying [this message]
     [not found] ` <CA+8Hj80oLByoaEWTQw_jchxfha1Gm=HhZp8pgTdeOb06fu=uQQ@mail.gmail.com>
2015-01-14 15:13   ` Fabio Estevam
2015-01-20  6:14 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+8Hj82JWcb_+cvc6d75rd-2C_AiMmZwOAOFa2gTq2f1RpTz8A@mail.gmail.com \
    --to=liu.y.victor@gmail.com \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --subject='Re: [PATCH] ARM: imx_v6_v7_defconfig: Select CONFIG_FB_MXS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).