LKML Archive on
help / color / mirror / Atom feed
From: Brian Norris <>
To: Li Tuo <>
Cc: amit karwar <>,
	Ganapathi Bhat <>,
	Sharvari Harisangam <>,
	Xinming Hu <>,
	Kalle Valo <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	linux-wireless <>,
	"<>" <>,
	Linux Kernel <>,
Subject: Re: [BUG] mwifiex: possible null-pointer dereference in mwifiex_dnld_cmd_to_fw()
Date: Mon, 2 Aug 2021 13:44:41 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


On Fri, Jul 30, 2021 at 9:13 PM Li Tuo <> wrote:
> Our static analysis tool finds a possible null-pointer dereference in
> the mwifiex driver in Linux 5.14.0-rc3:

Wouldn't be the first time a static analysis tool tripped up over
excessively redundant "safety" checks :)

For example:

> The variable cmd_node->cmd_skb->data is assigned to the variable
> host_cmd, and host_cmd is checked in:
> 190:    if (host_cmd == NULL || host_cmd->size == 0)
> This indicates that host_cmd can be NULL.
> If so, the function mwifiex_recycle_cmd_node() will be called with the
> argument cmd_node:
> 196:    mwifiex_recycle_cmd_node(adapter, cmd_node);
> In this called function, the variable cmd_node->cmd_skb->data is
> assigned to the variable host_cmd, too.
> Thus the variable host_cmd in the function mwifiex_recycle_cmd_node()
> can be also NULL.
> However, it is dereferenced when calling le16_to_cpu():
> 144:    le16_to_cpu(host_cmd->command)
> I am not quite sure whether this possible null-pointer dereference is
> real and how to fix it if it is real.
> Any feedback would be appreciated, thanks!

I doubt it's real; the NULL check is probably excessive. I don't think
there's any case in which such skb's will have no ->data. If you're
interested, you could test and submit a "fix" to drop the excess


  reply	other threads:[~2021-08-02 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  4:13 Li Tuo
2021-08-02 20:44 ` Brian Norris [this message]
2021-08-03  2:34   ` Li Tuo
  -- strict thread matches above, loose matches on Subject: below --
2021-07-31  3:45 Li Tuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [BUG] mwifiex: possible null-pointer dereference in mwifiex_dnld_cmd_to_fw()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).