LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Yehezkel Bernat <yehezkelshb@gmail.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andreas Noever <andreas.noever@gmail.com>,
	michael.jamet@intel.com
Subject: Re: [PATCH v2] thunderbolt: Handle NULL boot ACL entries properly
Date: Tue, 01 May 2018 18:56:13 +0000	[thread overview]
Message-ID: <CA+CmpXtiJx=Ufk6tdZOa+4m3uLiR3KoY1hknWmBZ5c0AUg6yEQ@mail.gmail.com> (raw)
In-Reply-To: <20180430111245.31072-1-mika.westerberg@linux.intel.com>

On Mon, Apr 30, 2018 at 2:12 PM Mika Westerberg <
mika.westerberg@linux.intel.com> wrote:

> If the boot ACL entry is already NULL we should not fill in the upper
> two DWs with 0xfffffffff. Otherwise they are not shown as empty entries
> when the sysfs attribute is read.

> Fixes: 9aaa3b8b4c56 ("thunderbolt: Add support for preboot ACL")
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Changes from v1 (https://lkml.org/lkml/2018/4/27/845):

>   * Use || instead of && to make sure UUIDs with only one zero DW
>     are still treated as valid.

>   drivers/thunderbolt/icm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> index 2d2ceda9aa26..500911f16498 100644
> --- a/drivers/thunderbolt/icm.c
> +++ b/drivers/thunderbolt/icm.c
> @@ -1255,7 +1255,7 @@ static int icm_ar_get_boot_acl(struct tb *tb,
uuid_t *uuids, size_t nuuids)
>                          /* Map empty entries to null UUID */
>                          uuid[0] = 0;
>                          uuid[1] = 0;
> -               } else {
> +               } else if (uuid[0] != 0 || uuid[1] != 0) {
>                          /* Upper two DWs are always one's */
>                          uuid[2] = 0xffffffff;
>                          uuid[3] = 0xffffffff;
> --
> 2.17.0


Acked-by: Yehezkel Bernat <yehezkelshb@gmail.com>

  reply	other threads:[~2018-05-01 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 11:12 Mika Westerberg
2018-05-01 18:56 ` Yehezkel Bernat [this message]
2018-05-07 12:20   ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+CmpXtiJx=Ufk6tdZOa+4m3uLiR3KoY1hknWmBZ5c0AUg6yEQ@mail.gmail.com' \
    --to=yehezkelshb@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --subject='Re: [PATCH v2] thunderbolt: Handle NULL boot ACL entries properly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).