LKML Archive on
help / color / mirror / Atom feed
From: Tomasz Figa <>
To: "Krzysztof Kozlowski" <>,
	"Paweł Chmiel" <>
Cc: Sylwester Nawrocki <>,
	"" <>,
	Kukjin Kim <>,
	linux-arm-kernel <>,
	linux-kernel <>,
	Marek Szyprowski <>
Subject: Re: [PATCH] pinctrl/samsung: Correct EINTG banks order
Date: Tue, 10 Apr 2018 17:38:29 +0900	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

2018-04-10 16:06 GMT+09:00 Krzysztof Kozlowski <>:
> On Sun, Apr 8, 2018 at 8:07 PM, Paweł Chmiel
> <> wrote:
>> All banks with GPIO interrupts should be at beginning
>> of bank array and without any other types of banks between them.
>> This order is expected by exynos_eint_gpio_irq, when doing
>> interrupt group to bank translation.
>> Otherwise, kernel NULL pointer dereference would happen
>> when trying to handle interrupt, due to wrong bank being looked up.
>> Observed on s5pv210, when trying to handle gpj0 interrupt,
>> where kernel was mapping it to gpi bank.
> Thanks for the patch. The issue looks real although one thing was
> missed - there is a gap in SVC group between GPK2 and GPL0 (pointed by
> Marek Szyprowski):
> 0x0 - EINT_23 - gpk0
> 0x1 - EINT_24 - gpk1
> 0x2 - EINT_25 - gpk2
> 0x4 - EINT_27 - gpl0
> 0x7 - EINT_8 - gpm0
> Maybe this should be done differently - to remove such hidden
> requirement entirely in favor of another parameter of

Perhaps let's limit this patch to s5pv210 and Exynos5410 alone, where
a simple swap of bank order in the arrays should be okay.

We might also need to have some fixes on 4x12, because I noticed that
in exynos4x12_pin_banks0[] there is a hole in eint_offsets between
gpd1 and gpf0 and exynos4x12_pin_banks1[] starts with gpk0 that has
eint_offset equal to 0x08 (not 0).

> Anyway if such hidden requirement
> stays, then please document it in the source code (it maybe next to
> PIN order... or next macro... or also in exynos_eint_gpio_irq()).
> Beside that please add cc-stable and appropriate fixes tag,

Agreed. Probably the only safe way of documenting this is to put it
inside each bank array, so that when someone creates a copy/paste for
new SoC, the comment is clearly visible... Perhaps something like:

/* Must start with EINTG banks, ordered by EINT group number. */

Best regards,

  reply	other threads:[~2018-04-10  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08 18:07 [PATCH] pinctrl/samsung: Correct EINTG banks order Paweł Chmiel
2018-04-09  3:20 ` Tomasz Figa
2018-04-10  7:06 ` Krzysztof Kozlowski
2018-04-10  8:38   ` Tomasz Figa [this message]
2018-04-11  8:36     ` Tomasz Figa
2018-04-11  9:52       ` Krzysztof Kozlowski
2018-04-14 16:27         ` Paweł Chmiel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).