LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Diego Viola <diego.viola@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	len.brown@intel.com, rui.zhang@intel.com,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)
Date: Mon, 23 Apr 2018 11:02:12 -0300	[thread overview]
Message-ID: <CA+ToGPEwvkn9URS+E_vEPrSjKXbtq2KLwt04z2uxVWcTTs=oSw@mail.gmail.com> (raw)
In-Reply-To: <20180423140052.GO4129@hirez.programming.kicks-ass.net>

On Mon, Apr 23, 2018 at 11:00 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, Apr 23, 2018 at 02:38:47PM +0200, Peter Zijlstra wrote:
>> @@ -834,8 +857,12 @@ static int clocksource_unbind(struct clocksource *cs)
>>               if (curr_clocksource == cs)
>>                       return -EBUSY;
>>       }
>> +
>> +     clocksource_watchdog_lock(&flags);
>>       clocksource_dequeue_watchdog(cs);
>>       list_del_init(&cs->list);
>> +     clocksource_watchdog_lock(&flags);
>
> It works a lot better when this is _unlock();
>
>> +
>>       return 0;
>>  }
>>
>
> With that, and intel_idle.c modified to always issue the "halts in
> idle" thing, my IVB comes up in hpet mode. Let me dig up a Core2 era
> machine and see if that works too.

OK, thanks.

  reply	other threads:[~2018-04-23 14:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22  2:19 Diego Viola
2018-04-22 17:47 ` Diego Viola
2018-04-22 18:24   ` Diego Viola
2018-04-23  9:16 ` Peter Zijlstra
2018-04-23  9:27   ` Rafael J. Wysocki
2018-04-23 11:23   ` Diego Viola
2018-04-23 11:48     ` Peter Zijlstra
2018-04-23 11:49       ` Diego Viola
2018-04-23 12:38         ` Peter Zijlstra
2018-04-23 12:49           ` Diego Viola
2018-04-23 13:24             ` Diego Viola
2018-04-23 14:00           ` Peter Zijlstra
2018-04-23 14:02             ` Diego Viola [this message]
2018-04-23 15:10             ` Peter Zijlstra
2018-04-23 16:12               ` Diego Viola
2018-04-23 15:58           ` Peter Zijlstra
2018-04-23 16:44             ` Peter Zijlstra
2018-04-24  9:06               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ToGPEwvkn9URS+E_vEPrSjKXbtq2KLwt04z2uxVWcTTs=oSw@mail.gmail.com' \
    --to=diego.viola@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    --subject='Re: Experiencing freezes with kernel 4.16.3 on a desktop with E5500 CPU (bisect included)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).