LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] iio: adc128s052: Fix the error handling path of 'adc128_probe()'
@ 2021-08-21 10:37 Christophe JAILLET
  2021-08-23  6:42 ` Alexandru Ardelean
  0 siblings, 1 reply; 4+ messages in thread
From: Christophe JAILLET @ 2021-08-21 10:37 UTC (permalink / raw)
  To: jic23, lars, andy.shevchenko, angelo.compagnucci
  Cc: linux-iio, linux-kernel, kernel-janitors, Christophe JAILLET

A successful 'regulator_enable()' call should be balanced by a
corresponding 'regulator_disable()' call in the error handling path of the
probe, as already done in the remove function.

Update the error handling path accordingly.

Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/iio/adc/ti-adc128s052.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c
index 3143f35a6509..83c1ae07b3e9 100644
--- a/drivers/iio/adc/ti-adc128s052.c
+++ b/drivers/iio/adc/ti-adc128s052.c
@@ -171,7 +171,13 @@ static int adc128_probe(struct spi_device *spi)
 	mutex_init(&adc->lock);
 
 	ret = iio_device_register(indio_dev);
+	if (ret)
+		goto err_disable_regulator;
 
+	return 0;
+
+err_disable_regulator:
+	regulator_disable(adc->reg);
 	return ret;
 }
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-29 17:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 10:37 [PATCH] iio: adc128s052: Fix the error handling path of 'adc128_probe()' Christophe JAILLET
2021-08-23  6:42 ` Alexandru Ardelean
2021-08-24 19:45   ` Christophe JAILLET
2021-08-29 17:14     ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).