LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: iio: adis16240: add of_match_table entry
@ 2019-05-24  3:29 Rodrigo Ribeiro
  2019-05-24  9:34 ` Alexandru Ardelean
  0 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Ribeiro @ 2019-05-24  3:29 UTC (permalink / raw)
  To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
	Greg Kroah-Hartman
  Cc: linux-iio, devel, linux-kernel, kernel-usp, Rodrigo Ribeiro,
	Marcelo Schmitt

This patch adds of_match_table entry in device driver in order to
enable spi fallback probing.

Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
---
 drivers/staging/iio/accel/adis16240.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 8c6d23604eca..b80c8529784b 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);
 static struct spi_driver adis16240_driver = {
 	.driver = {
 		.name = "adis16240",
+		.of_match_table = adis16240_of_match,
 	},
 	.probe = adis16240_probe,
 	.remove = adis16240_remove,
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: iio: adis16240: add of_match_table entry
  2019-05-24  3:29 [PATCH] staging: iio: adis16240: add of_match_table entry Rodrigo Ribeiro
@ 2019-05-24  9:34 ` Alexandru Ardelean
  2019-05-24 13:50   ` Marcelo Schmitt
  0 siblings, 1 reply; 5+ messages in thread
From: Alexandru Ardelean @ 2019-05-24  9:34 UTC (permalink / raw)
  To: Rodrigo Ribeiro
  Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
	Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
	Greg Kroah-Hartman, linux-iio, devel, LKML, kernel-usp,
	Marcelo Schmitt, Alexandru Ardelean

On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote:
>
> This patch adds of_match_table entry in device driver in order to
> enable spi fallback probing.
>
> Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> ---
>  drivers/staging/iio/accel/adis16240.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index 8c6d23604eca..b80c8529784b 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);
>  static struct spi_driver adis16240_driver = {
>         .driver = {
>                 .name = "adis16240",
> +               .of_match_table = adis16240_of_match,

This patch is missing the actual table.

>         },
>         .probe = adis16240_probe,
>         .remove = adis16240_remove,
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: iio: adis16240: add of_match_table entry
  2019-05-24  9:34 ` Alexandru Ardelean
@ 2019-05-24 13:50   ` Marcelo Schmitt
  2019-05-24 13:54     ` Ardelean, Alexandru
  0 siblings, 1 reply; 5+ messages in thread
From: Marcelo Schmitt @ 2019-05-24 13:50 UTC (permalink / raw)
  To: Alexandru Ardelean
  Cc: Rodrigo Ribeiro, Lars-Peter Clausen, Michael Hennerich,
	Stefan Popa, Jonathan Cameron, Hartmut Knaack,
	Peter Meerwald-Stadler, Greg Kroah-Hartman, linux-iio, devel,
	LKML, kernel-usp, Alexandru Ardelean

Hi Alexandru,

On 05/24, Alexandru Ardelean wrote:
> On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote:
> >
> > This patch adds of_match_table entry in device driver in order to
> > enable spi fallback probing.
> >
> > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > ---
> >  drivers/staging/iio/accel/adis16240.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> > index 8c6d23604eca..b80c8529784b 100644
> > --- a/drivers/staging/iio/accel/adis16240.c
> > +++ b/drivers/staging/iio/accel/adis16240.c
> > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);
> >  static struct spi_driver adis16240_driver = {
> >         .driver = {
> >                 .name = "adis16240",
> > +               .of_match_table = adis16240_of_match,
> 
> This patch is missing the actual table.

Struct with compatible devices table was included separately in a
previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb.
Yeah, I also thought it was missing the match table the first time I was
this patch. It's really confusing when we have two patches, one
depending on another, that are not part of the same patch set. We're
trying to avoid things like this the most but that slipped out from our
internal review. We're sorry about that.

> 
> >         },
> >         .probe = adis16240_probe,
> >         .remove = adis16240_remove,
> > --
> > 2.20.1
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: iio: adis16240: add of_match_table entry
  2019-05-24 13:50   ` Marcelo Schmitt
@ 2019-05-24 13:54     ` Ardelean, Alexandru
  2019-05-26 14:53       ` Jonathan Cameron
  0 siblings, 1 reply; 5+ messages in thread
From: Ardelean, Alexandru @ 2019-05-24 13:54 UTC (permalink / raw)
  To: marcelo.schmitt1, ardeleanalex
  Cc: kernel-usp, lars, linux-kernel, Popa, Stefan Serban, knaack.h,
	jic23, Hennerich, Michael, linux-iio, devel, rodrigorsdc, pmeerw,
	gregkh

On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote:
> [External]
> 
> 
> Hi Alexandru,
> 
> On 05/24, Alexandru Ardelean wrote:
> > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote:
> > > 
> > > This patch adds of_match_table entry in device driver in order to
> > > enable spi fallback probing.
> > > 
> > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > > ---
> > >  drivers/staging/iio/accel/adis16240.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> > > index 8c6d23604eca..b80c8529784b 100644
> > > --- a/drivers/staging/iio/accel/adis16240.c
> > > +++ b/drivers/staging/iio/accel/adis16240.c
> > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);
> > >  static struct spi_driver adis16240_driver = {
> > >         .driver = {
> > >                 .name = "adis16240",
> > > +               .of_match_table = adis16240_of_match,
> > 
> > This patch is missing the actual table.
> 
> Struct with compatible devices table was included separately in a
> previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb.
> Yeah, I also thought it was missing the match table the first time I was
> this patch. It's really confusing when we have two patches, one
> depending on another, that are not part of the same patch set. We're
> trying to avoid things like this the most but that slipped out from our
> internal review. We're sorry about that.

No worries.

It happens to me too.

Thanks
Alex

> 
> > 
> > >         },
> > >         .probe = adis16240_probe,
> > >         .remove = adis16240_remove,
> > > --
> > > 2.20.1
> > > 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: iio: adis16240: add of_match_table entry
  2019-05-24 13:54     ` Ardelean, Alexandru
@ 2019-05-26 14:53       ` Jonathan Cameron
  0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2019-05-26 14:53 UTC (permalink / raw)
  To: Ardelean, Alexandru
  Cc: marcelo.schmitt1, ardeleanalex, kernel-usp, lars, linux-kernel,
	Popa, Stefan Serban, knaack.h, Hennerich, Michael, linux-iio,
	devel, rodrigorsdc, pmeerw, gregkh

On Fri, 24 May 2019 13:54:49 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Fri, 2019-05-24 at 10:50 -0300, Marcelo Schmitt wrote:
> > [External]
> > 
> > 
> > Hi Alexandru,
> > 
> > On 05/24, Alexandru Ardelean wrote:  
> > > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro <rodrigorsdc@gmail.com> wrote:  
> > > > 
> > > > This patch adds of_match_table entry in device driver in order to
> > > > enable spi fallback probing.
> > > > 
> > > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> > > > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > > > ---
> > > >  drivers/staging/iio/accel/adis16240.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> > > > index 8c6d23604eca..b80c8529784b 100644
> > > > --- a/drivers/staging/iio/accel/adis16240.c
> > > > +++ b/drivers/staging/iio/accel/adis16240.c
> > > > @@ -444,6 +444,7 @@ MODULE_DEVICE_TABLE(of, adis16240_of_match);
> > > >  static struct spi_driver adis16240_driver = {
> > > >         .driver = {
> > > >                 .name = "adis16240",
> > > > +               .of_match_table = adis16240_of_match,  
> > > 
> > > This patch is missing the actual table.  
> > 
> > Struct with compatible devices table was included separately in a
> > previous patch at commit d9e533b6c0a26c7ef8116b7f3477c164c07bb6fb.
> > Yeah, I also thought it was missing the match table the first time I was
> > this patch. It's really confusing when we have two patches, one
> > depending on another, that are not part of the same patch set. We're
> > trying to avoid things like this the most but that slipped out from our
> > internal review. We're sorry about that.  
> 
> No worries.
> 
> It happens to me too.
> 
> Thanks
> Alex
Oops. I should have caught that one in review as well.
Oh well, these things happen.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.  I rebased the tree to pick up on
all the other stuff in staging/staging-next after the mere window.

Thanks,

Jonathan

> 
> >   
> > >   
> > > >         },
> > > >         .probe = adis16240_probe,
> > > >         .remove = adis16240_remove,
> > > > --
> > > > 2.20.1
> > > >   


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-05-26 14:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24  3:29 [PATCH] staging: iio: adis16240: add of_match_table entry Rodrigo Ribeiro
2019-05-24  9:34 ` Alexandru Ardelean
2019-05-24 13:50   ` Marcelo Schmitt
2019-05-24 13:54     ` Ardelean, Alexandru
2019-05-26 14:53       ` Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).