LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	OSUOSL Drivers <devel@driverdev.osuosl.org>,
	Andreas Dilger <andreas.dilger@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	hpdd-discuss <HPDD-discuss@ml01.01.org>,
	Andreas Ruprecht <rupran@einserver.de>
Subject: Re: use of opaque subject lines
Date: Thu, 5 Feb 2015 18:22:23 +0000	[thread overview]
Message-ID: <CA+V-a8vQ-yDTzhNpYsP6B+j7Nr59CP+wpAo1C+TR46oR6Zd5ww@mail.gmail.com> (raw)
In-Reply-To: <20150205175715.GA6086@kroah.com>

On Thu, Feb 5, 2015 at 5:57 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Feb 05, 2015 at 04:57:09PM +0000, Lad, Prabhakar wrote:
>> On Thu, Feb 5, 2015 at 4:30 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote:
>> >
>> >> On a serious note: I do understand what you're getting at, I don't take
>> >> that personally (and I will send a v2 addressing the things above), but
>> >> honestly, this kind of answer might just be a real turn-off for other
>> >> people trying to get into kernel development...
>> >>
>> >> I don't want to start a whole new 'attitude in the kernel community'
>> >> discussion, but I can't just let this go like that, sorry.
>> >
>> > Just during the last 12 hours or so, I've seen the following l-k traffic:
>> >
>> > Subject: [PATCH] usb: host/sl811-hcd: fix sparse warning
>> > Subject: [PATCH] usb: gadget: function/f_sourcesink: fix sparse warning
>> > Subject: [PATCH] tty: vt/vt: fix sparse warning
>> > Subject: [PATCH] scsi: fix sparse warnings
>> > Subject: [PATCH] bfa: bfa_core: fix sparse warning
>> > Subject: [PATCH] scsi: fix sparse warning
>> > Subject: [PATCH] xen/acpi-processor: fix sparse warning
>> > Subject: [PATCH] scsi: initio: fix sparse warnings
>> > Subject: [PATCH] scsi: dc395x: fix sparse warning
>> > Subject: [PATCH] scsi: eata: fix sparse warning
>> > Subject: [PATCH] scsi: qla1280: fix sparse warnings
>> > Subject: [PATCH] scsi: ips: fix sparse warnings
>> > Subject: [PATCH] fbdev: via/via_clock: fix sparse warning
>> > Subject: [PATCH] usb: gadget: fix sparse warnings
>> > Subject: [PATCH] usb: gadget: fix sparse warnings
>> > Subject: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings
>> > Subject: [PATCH] xen-netback: fix sparse warning
>> > Subject: [PATCH] thermal: int340x: fix sparse warning
>> > Subject: [PATCH] vxge: fix sparse warning
>> > Subject: Re: [PATCH] xen-netback: fix sparse warning
>> > Subject: [PATCH] ixgbe: fix sparse warnings
>> > Subject: [PATCH] samsung-laptop: fix sparse warning
>> > Subject: [PATCH] x86: thinkpad_acpi.c: fix sparse warning
>> > Subject: [PATCH] Sony-laptop: fix sparse warning
>> >
>> all right I have stopped the script to send any more patches fixing
>> sparse warnings !
>
> That's not the point at all {sigh}
>
> The point is, if you are going to do fixes, also provide a valid subject
> line too.  Think of the people on the receiving end of your patch, they
> are the most valuable and limited resource our community has right now.
> You want to make it as _easy_ as possible for them to accept your
> contribution.  If you don't provide enough information, or drown them in
> redundancy, or crappy patches, they will just get frustrated and drop
> them all on the floor.
>
> And _NEVER_ have automated scripts create patches and send them out.  I
> only know of ONE person/bot that gets away with this, and you are not
> that person, sorry.  It it not a script on the receiving end of your
> output, so don't use a script to create a mess for them to dig through.
>
> I want these types of fixes, but make it easy for us to accept them, not
> hard, like Al is pointing out in very vivid detail.  To respond to his
> heartfelt plea and detailed instructions with a "fine, I'll just go
> away!" is disrespectful.
>
Sorry for that.

I agree a proper a description is needed ideally, but all these days prior to my
patches, the subject  line was 'fix sparse warnings' for such patches,
that’s the
reason I picked it for my script. I understand people get annoyed seeing so many
continuous patches with same subject line, ill make my script a bit smarter
to have detailed explanation now on.

Just a side note I verify the patch created by the script and if its
OK then only I post it to ML.

Regards,
--Prabhakar Lad

  reply	other threads:[~2015-02-05 18:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 13:36 [PATCH] staging: lustre: osc: Fix sparse warning about osc_init Andreas Ruprecht
2015-02-02 14:16 ` Al Viro
2015-02-02 19:13   ` Andreas Ruprecht
2015-02-05 16:30     ` use of opaque subject lines Al Viro
2015-02-05 16:57       ` Lad, Prabhakar
2015-02-05 17:57         ` Greg Kroah-Hartman
2015-02-05 18:22           ` Lad, Prabhakar [this message]
2015-02-05 19:32           ` Paul Bolle
2015-02-05 20:06             ` Greg Kroah-Hartman
2015-02-05 20:53               ` Joe Perches
2015-02-05 17:08       ` Joe Perches
2015-02-05 17:25         ` Dan Carpenter
2015-02-05 17:31           ` Joe Perches
2015-02-05 17:32             ` Joe Perches
2015-02-05 17:35               ` Dan Carpenter
2015-02-05 18:01                 ` Joe Perches
2015-02-05 18:26                   ` Dan Carpenter
2015-02-05 18:03         ` Greg Kroah-Hartman
2015-02-02 19:24   ` [PATCH] staging: lustre: osc: Make osc_init() static Andreas Ruprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+V-a8vQ-yDTzhNpYsP6B+j7Nr59CP+wpAo1C+TR46oR6Zd5ww@mail.gmail.com \
    --to=prabhakar.csengg@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=rupran@einserver.de \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: use of opaque subject lines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).