LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Philip Chen <philipchen@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel
Date: Mon, 13 Sep 2021 14:35:14 -0700	[thread overview]
Message-ID: <CA+cxXhme8OPMxtQqEn5yotx+EDpTBFyBuQxCcofsXUKO7gR0Sg@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n51s2MmOthCUSm0+KNBnWmNV=Zzf6eWhYJBme4LpMUUcAQ@mail.gmail.com>

On Thu, Sep 9, 2021 at 12:07 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Philip Chen (2021-09-09 11:15:27)
> > On Wed, Sep 8, 2021 at 3:27 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > Quoting Philip Chen (2021-09-08 11:18:06)
> > >
> > > > +
> > > > +       data = (len - 1) & AUX_LENGTH_MASK;
> > > > +       regmap_write(map, PAGE0_AUX_LENGTH, data);
> > > > +
> > > > +       if (request == DP_AUX_NATIVE_WRITE || request == DP_AUX_I2C_WRITE) {
> > > > +               ret = regmap_noinc_write(map, PAGE0_AUX_WDATA, buf, len);
> > > > +               if (ret < 0) {
> > > > +                       DRM_ERROR("failed to write PAGE0_AUX_WDATA");
> > >
> > > Needs a newline.
> > Adding an empty line here doesn't look like a common Linux style?
> > Could you point me to any similar instances in the Linux codebase?
>
> Sorry. I meant on the DRM_ERROR message itself. Add a newline.

Fixed in v2. PTAL.

  reply	other threads:[~2021-09-13 21:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 18:18 [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs Philip Chen
2021-09-08 18:18 ` [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel Philip Chen
2021-09-08 22:27   ` Stephen Boyd
2021-09-09 18:15     ` Philip Chen
2021-09-09 19:07       ` Stephen Boyd
2021-09-13 21:35         ` Philip Chen [this message]
2021-09-08 21:54 ` [PATCH 1/2] drm/bridge: parade-ps8640: Use regmap APIs Stephen Boyd
2021-09-09 18:29   ` Philip Chen
2021-09-09 19:09     ` Stephen Boyd
2021-09-09 21:14       ` Doug Anderson
2021-09-09 21:27         ` Stephen Boyd
2021-09-13 21:36           ` Philip Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+cxXhme8OPMxtQqEn5yotx+EDpTBFyBuQxCcofsXUKO7gR0Sg@mail.gmail.com \
    --to=philipchen@chromium.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robert.foss@linaro.org \
    --cc=swboyd@chromium.org \
    --subject='Re: [PATCH 2/2] drm/bridge: parade-ps8640: Add support for AUX channel' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).