LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/bridge: parade-ps8640: Reorg the macros
@ 2021-08-20 23:22 Philip Chen
  2021-08-24 22:37 ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Philip Chen @ 2021-08-20 23:22 UTC (permalink / raw)
  To: LKML
  Cc: swboyd, dianders, Philip Chen, Philip Chen, Andrzej Hajda,
	Daniel Vetter, David Airlie, Jernej Skrabec, Jonas Karlman,
	Laurent Pinchart, Neil Armstrong, Robert Foss, dri-devel

From: Philip Chen <philipchen@chromium.org>

Reorg the macros as follows:
(1) Group the registers on the same page together.
(2) Group the register and its bit operation together while indenting
the macros of the bit operation with one space.

Also fix a misnomer for the number of mipi data lanes.

Signed-off-by: Philip Chen <philipchen@chromium.org>
Signed-off-by: Philip Chen <philipchen@google.com>
---

 drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index 7bd0affa057a..685e9c38b2db 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -18,16 +18,18 @@
 #include <drm/drm_print.h>
 
 #define PAGE2_GPIO_H		0xa7
-#define PS_GPIO9		BIT(1)
+#define  PS_GPIO9		BIT(1)
 #define PAGE2_I2C_BYPASS	0xea
-#define I2C_BYPASS_EN		0xd0
+#define  I2C_BYPASS_EN		0xd0
 #define PAGE2_MCS_EN		0xf3
-#define MCS_EN			BIT(0)
+#define  MCS_EN			BIT(0)
+
 #define PAGE3_SET_ADD		0xfe
-#define VDO_CTL_ADD		0x13
-#define VDO_DIS			0x18
-#define VDO_EN			0x1c
-#define DP_NUM_LANES		4
+#define  VDO_CTL_ADD		0x13
+#define  VDO_DIS		0x18
+#define  VDO_EN			0x1c
+
+#define NUM_MIPI_LANES		4
 
 /*
  * PS8640 uses multiple addresses:
@@ -254,7 +256,7 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
 	dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
 			  MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
 	dsi->format = MIPI_DSI_FMT_RGB888;
-	dsi->lanes = DP_NUM_LANES;
+	dsi->lanes = NUM_MIPI_LANES;
 	ret = mipi_dsi_attach(dsi);
 	if (ret)
 		goto err_dsi_attach;
-- 
2.33.0.rc2.250.ged5fa647cd-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: parade-ps8640: Reorg the macros
  2021-08-20 23:22 [PATCH] drm/bridge: parade-ps8640: Reorg the macros Philip Chen
@ 2021-08-24 22:37 ` Doug Anderson
  2021-08-25  1:14   ` Philip Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2021-08-24 22:37 UTC (permalink / raw)
  To: Philip Chen
  Cc: LKML, Stephen Boyd, Philip Chen, Andrzej Hajda, Daniel Vetter,
	David Airlie, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
	Neil Armstrong, Robert Foss, dri-devel

Hi,

On Fri, Aug 20, 2021 at 4:22 PM Philip Chen <philipchen@chromium.org> wrote:
>
> From: Philip Chen <philipchen@chromium.org>
>
> Reorg the macros as follows:
> (1) Group the registers on the same page together.
> (2) Group the register and its bit operation together while indenting
> the macros of the bit operation with one space.
>
> Also fix a misnomer for the number of mipi data lanes.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
> Signed-off-by: Philip Chen <philipchen@google.com>
> ---
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)

This seems fine to me other than the slightly mixed up Signed-off-by
lines. I think that the git config from wherever you ran "git
send-email" had your @google.com address even if you authored the
patch with your @chomium.org address. Once that's fixed then I'm happy
to add my Reviewed-by and (unless someone objects) I'll plan to apply
this patch to drm-misc-next.

-Doug

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: parade-ps8640: Reorg the macros
  2021-08-24 22:37 ` Doug Anderson
@ 2021-08-25  1:14   ` Philip Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Philip Chen @ 2021-08-25  1:14 UTC (permalink / raw)
  To: Doug Anderson
  Cc: LKML, Stephen Boyd, Philip Chen, Andrzej Hajda, Daniel Vetter,
	David Airlie, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
	Neil Armstrong, Robert Foss, dri-devel

Hi,

On Tue, Aug 24, 2021 at 3:37 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Aug 20, 2021 at 4:22 PM Philip Chen <philipchen@chromium.org> wrote:
> >
> > From: Philip Chen <philipchen@chromium.org>
> >
> > Reorg the macros as follows:
> > (1) Group the registers on the same page together.
> > (2) Group the register and its bit operation together while indenting
> > the macros of the bit operation with one space.
> >
> > Also fix a misnomer for the number of mipi data lanes.
> >
> > Signed-off-by: Philip Chen <philipchen@chromium.org>
> > Signed-off-by: Philip Chen <philipchen@google.com>
> > ---
> >
> >  drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
>
> This seems fine to me other than the slightly mixed up Signed-off-by
> lines. I think that the git config from wherever you ran "git
> send-email" had your @google.com address even if you authored the
> patch with your @chomium.org address. Once that's fixed then I'm happy
> to add my Reviewed-by and (unless someone objects) I'll plan to apply
> this patch to drm-misc-next.

Thank you.
I just posted v2 with the double sign-off lines fixed.
PTAL.

>
> -Doug

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-25  1:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-20 23:22 [PATCH] drm/bridge: parade-ps8640: Reorg the macros Philip Chen
2021-08-24 22:37 ` Doug Anderson
2021-08-25  1:14   ` Philip Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).