LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static
@ 2019-05-29 14:34 YueHaibing
  2019-05-29 15:24 ` Vladimir Oltean
  2019-05-30 21:34 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-29 14:34 UTC (permalink / raw)
  To: olteanv, andrew, vivien.didelot, f.fainelli, davem
  Cc: linux-kernel, netdev, YueHaibing

Fix sparse warning:

drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning:
 symbol 'static_config_check_memory_size' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c
index b3c992b0abb0..7e90e62da389 100644
--- a/drivers/net/dsa/sja1105/sja1105_static_config.c
+++ b/drivers/net/dsa/sja1105/sja1105_static_config.c
@@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = {
 		"vl-forwarding-parameters-table.partspc.",
 };
 
-sja1105_config_valid_t
+static sja1105_config_valid_t
 static_config_check_memory_size(const struct sja1105_table *tables)
 {
 	const struct sja1105_l2_forwarding_params_entry *l2_fwd_params;
-- 
2.17.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static
  2019-05-29 14:34 [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static YueHaibing
@ 2019-05-29 15:24 ` Vladimir Oltean
  2019-05-30 21:34 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2019-05-29 15:24 UTC (permalink / raw)
  To: YueHaibing
  Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
	linux-kernel, netdev

On Wed, 29 May 2019 at 17:35, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix sparse warning:
>
> drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning:
>  symbol 'static_config_check_memory_size' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c
> index b3c992b0abb0..7e90e62da389 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.c
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.c
> @@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = {
>                 "vl-forwarding-parameters-table.partspc.",
>  };
>
> -sja1105_config_valid_t
> +static sja1105_config_valid_t
>  static_config_check_memory_size(const struct sja1105_table *tables)
>  {
>         const struct sja1105_l2_forwarding_params_entry *l2_fwd_params;
> --
> 2.17.1
>
>

Acked-by: Vladimir Oltean <olteanv@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static
  2019-05-29 14:34 [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static YueHaibing
  2019-05-29 15:24 ` Vladimir Oltean
@ 2019-05-30 21:34 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-05-30 21:34 UTC (permalink / raw)
  To: yuehaibing
  Cc: olteanv, andrew, vivien.didelot, f.fainelli, linux-kernel, netdev

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 29 May 2019 22:34:32 +0800

> Fix sparse warning:
> 
> drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning:
>  symbol 'static_config_check_memory_size' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-30 21:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 14:34 [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static YueHaibing
2019-05-29 15:24 ` Vladimir Oltean
2019-05-30 21:34 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).