From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8106C004C9 for ; Tue, 7 May 2019 19:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D54020675 for ; Tue, 7 May 2019 19:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="F6ld+tZI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726542AbfEGTYq (ORCPT ); Tue, 7 May 2019 15:24:46 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:41053 "EHLO mail-lf1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbfEGTYq (ORCPT ); Tue, 7 May 2019 15:24:46 -0400 Received: by mail-lf1-f41.google.com with SMTP id d8so12678236lfb.8 for ; Tue, 07 May 2019 12:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=F6ld+tZIKD1TRL0AE6fEb2WqRxcP76uZx0RNPDleIxyf5RJkwYPqK0Bs9zD4aODmmE 4NNavp1nVKPc4olfZNB0csbl8Mt2jrfw/4cvqI1dQpb6hDyRxWSjJ7Yy4Q29HBvFbOfA JtYubFLJeY+4ZpX9T0ONIWuycTh2DIrMPc1SCGpQzEDby6c9B7ZikuGkc84pDR1T+N6M 9spwBfJp4nacEIzecHYOyudxpJIHO5m/IUkW4JFPQf66ZbDiyfZVU/nw8vjKyLhqtWer 9FWQL1ENLRVadfjFY2rI1CERtp+W1p4k6aV0bmDTRupY82fFnsyC2IcEpAqT8PcIv623 jo8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9VH2cI54WOtf0TgOVICv7YfH/dmJx9RgBuqx8oc1Mjk=; b=aWfPhZgC5lTAcIAN//9A+YMdBHeNrkUzHbG8QQn8vn6TnuV0rOCbC+AFuP4FaeNyDs 8fUNtUZKPiJGrwz97IZJz8A8081wZAsuULRfvs6nlsVGvWO2NJJSOF0MueyOT8PD6Uei SQxTLsvhfMkrQ0xX7QdMWwwZ0aRhu/m8N2ywgFw8BY7ft+3zafabycb8K+1YGgcXgVMP Egv6h+oX5hKckDtnLBbB6rguqwOBfM5a7iTi0zF8n5gv0V5NUNtuQLMRZutqTdMfZbI9 20rc3/j8tUZkfdQSRDmr+mgcWhQZAF0JOHvPkGpwZAboeileDUSybv8U9yTVSKl92BoF Go1A== X-Gm-Message-State: APjAAAU8XlcATCk5d/B8JMg5TgvptdqKbDU3Mtr9D15hmCa9pqtrnOT0 rT3IisDHnROsvPScC7D/YN95elt5EDFfeHd4C6DwEBKXKx/fW81c X-Google-Smtp-Source: APXvYqyg8BJ0mWtUnVsZIHd1nlxtEq/TQoby+zEdt5YK0v6BrfynU4C4tehxKhziDkaheD+CcYQOn+z9h45ZgO05JFs= X-Received: by 2002:ac2:51a9:: with SMTP id f9mr9455271lfk.56.1557257083907; Tue, 07 May 2019 12:24:43 -0700 (PDT) MIME-Version: 1.0 References: <20190426050039.17460-1-pagupta@redhat.com> <20190426050039.17460-5-pagupta@redhat.com> In-Reply-To: <20190426050039.17460-5-pagupta@redhat.com> From: =?UTF-8?Q?Jakub_Staro=C5=84?= Date: Tue, 7 May 2019 12:24:32 -0700 Message-ID: Subject: Re: [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported To: Pankaj Gupta Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-acpi@vger.kernel.org, qemu-devel@nongnu.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jack@suse.cz, mst@redhat.com, jasowang@redhat.com, david@fromorbit.com, lcapitulino@redhat.com, adilger.kernel@dilger.ca, zwisler@kernel.org, aarcange@redhat.com, dave.jiang@intel.com, darrick.wong@oracle.com, vishal.l.verma@intel.com, david@redhat.com, willy@infradead.org, hch@infradead.org, jmoyer@redhat.com, nilal@redhat.com, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval.shaia@oracle.com, stefanha@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, kwolf@redhat.com, tytso@mit.edu, xiaoguangrong.eric@gmail.com, cohuck@redhat.com, rjw@rjwysocki.net, imammedo@redhat.com, Stephen Barber Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pankaj Gupta Date: Thu, Apr 25, 2019 at 10:00 PM > +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma, > + struct dax_device *dax_dev) > +{ > + return !(vma->flags & VM_SYNC); > +} Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`? There is no field named `flags` in `struct vm_area_struct`. Thank you, Jakub