LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Marc Orr <marcorr@google.com>
To: Peter Gonda <pgonda@google.com>
Cc: kvm list <kvm@vger.kernel.org>,
	Sean Christopherson <seanjc@google.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3 V6] selftest: KVM: Add intra host migration
Date: Tue, 31 Aug 2021 08:20:43 -0700	[thread overview]
Message-ID: <CAA03e5Fp2PeY162sL6YVn44an28RBNvbRRF4HLJ_vea9V69Ryg@mail.gmail.com> (raw)
In-Reply-To: <CAMkAt6r8X5XbhRSbfX5vfHn+F40Mp_Ou+qmtUqeDBCtTF1oTxg@mail.gmail.com>

> > > > +
> > > > +       for (i = 0; i < 1000; ++i) {
> > > > +               j = input->source_fds[i % LOCK_TESTING_THREADS];
> > > > +               cap.args[0] = input->source_fds[j];
> > > > +               /*
> > > > +                * Call IOCTL directly without checking return code. We are
> > > > +                * simply trying to confirm there is no deadlock from userspace
> > > > +                * not check correctness of migration here.
> > > > +                */
> > > > +               ioctl(input->vm->fd, KVM_ENABLE_CAP, &cap);
> > >
> > > Should we use `vm_enable_cap()` here?
> > >
>
> I took all other suggestions but this one I just updated the comment.
> vm_enable_cap TEST_ASSERT()s if the ioctl fails. Since we are just
> randomly iterating through a bunch of ioclts we fail often so this
> would kill the test.

Gah, of course! My bad. Anyway, sounds good and thanks!

  reply	other threads:[~2021-08-31 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 21:29 Peter Gonda
2021-08-31 13:24 ` Marc Orr
2021-08-31 13:25   ` Marc Orr
2021-08-31 15:03     ` Peter Gonda
2021-08-31 15:20       ` Marc Orr [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-30 21:29 Peter Gonda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA03e5Fp2PeY162sL6YVn44an28RBNvbRRF4HLJ_vea9V69Ryg@mail.gmail.com \
    --to=marcorr@google.com \
    --cc=brijesh.singh@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgonda@google.com \
    --cc=seanjc@google.com \
    --subject='Re: [PATCH 3/3 V6] selftest: KVM: Add intra host migration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).