LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Michael Straube <straube.linux@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Martin Kaiser <martin@kaiser.cx>,
	"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] staging: r8188eu: use is_multicast_ether_addr instead of IS_MCAST
Date: Mon, 23 Aug 2021 23:15:03 +0100	[thread overview]
Message-ID: <CAA=Fs0=Yq9PMEProT4RPTan4K=aL-zkQw=y855vQu+iBTPztHQ@mail.gmail.com> (raw)
In-Reply-To: <20210823120106.9633-1-straube.linux@gmail.com>

On Mon, 23 Aug 2021 at 13:02, Michael Straube <straube.linux@gmail.com> wrote:
>
> This series replaces most uses of the custom IS_MCAST macro with
> is_multicast_ether_addr. The goal is to get rid of IS_MCAST.
> There is only one usage left in rtw_sta_mgt.c, but that one needs
> more effort to verify that the buffers are properly aligned, so I
> left it as is for now.
>
> Michael Straube (8):
>   staging: r8188eu: ensure proper alignment for eth address buffers
>   staging: r8188eu: use is_multicast_ether_addr in core/rtw_mlme.c
>   staging: r8188eu: use is_multicast_ether_addr in core/rtw_mp.c
>   staging: r8188eu: use is_multicast_ether_addr in core/rtw_recv.c
>   staging: r8188eu: use is_multicast_ether_addr in core/rtw_security.c
>   staging: r8188eu: use is_multicast_ether_addr in core/rtw_xmit.c
>   staging: r8188eu: use is_multicast_ether_addr in hal/rtl8188eu_xmit.c
>   staging: r8188eu: use is_multicast_ether_addr in os_dep/recv_linux.c
>
>  drivers/staging/r8188eu/core/rtw_mlme.c      |  4 ++--
>  drivers/staging/r8188eu/core/rtw_mp.c        |  4 ++--
>  drivers/staging/r8188eu/core/rtw_recv.c      | 20 ++++++++++----------
>  drivers/staging/r8188eu/core/rtw_security.c  |  8 ++++----
>  drivers/staging/r8188eu/core/rtw_xmit.c      | 15 ++++++---------
>  drivers/staging/r8188eu/hal/rtl8188eu_xmit.c |  3 +--
>  drivers/staging/r8188eu/include/rtw_recv.h   | 10 +++++-----
>  drivers/staging/r8188eu/include/rtw_xmit.h   |  8 ++++----
>  drivers/staging/r8188eu/os_dep/recv_linux.c  |  2 +-
>  9 files changed, 35 insertions(+), 39 deletions(-)
>
> --
> 2.32.0
>

Dear Michael,

Based on my limited knowledge, looks good to me. Also I built and
runtime tested it with my N10-Nano, driver works well still. Many
thanks.

For whole series:
Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

      parent reply	other threads:[~2021-08-23 22:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 12:00 Michael Straube
2021-08-23 12:00 ` [PATCH 1/8] staging: r8188eu: ensure proper alignment for eth address buffers Michael Straube
2021-08-23 12:01 ` [PATCH 2/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_mlme.c Michael Straube
2021-08-23 12:01 ` [PATCH 3/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_mp.c Michael Straube
2021-08-23 12:01 ` [PATCH 4/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_recv.c Michael Straube
2021-08-23 12:01 ` [PATCH 5/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_security.c Michael Straube
2021-08-23 12:01 ` [PATCH 6/8] staging: r8188eu: use is_multicast_ether_addr in core/rtw_xmit.c Michael Straube
2021-08-23 12:01 ` [PATCH 7/8] staging: r8188eu: use is_multicast_ether_addr in hal/rtl8188eu_xmit.c Michael Straube
2021-08-23 12:01 ` [PATCH 8/8] staging: r8188eu: use is_multicast_ether_addr in os_dep/recv_linux.c Michael Straube
2021-08-23 22:15 ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA=Fs0=Yq9PMEProT4RPTan4K=aL-zkQw=y855vQu+iBTPztHQ@mail.gmail.com' \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=straube.linux@gmail.com \
    --subject='Re: [PATCH 0/8] staging: r8188eu: use is_multicast_ether_addr instead of IS_MCAST' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).