LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] staging: r8188eu: remove unused function parameters
Date: Thu, 12 Aug 2021 00:50:41 +0100 [thread overview]
Message-ID: <CAA=Fs0kYeHsuAUPXZGpkuo4w5WKwjFDR8vURxSDGHZ-nFtZfyA@mail.gmail.com> (raw)
In-Reply-To: <20210811201450.31366-2-martin@kaiser.cx>
On Wed, 11 Aug 2021 at 21:15, Martin Kaiser <martin@kaiser.cx> wrote:
>
> rtw_usb_if1_init and chip_by_usb_id do not need a
> struct usb_device_id parameter.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/os_dep/usb_intf.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index 8f1e33d2fff7..4bf89b78a74a 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -250,8 +250,7 @@ static void usb_dvobj_deinit(struct usb_interface *usb_intf)
>
> }
>
> -static void chip_by_usb_id(struct adapter *padapter,
> - const struct usb_device_id *pdid)
> +static void chip_by_usb_id(struct adapter *padapter)
> {
> padapter->chip_type = NULL_CHIP_TYPE;
> hal_set_hw_type(padapter);
> @@ -569,7 +568,7 @@ int rtw_resume_process(struct adapter *padapter)
> */
>
> static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
> - struct usb_interface *pusb_intf, const struct usb_device_id *pdid)
> + struct usb_interface *pusb_intf)
> {
> struct adapter *padapter = NULL;
> struct net_device *pnetdev = NULL;
> @@ -587,7 +586,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
>
> /* step 1-1., decide the chip_type via vid/pid */
> padapter->interface_type = RTW_USB;
> - chip_by_usb_id(padapter, pdid);
> + chip_by_usb_id(padapter);
>
> if (rtw_handle_dualmac(padapter, 1) != _SUCCESS)
> goto free_adapter;
> @@ -722,7 +721,7 @@ static int rtw_drv_init(struct usb_interface *pusb_intf, const struct usb_device
> if (!dvobj)
> goto exit;
>
> - if1 = rtw_usb_if1_init(dvobj, pusb_intf, pdid);
> + if1 = rtw_usb_if1_init(dvobj, pusb_intf);
> if (!if1) {
> DBG_88E("rtw_init_primarystruct adapter Failed!\n");
> goto free_dvobj;
> --
> 2.20.1
>
Dear Martin,
Looks good.
Acked-by: Phillip Potter <phil@philpotter.co.uk>
Regards,
Phil
next prev parent reply other threads:[~2021-08-11 23:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 20:14 [PATCH 1/5] staging: r8188eu: remove unused efuse hal components Martin Kaiser
2021-08-11 20:14 ` [PATCH 2/5] staging: r8188eu: remove unused function parameters Martin Kaiser
2021-08-11 23:50 ` Phillip Potter [this message]
2021-08-11 20:14 ` [PATCH 3/5] staging: r8188eu: (trivial) remove a duplicate debug print Martin Kaiser
2021-08-11 23:53 ` Phillip Potter
2021-08-12 6:17 ` Dan Carpenter
2021-08-13 10:05 ` Martin Kaiser
2021-08-13 12:42 ` Fabio M. De Francesco
2021-08-14 16:54 ` Phillip Potter
2021-08-14 18:18 ` Fabio M. De Francesco
2021-08-11 20:14 ` [PATCH 4/5] staging: r8188eu: use proper way to build a module Martin Kaiser
2021-08-11 23:53 ` Phillip Potter
2021-08-11 20:14 ` [PATCH 5/5] staging: r8188eu: remove CONFIG_USB_HCI from Makefile Martin Kaiser
2021-08-11 23:54 ` Phillip Potter
2021-08-11 23:49 ` [PATCH 1/5] staging: r8188eu: remove unused efuse hal components Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA=Fs0kYeHsuAUPXZGpkuo4w5WKwjFDR8vURxSDGHZ-nFtZfyA@mail.gmail.com' \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).