LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Michael Straube <straube.linux@gmail.com>,
	linux-staging@lists.linux.dev,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] staging: r8188eu: remove unused efuse hal components
Date: Thu, 12 Aug 2021 00:49:57 +0100	[thread overview]
Message-ID: <CAA=Fs0kjxzObRFYU30KhAu_GxA9oZ2R45MHCA-oD3NoFqW88vA@mail.gmail.com> (raw)
In-Reply-To: <20210811201450.31366-1-martin@kaiser.cx>

On Wed, 11 Aug 2021 at 21:15, Martin Kaiser <martin@kaiser.cx> wrote:
>
> struct hal_data_8188e contains some components related to efuses which
> are not used for rl8188eu.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/staging/r8188eu/include/rtl8188e_hal.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index ea879572d6e1..3939bf053de1 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -263,9 +263,6 @@ struct hal_data_8188e {
>         u8      bAPKThermalMeterIgnore;
>
>         bool    EepromOrEfuse;
> -       /* 92C:256bytes, 88E:512bytes, we use union set (512bytes) */
> -       u8      EfuseMap[2][HWSET_MAX_SIZE_512];
> -       u8      EfuseUsedPercentage;
>         struct efuse_hal        EfuseHal;
>
>         u8      Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> --
> 2.20.1
>

Dear Martin,

Looks good.

Acked-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

      parent reply	other threads:[~2021-08-11 23:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 20:14 [PATCH 1/5] staging: r8188eu: remove unused efuse hal components Martin Kaiser
2021-08-11 20:14 ` [PATCH 2/5] staging: r8188eu: remove unused function parameters Martin Kaiser
2021-08-11 23:50   ` Phillip Potter
2021-08-11 20:14 ` [PATCH 3/5] staging: r8188eu: (trivial) remove a duplicate debug print Martin Kaiser
2021-08-11 23:53   ` Phillip Potter
2021-08-12  6:17     ` Dan Carpenter
2021-08-13 10:05       ` Martin Kaiser
2021-08-13 12:42         ` Fabio M. De Francesco
2021-08-14 16:54           ` Phillip Potter
2021-08-14 18:18             ` Fabio M. De Francesco
2021-08-11 20:14 ` [PATCH 4/5] staging: r8188eu: use proper way to build a module Martin Kaiser
2021-08-11 23:53   ` Phillip Potter
2021-08-11 20:14 ` [PATCH 5/5] staging: r8188eu: remove CONFIG_USB_HCI from Makefile Martin Kaiser
2021-08-11 23:54   ` Phillip Potter
2021-08-11 23:49 ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA=Fs0kjxzObRFYU30KhAu_GxA9oZ2R45MHCA-oD3NoFqW88vA@mail.gmail.com' \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).