LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ezequiel Garcia <email@example.com>
To: "firstname.lastname@example.org" <email@example.com>
Cc: Daniel Vetter <firstname.lastname@example.org>,
Alexandre Courbot <email@example.com>,
Hans Verkuil <firstname.lastname@example.org>,
Tzung-Bi Shih <email@example.com>,
Tiffany Lin <firstname.lastname@example.org>,
Andrew-CT Chen <email@example.com>,
Mauro Carvalho Chehab <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Matthias Brugger <firstname.lastname@example.org>,
Tomasz Figa <email@example.com>,
Hsin-Yi Wang <firstname.lastname@example.org>,
Fritz Koenig <email@example.com>,
Irui Wang <firstname.lastname@example.org>,
Linux Kernel Mailing List <email@example.com>,
"moderated list:ARM/Mediatek SoC support"
George Sun <firstname.lastname@example.org>
Subject: Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode
Date: Sun, 22 Aug 2021 11:32:32 -0300 [thread overview]
Message-ID: <CAAEAJfCdvj4drV+YSbvyR30b0+50RpJcOYdEoNODTdrAoL6+vA@mail.gmail.com> (raw)
On Fri, 20 Aug 2021 at 04:59, email@example.com
> Hi Ezequiel,
> Thanks for your detail feedback.
> On Thu, 2021-08-19 at 11:10 -0300, Ezequiel Garcia wrote:
> > On Thu, 19 Aug 2021 at 04:13, firstname.lastname@example.org
> > <email@example.com> wrote:
> > >
> > > Hi Ezequiel,
> > >
> > > Thanks for your suggestion.
> > >
> > > On Wed, 2021-08-18 at 11:11 -0300, Ezequiel Garcia wrote:
> > > > +danvet
> > > >
> > > > Hi,
> > > >
> > > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong <firstname.lastname@example.org>
> > > > wrote:
> > > > >
> > > > > This series adds support for multi hardware decode into mtk-vcodec,
> > > > > by first
> > > > > adding component framework to manage each hardware information:
> > > > > interrupt,
> > > > > clock, register bases and power. Secondly add core thread to deal
> > > > > with core
> > > > > hardware message, at the same time, add msg queue for different
> > > > > hardware
> > > > > share messages. Lastly, the architecture of different specs are not
> > > > > the same,
> > > > > using specs type to separate them.
> > > > >
> > > >
> > > > I don't think it's a good idea to introduce the component API in the
> > > > media subsystem. It doesn't seem to be maintained, IRC there's not
> > > > even
> > > > a maintainer for it, and it has some issues that were never
> > > > addressed.
> > > >
> > > > It would be really important to avoid it. Is it really needed in the
> > > > first place?
> > > >
> > > > Thanks,
> > > > Ezequiel
> > >
> > > For there are many hardware need to use, mt8192 is three and mt8195 is
> > > five. Maybe need more to be used in the feature.
> > >
> > > Each hardware has independent clk/power/iommu port/irq.
> > > Use component interface in prob to get each component's information.
> > > Just enable the hardware when need to use it, very convenient and
> > > simple.
> > >
> > > I found that there are many modules use component to manage hardware
> > > information, such as iommu and drm etc.
> > >
> > Many drivers support multiple hardware variants, where each variant
> > has a different number of clocks or interrupts, see for instance
> > struct hantro_variant which allows to expose different codec cores,
> > some having both decoder/encoder, and some having just a decoder.
> > The component API is mostly used by DRM to aggregate independent
> > subdevices (called components) into an aggregated driver.
> > For instance, a DRM driver needs to glue together the HDMI, MIPI,
> > and plany controller, or any other hardware arrangement where
> > devices can be described independently.
> The usage scenario is very similar with drm and iommu, So decide to use
> component framework.
> Decode has three/five or more hardwares, these hardware are independent.
> For mt8183 just need core hardware to decode, but mt8192 has lat,soc and
> core hardware to decode. When lat need to use, just enable lat hardware,
> core is the same.And mt8195 will has two cores, each core can work well
> For each component device just used to open their power/clk/iommu
> port/irq when master need to enable it. The main logic is in master
> > The component API may look simple but has some issues, it's not easy
> > to debug, and can cause troubles if not used as expected .
> > It's worth making sure you actually need a framework
> > to glue different devices together.
> Each hardware has its index, master can get hardware information
> according these index, looks not complex. What do you mean about not
> easy to debug?
> > > Do you have any other suggestion for this architecture?
> > >
> > Looking at the different patchsets that are posted, it's not clear
> > to me what exactly are the different architectures that you intend
> > to support, can you some documentation which clarifies that?
> Have five hardwares lat,soc,core0,core1 and main. Lat thread can use lat
> soc and main, core thread can use soc,lat, core0 and core1. Core thread
> can be used or not for different project.
Can you explain what are these lat,soc and core threads for?
> Also Need to use these
> hardware dynamic at the same time. So I use component framework, just
> need to know the used hardware index according to different
> project.Need not to do complex logic to manage these hardwares.
I am not thrilled to see the component framework introduced to the
media subsystem. Like I said, it has no clear maintainer, and it's not
easy to use.
The media subsystem has some support which AFAIK does the same thing,
see v4l2-async, which is maintained by media people.
Please push a branch based on media/master containing these changes.
I see there are other patch series for this device, but it's hard to track
which goes first, etc.
next prev parent reply other threads:[~2021-08-22 14:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 2:57 Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 01/15] media: mtk-vcodec: Get numbers of register bases from DT Yunfei Dong
2021-08-20 3:29 ` Tzung-Bi Shih
2021-08-11 2:57 ` [PATCH v5, 02/15] media: mtk-vcodec: Align vcodec wake up interrupt interface Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 03/15] media: mtk-vcodec: Refactor vcodec pm interface Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 04/15] media: mtk-vcodec: Use component framework to manage each hardware information Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 05/15] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings Yunfei Dong
2021-08-17 20:33 ` Rob Herring
2021-08-11 2:57 ` [PATCH v5, 06/15] media: mtk-vcodec: Use pure single core for MT8183 Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 07/15] media: mtk-vcodec: Add irq interface for multi hardware Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 08/15] media: mtk-vcodec: Add msg queue feature for lat and core architecture Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 09/15] media: mtk-vcodec: Generalize power and clock on/off interfaces Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 10/15] media: mtk-vcodec: Add new interface to lock different hardware Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 11/15] media: mtk-vcodec: Add core thread Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec Yunfei Dong
2021-08-11 2:57 ` [PATCH v5, 13/15] dt-bindings: media: mtk-vcodec: Adds decoder dt-bindings for mt8192 Yunfei Dong
2021-08-11 17:24 ` Rob Herring
2021-08-17 3:38 ` yunfei.dong
2021-08-11 17:41 ` Rob Herring
2021-08-11 17:59 ` Laurent Pinchart
2021-08-17 3:50 ` yunfei.dong
2021-08-29 20:54 ` Ezequiel Garcia
2021-09-01 3:49 ` yunfei.dong
2021-09-01 11:50 ` Ezequiel Garcia
2021-09-02 6:09 ` yunfei.dong
2021-09-03 4:02 ` Chen-Yu Tsai
2021-08-29 20:50 ` Ezequiel Garcia
2021-08-30 6:07 ` yunfei.dong
2021-08-30 9:00 ` Laurent Pinchart
2021-08-11 2:58 ` [PATCH v5, 14/15] media: mtk-vcodec: Add core dec and dec end ipi msg Yunfei Dong
2021-08-11 2:58 ` [PATCH v5, 15/15] media: mtk-vcodec: Use codec type to separate different hardware Yunfei Dong
2021-08-18 14:11 ` [PATCH v5, 00/15] Using component framework to support multi hardware decode Ezequiel Garcia
2021-08-19 7:13 ` yunfei.dong
2021-08-19 14:10 ` Ezequiel Garcia
2021-08-20 7:59 ` yunfei.dong
2021-08-22 14:32 ` Ezequiel Garcia [this message]
2021-08-24 10:21 ` yunfei.dong
2021-08-25 5:48 ` yunfei.dong
2021-08-22 16:50 ` Daniel Vetter
2021-08-22 17:57 ` Ezequiel Garcia
2021-08-26 9:14 ` Daniel Vetter
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).