From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD54C04AB3 for ; Mon, 27 May 2019 13:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 501F1208CA for ; Mon, 27 May 2019 13:25:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="BbvtYWZg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbfE0NZx (ORCPT ); Mon, 27 May 2019 09:25:53 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:44212 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbfE0NZx (ORCPT ); Mon, 27 May 2019 09:25:53 -0400 Received: by mail-vs1-f67.google.com with SMTP id w124so10487988vsb.11 for ; Mon, 27 May 2019 06:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TnqAkKZ/K76fAJWhEEPhgphkdIHfqKGIyyQzSf7jGME=; b=BbvtYWZg5ZkOTgXuU5uOKiPR9P+u1cNbjMcHQ0bPb8azbm/FfT4yBlauUVp3em1+1j WZu5L2UC9NKmnUmn7T7BTBAkJkeohU1meVLncwtcXjZrLZoknxGGqRxPxtBjRmJLoFoP i3PW+wuEJ4ShMtK0rWFE0ub1VEasVVK0DhewCXLc3hefACh3/1FYsoXBXrva2Azu8hRm 63DpSp63Q2YukGWqGo/GUAUWjYsFjdj0kbxyGZ1jOfCgwHmbAbV9s4XNQJQLVRBKGMUS BpJqJsQk397yx+u6FjnmkEcDWJpZPd2qe7q/l06gW94TTsb9RmCOS5IFXIpZpnE2Sd2F RNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TnqAkKZ/K76fAJWhEEPhgphkdIHfqKGIyyQzSf7jGME=; b=FRAMwAP55pMAVAvcCDEVWinqaB0H4GaDy6QWKFIVEdJsyZ3krLEzuB+WT1QtAYBaNH AJR6QP6A89jdOGTvfd4Doi2O3DWiyZqPaaYLQQU6hXfmqCeFiL6JOcMNqPfROU53qmyS HuhXrnuvzHhAMZB4+U0BoNWQ0Bm9KSVzRynj4b+YjR+m36Rsr14Gv9Lno+FMn9bcpzsq eq8yd07mFNvS/Pk6LRe6o9Y4z0k7poO+npAssfooSGrje7POrMxBKSqzBtcRKI0HHV+H +exBz8V/PjQnfWibLOCMn+1uAwuYho/jCuXlQLD3t5fpz2/C2aqAW8gt0+Bq2PBtt0rw GtcA== X-Gm-Message-State: APjAAAXObvCnN+cRsuTxtRn9gVGeMnbh960yB4zk97FSQ3PfjGqCmHXY Jx6bklw/NhhjdNPW+JpS4Fs0oENq9iWcDRh4KagEww== X-Google-Smtp-Source: APXvYqy4tUwxlDxM4P+E2AZD0QtkW0gxj57YCASYDfSgwOAeG101rQ0S+ov4VOwe/SZeF71qMCMhrXm9O39FqYVPGhM= X-Received: by 2002:a67:f057:: with SMTP id q23mr57437576vsm.116.1558963552162; Mon, 27 May 2019 06:25:52 -0700 (PDT) MIME-Version: 1.0 References: <1558515574-11155-1-git-send-email-sagar.kadam@sifive.com> <1558515574-11155-2-git-send-email-sagar.kadam@sifive.com> <20190524204012.GA2580@bogus> In-Reply-To: <20190524204012.GA2580@bogus> From: Sagar Kadam Date: Mon, 27 May 2019 18:55:41 +0530 Message-ID: Subject: Re: [PATCH v7 1/3] dt-bindings: i2c: extend existing opencore bindings. To: Rob Herring Cc: Mark Rutland , peter@korsgaard.com, Andrew Lunn , Palmer Dabbelt , Paul Walmsley , Linux I2C , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Sat, May 25, 2019 at 2:10 AM Rob Herring wrote: > > On Wed, May 22, 2019 at 02:29:32PM +0530, Sagar Shrikant Kadam wrote: > > Reformatted compatibility strings to one valid combination on > > each line. > > Add FU540-C000 specific device tree bindings to already available > > i2-ocores file. This device is available on > > HiFive Unleashed Rev A00 board. Move interrupt under optional > > property list as this can be optional. > > > > The FU540-C000 SoC from sifive, has an Opencore's I2C block > > reimplementation. > > > > The DT compatibility string for this IP is present in HDL and available at. > > https://github.com/sifive/sifive-blocks/blob/master/src/main/scala/devices/i2c/I2C.scala#L73 > > > > Signed-off-by: Sagar Shrikant Kadam > > --- > > Documentation/devicetree/bindings/i2c/i2c-ocores.txt | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > index 17bef9a..db96951 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > @@ -1,9 +1,13 @@ > > Device tree configuration for i2c-ocores > > > > Required properties: > > -- compatible : "opencores,i2c-ocores" or "aeroflexgaisler,i2cmst" > > +- compatible : "opencores,i2c-ocores", > > + "aeroflexgaisler,i2cmst", > > + "sifive,fu540-c000-i2c","sifive,i2c0". > > space needed ^ > > And drop the end of line commas and period. > > > > + For Opencore based I2C IP block reimplemented in > > + FU540-C000 SoC.Please refer sifive-blocks-ip-versioning.txt > > And here too. > > And 'refer to' I will incorporate the changes you have suggested. Thanks, Sagar Kadam > > > + for additional details. > > - reg : bus address start and address range size of device > > -- interrupts : interrupt number > > - clocks : handle to the controller clock; see the note below. > > Mutually exclusive with opencores,ip-clock-frequency > > - opencores,ip-clock-frequency: frequency of the controller clock in Hz; > > @@ -12,6 +16,7 @@ Required properties: > > - #size-cells : should be <0> > > > > Optional properties: > > +- interrupts : interrupt number. > > - clock-frequency : frequency of bus clock in Hz; see the note below. > > Defaults to 100 KHz when the property is not specified > > - reg-shift : device register offsets are shifted by this value > > -- > > 1.9.1 > >