LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Erdem Aktas <erdemaktas@google.com> To: Maxim Levitsky <mlevitsk@redhat.com> Cc: Xiaoyao Li <xiaoyao.li@intel.com>, linux-kselftest@vger.kernel.org, Sean Christopherson <seanjc@google.com>, Peter Gonda <pgonda@google.com>, Marc Orr <marcorr@google.com>, Sagi Shahar <sagis@google.com>, Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan <shuah@kernel.org>, Andrew Jones <drjones@redhat.com>, Ben Gardon <bgardon@google.com>, Peter Xu <peterx@redhat.com>, David Matlack <dmatlack@google.com>, Emanuele Giuseppe Esposito <eesposit@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Ricardo Koller <ricarkol@google.com>, Eric Auger <eric.auger@redhat.com>, Yanan Wang <wangyanan55@huawei.com>, Aaron Lewis <aaronlewis@google.com>, Jim Mattson <jmattson@google.com>, Oliver Upton <oupton@google.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, Peter Shier <pshier@google.com>, Axel Rasmussen <axelrasmussen@google.com>, Zhenzhong Duan <zhenzhong.duan@intel.com>, "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>, Like Xu <like.xu@linux.intel.com>, open list <linux-kernel@vger.kernel.org>, "open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@vger.kernel.org> Subject: Re: [RFC PATCH 1/4] KVM: selftests: Add support for creating non-default type VMs Date: Wed, 4 Aug 2021 13:29:54 -0700 [thread overview] Message-ID: <CAAYXXYx_CFKBhFjqfz_wyh6bPPbWpTPCDfGmmLGqiugvfqA3Dg@mail.gmail.com> (raw) In-Reply-To: <c82a3abe00d387985ac806c8ff062cc29e192bbd.camel@redhat.com> Thank you all for all that great feedback! I will include them in my v2. On Wed, Aug 4, 2021 at 7:46 AM Maxim Levitsky <mlevitsk@redhat.com> wrote: > > > > > Can we pass KVM_X86_LEGACY_VM (whatever name when it's upstreamed) > > > > instead of 0? > > > I was originally thinking of doing this but Sean has suggested that we should use 0 to make it arch-agnostic for creating default VMs. +Sean Christopherson : What do you think? > > KVM_X86_NORMAL_VM is a very good name IMHO as well. > Thanks! Sounds good to me. > For example: > > struct vm_options { > enum vm_guest_mode mode; > uint64_t phy_pages; > int perm; > int type; > }; > > struct kvm_vm *vm_create(const struct vm_options *options) > { > ... > } > I liked this idea, I will see if I can include it in my v2. Thank you so much again. -Erdem
next prev parent reply other threads:[~2021-08-04 20:30 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-26 18:37 [RFC PATCH 0/4] TDX KVM selftests Erdem Aktas 2021-07-26 18:37 ` [RFC PATCH 1/4] KVM: selftests: Add support for creating non-default type VMs Erdem Aktas 2021-07-26 22:26 ` David Matlack 2021-07-27 20:47 ` Sean Christopherson 2021-07-28 16:07 ` David Matlack 2021-07-28 20:11 ` Andrew Jones 2021-08-04 6:09 ` Xiaoyao Li 2021-08-04 14:24 ` Maxim Levitsky 2021-08-04 14:42 ` Xiaoyao Li 2021-08-04 14:45 ` Maxim Levitsky 2021-08-04 20:29 ` Erdem Aktas [this message] 2021-08-04 23:31 ` Sean Christopherson 2021-07-26 18:37 ` [RFC PATCH 2/4] KVM: selftest: Add helper functions to create TDX VMs Erdem Aktas 2021-07-26 18:37 ` [RFC PATCH 3/4] KVM: selftest: Adding TDX life cycle test Erdem Aktas 2021-07-26 22:42 ` David Matlack 2021-07-26 18:37 ` [RFC PATCH 4/4] KVM: selftest: Adding test case for TDX port IO Erdem Aktas 2021-07-28 4:02 ` [RFC PATCH 0/4] TDX KVM selftests Duan, Zhenzhong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAYXXYx_CFKBhFjqfz_wyh6bPPbWpTPCDfGmmLGqiugvfqA3Dg@mail.gmail.com \ --to=erdemaktas@google.com \ --cc=aaronlewis@google.com \ --cc=axelrasmussen@google.com \ --cc=bgardon@google.com \ --cc=borntraeger@de.ibm.com \ --cc=dmatlack@google.com \ --cc=drjones@redhat.com \ --cc=eesposit@redhat.com \ --cc=eric.auger@redhat.com \ --cc=jmattson@google.com \ --cc=kvm@vger.kernel.org \ --cc=like.xu@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=maciej.szmigiero@oracle.com \ --cc=marcorr@google.com \ --cc=mlevitsk@redhat.com \ --cc=oupton@google.com \ --cc=pbonzini@redhat.com \ --cc=peterx@redhat.com \ --cc=pgonda@google.com \ --cc=pshier@google.com \ --cc=ricarkol@google.com \ --cc=sagis@google.com \ --cc=seanjc@google.com \ --cc=shuah@kernel.org \ --cc=vkuznets@redhat.com \ --cc=wangyanan55@huawei.com \ --cc=xiaoyao.li@intel.com \ --cc=zhenzhong.duan@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).