LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kai-Heng Feng <firstname.lastname@example.org>
To: "Ruinskiy, Dima" <email@example.com>
Cc: Sasha Neftin <firstname.lastname@example.org>,
Jesse Brandeburg <email@example.com>,
"Nguyen, Anthony L" <firstname.lastname@example.org>,
"open list:NETWORKING DRIVERS" <email@example.com>,
open list <firstname.lastname@example.org>,
AceLan Kao <email@example.com>,
Jakub Kicinski <firstname.lastname@example.org>,
"moderated list:INTEL ETHERNET DRIVERS"
"David S. Miller" <email@example.com>,
Subject: Re: [Intel-wired-lan] [PATCH 2/3] e1000e: Make mei_me active when e1000e is in use
Date: Wed, 14 Jul 2021 17:52:18 +0800 [thread overview]
Message-ID: <CAAd53p5Pyk80c0FjmqF9cjicNF8t0eTC7Y3BP-rWqW3O53K1Mg@mail.gmail.com> (raw)
On Wed, Jul 14, 2021 at 5:06 PM Ruinskiy, Dima <firstname.lastname@example.org> wrote:
> On 14/07/2021 9:28, Kai-Heng Feng wrote:
> >> I do not know how MEI driver affect 1Gbe driver - so, I would suggest to
> >> involve our CSME engineer (email@example.com) and try to
> >> investigate this problem.
> >> Does this problem observed on Dell systems? As I heard no reproduction
> >> on Intel's RVP platform.
> >> Another question: does disable mei_me runpm solve your problem?
> > Yes, disabling runpm on mei_me can workaround the issue, and that's
> > essentially what this patch does by adding DL_FLAG_PM_RUNTIME |
> > DL_FLAG_RPM_ACTIVE flag.
> > Kai-Heng
> Hi, Kai-Heng,
> If the goal of the patch is to essentially disable runpm on mei_me, then
> why is the patch touching code in the e1000e driver?
We can put the workaround in e1000e, mei_me or as PCI quirk.
But since the bug itself manifests in e1000e, I think it's more
appropriate to put it here.
To be more specific, it doesn't disable runtime suspend on mei_me, it
makes mei_me the power supplier of e1000e.
So when e1000e can be runtime suspended (i.e. no link partner), mei_me
can also get runtime suspended too.
> I agree with Sasha Neftin; it seems like the wrong location, and the
> wrong way to do it, even if it currently works. We need to understand
> what causes runpm of mei_me to adversely affect LAN Rx, and for this we
> need the involvement of mei_me owners.
I think it's the right location, however I totally agree with your
There are many users already affected by this bug, so if a proper fix
isn't available for now, the temporary workaround can help here.
> Intel Israel (74) Limited
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2021-07-14 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 13:34 [PATCH 1/3] e1000e: Separate TGP from SPT Kai-Heng Feng
2021-07-12 13:34 ` [PATCH 2/3] e1000e: Make mei_me active when e1000e is in use Kai-Heng Feng
2021-07-14 5:39 ` [Intel-wired-lan] " Sasha Neftin
2021-07-14 6:28 ` Kai-Heng Feng
2021-07-14 9:05 ` Ruinskiy, Dima
2021-07-14 9:52 ` Kai-Heng Feng [this message]
2021-07-18 8:37 ` Sasha Neftin
2021-07-12 13:34 ` [PATCH 3/3] e1000e: Serialize TGP e1000e PM ops Kai-Heng Feng
2021-07-27 6:53 ` Kai-Heng Feng
2021-08-01 4:15 ` Sasha Neftin
2021-07-13 17:58 ` [Intel-wired-lan] [PATCH 1/3] e1000e: Separate TGP from SPT Sasha Neftin
2021-07-14 4:19 ` Kai-Heng Feng
2021-07-14 8:43 ` Sasha Neftin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [Intel-wired-lan] [PATCH 2/3] e1000e: Make mei_me active when e1000e is in use' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).