LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Laura Abbott <lauraa@codeaurora.org>
Subject: Re: [PATCH v2 2/3] mm: cma: allocation trigger
Date: Wed, 28 Jan 2015 10:34:36 +0900	[thread overview]
Message-ID: <CAAmzW4N3QSWuzmL24f_-u=u+J0dx5kABxiZEqf_CHotRn_5E5w@mail.gmail.com> (raw)
In-Reply-To: <54C7A9F6.1080500@oracle.com>

2015-01-28 0:08 GMT+09:00 Sasha Levin <sasha.levin@oracle.com>:
> On 01/27/2015 03:06 AM, Joonsoo Kim wrote:
>> On Mon, Jan 26, 2015 at 09:26:04AM -0500, Sasha Levin wrote:
>>> Provides a userspace interface to trigger a CMA allocation.
>>>
>>> Usage:
>>>
>>>      echo [pages] > alloc
>>>
>>> This would provide testing/fuzzing access to the CMA allocation paths.
>>>
>>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>>> ---
>>>  mm/cma_debug.c |   60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>>>  1 file changed, 58 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
>>> index 3a25413..39c7116 100644
>>> --- a/mm/cma_debug.c
>>> +++ b/mm/cma_debug.c
>>> @@ -7,9 +7,22 @@
>>>
>>>  #include <linux/debugfs.h>
>>>  #include <linux/cma.h>
>>> +#include <linux/list.h>
>>> +#include <linux/kernel.h>
>>> +#include <linux/dma-contiguous.h>
>>
>> dma-contiguous.h doesn't needed now.
>
> Right.
>
>>> +#include <linux/slab.h>
>>>
>>>  #include "cma.h"
>>>
>>> +struct cma_mem {
>>> +    struct hlist_node node;
>>> +    struct page *p;
>>> +    unsigned long n;
>>> +};
>>> +
>>> +static HLIST_HEAD(cma_mem_head);
>>> +static DEFINE_SPINLOCK(cma_mem_head_lock);
>>> +
>>>  static struct dentry *cma_debugfs_root;
>>
>> How about keeping cma_mem_head on each cma area separately?
>
> Good point, we're mixing allocations here.
>
>>>  static int cma_debugfs_get(void *data, u64 *val)
>>> @@ -23,8 +36,48 @@ static int cma_debugfs_get(void *data, u64 *val)
>>>
>>>  DEFINE_SIMPLE_ATTRIBUTE(cma_debugfs_fops, cma_debugfs_get, NULL, "%llu\n");
>>>
>>> -static void cma_debugfs_add_one(struct cma *cma, int idx)
>>> +static void cma_add_to_cma_mem_list(struct cma_mem *mem)
>>> +{
>>> +    spin_lock(&cma_mem_head_lock);
>>> +    hlist_add_head(&mem->node, &cma_mem_head);
>>> +    spin_unlock(&cma_mem_head_lock);
>>> +}
>>> +
>>> +static int cma_alloc_mem(struct cma *cma, int count)
>>>  {
>>> +    struct cma_mem *mem;
>>> +    struct page *p;
>>> +
>>> +    mem = kzalloc(sizeof(*mem), GFP_KERNEL);
>>> +    if (!mem)
>>> +            return -ENOMEM;
>>> +
>>> +    p = cma_alloc(cma, count, CONFIG_CMA_ALIGNMENT);
>>> +    if (!p) {
>>> +            kfree(mem);
>>> +            return -ENOMEM;
>>> +    }
>>
>> CONFIG_CMA_ALIGNMENT looks not good. It means just maximum aligment
>> so it is odd to use this value in testing. Is there special meaning
>> to use it here?
>
> No good reason, I stole that from a different piece of code.
>
>> Could we also get alignment parameter from user? Something like below.
>>
>> echo "4 1" > alloc
>> 4 for number of pages
>> 1 for alignment.
>>
>> If it is impossible, just 0 looks better than CONFIG_CMA_ALIGNMENT.
>
> I'd rather keep it simple and use a single parameter for now.

Okay, then use 0 rather than CONFIG_CMA_ALIGNMENT.

Thanks.

  reply	other threads:[~2015-01-28  1:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 14:26 [PATCH v2 0/3] mm: cma: debugfs access to CMA Sasha Levin
2015-01-26 14:26 ` [PATCH v2 1/3] mm: cma: debugfs interface Sasha Levin
2015-01-26 14:26 ` [PATCH v2 2/3] mm: cma: allocation trigger Sasha Levin
2015-01-27  8:06   ` Joonsoo Kim
2015-01-27 15:08     ` Sasha Levin
2015-01-28  1:34       ` Joonsoo Kim [this message]
2015-01-26 14:26 ` [PATCH v2 3/3] mm: cma: release trigger Sasha Levin
2015-01-27  8:10   ` Joonsoo Kim
2015-01-27 18:25     ` Sasha Levin
2015-01-27 20:13       ` Sasha Levin
2015-01-28  1:35         ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAmzW4N3QSWuzmL24f_-u=u+J0dx5kABxiZEqf_CHotRn_5E5w@mail.gmail.com' \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=lauraa@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sasha.levin@oracle.com \
    --subject='Re: [PATCH v2 2/3] mm: cma: allocation trigger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).