LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB
@ 2021-08-06 13:02 Andy Shevchenko
  2021-08-06 13:31 ` Andy Shevchenko
  2021-08-06 15:04 ` Guenter Roeck
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-08-06 13:02 UTC (permalink / raw)
  To: Andy Shevchenko, linux-iio, linux-kernel
  Cc: Jonathan Cameron, Lars-Peter Clausen, Benson Leung,
	Enric Balletbo i Serra, Guenter Roeck, Jason M .

When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
can't be built-in.

Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
Reported-by: Jason M. <jason@montleon.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
index fefad9572790..b0d67ceaed55 100644
--- a/drivers/iio/common/cros_ec_sensors/Kconfig
+++ b/drivers/iio/common/cros_ec_sensors/Kconfig
@@ -4,7 +4,8 @@
 #
 config IIO_CROS_EC_SENSORS_CORE
 	tristate "ChromeOS EC Sensors Core"
-	depends on SYSFS && CROS_EC_SENSORHUB
+	depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
+	depends on SYSFS
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
 	help
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB
  2021-08-06 13:02 [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB Andy Shevchenko
@ 2021-08-06 13:31 ` Andy Shevchenko
  2021-08-06 15:04 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-08-06 13:31 UTC (permalink / raw)
  To: linux-iio, linux-kernel
  Cc: Jonathan Cameron, Lars-Peter Clausen, Benson Leung,
	Enric Balletbo i Serra, Guenter Roeck, Jason M .

On Fri, Aug 06, 2021 at 04:02:27PM +0300, Andy Shevchenko wrote:
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.

> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979

Looking again into .config actually puzzles me, there shouldn't be build
errors.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB
  2021-08-06 13:02 [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB Andy Shevchenko
  2021-08-06 13:31 ` Andy Shevchenko
@ 2021-08-06 15:04 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-08-06 15:04 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: linux-iio, linux-kernel, Jonathan Cameron, Lars-Peter Clausen,
	Benson Leung, Enric Balletbo i Serra, Guenter Roeck, Jason M .

Trying again, text only this time. Sorry for the trouble.

On Fri, Aug 6, 2021 at 6:08 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When CONFIG_CROS_EC_SENSORHUB is set to m, the IIO_CROS_EC_SENSORS_CORE
> can't be built-in.
>
> Fixes: 53067471188c ("iio / platform: cros_ec: Add cros-ec-sensorhub driver")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213979
> Reported-by: Jason M. <jason@montleon.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/iio/common/cros_ec_sensors/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/cros_ec_sensors/Kconfig b/drivers/iio/common/cros_ec_sensors/Kconfig
> index fefad9572790..b0d67ceaed55 100644
> --- a/drivers/iio/common/cros_ec_sensors/Kconfig
> +++ b/drivers/iio/common/cros_ec_sensors/Kconfig
> @@ -4,7 +4,8 @@
>  #
>  config IIO_CROS_EC_SENSORS_CORE
>         tristate "ChromeOS EC Sensors Core"
> -       depends on SYSFS && CROS_EC_SENSORHUB
> +       depends on CROS_EC_SENSORHUB=y || (CROS_EC_SENSORHUB=m && m)
> +       depends on SYSFS

This seems wrong.  IIO_CROS_EC_SENSORS_CORE should already be limited to m
if CROS_EC_SENSORHUB=m.

Note that I can not reproduce the problem in the bugzilla entry,
neither with mainline
nor with v5.13.6. And the configuration file published there looks fine and
already has IIO_CROS_EC_SENSORS_CORE=m.

Guenter

>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
>         help
> --
> 2.30.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-06 15:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 13:02 [PATCH v1 1/1] iio: cros_ec: Fix Kconfig dependency on CROS_EC_SENSORHUB Andy Shevchenko
2021-08-06 13:31 ` Andy Shevchenko
2021-08-06 15:04 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).