From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756548AbbA2NWm (ORCPT ); Thu, 29 Jan 2015 08:22:42 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:40252 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618AbbA2NWk (ORCPT ); Thu, 29 Jan 2015 08:22:40 -0500 MIME-Version: 1.0 In-Reply-To: References: <1422022202-7526-1-git-send-email-s.hauer@pengutronix.de> <20150126114735.GA3178@pengutronix.de> Date: Thu, 29 Jan 2015 14:22:38 +0100 Message-ID: Subject: Re: [PATCH v2] MediaTek PMIC support From: Matthias Brugger To: Sascha Hauer Cc: Olof Johansson , Arnd Bergmann , Samuel Ortiz , =?UTF-8?B?WUggQ2hlbiAo6Zmz5pix6LGqKQ==?= , "linux-kernel@vger.kernel.org" , Henry Chen , Rob Herring , =?UTF-8?B?WWluZ2pvZSBDaGVuICjpmbPoi7HmtLIp?= , Eddie Huang , Lee Jones , "linux-arm-kernel@lists.infradead.org" , James Liao , Mike Turquette , Stephen Boyd Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-01-29 13:39 GMT+01:00 Matthias Brugger : > Hi Sascha, > > 2015-01-26 12:47 GMT+01:00 Sascha Hauer : >> Olof, Arnd, >> >> OK to put the driver into drivers/soc/mediatek? Can you take these >> patches? > > How does this patches fit together with the one James clock framework patches? I forgot to send the link to the patches. Sorry for that. Here you are: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/313793.html > Both use the same compatible "mediatek,mt8135-infracfg" and > "mediatek,mt8135-pericfg". > > I had a look on other implementations and they attach the reset > controller to the clk driver, if they share the same hw block. > Might we run into problems if we implement the clocks in the mfd, as > we need the clocks early in boot (e.g. for the timer)? > > In mt6589 pericfg apart from the clocks and reset controller provides > registers for AXI bus control and USB wakeup and USB clock selection. > The infracfg block provides top AXI bus fabric control signals and > remap registers for the modem. > Mike, Stephen, what do you think. Can we implement the clk in a mfd > driver? Or do you prefer to implement the whole block in the clk > driver? > > Cheers, > Matthias > >> >> Sascha >> >> On Fri, Jan 23, 2015 at 03:09:55PM +0100, Sascha Hauer wrote: >>> This series adds initial support for the MediaTek MT6397 PMIC and the >>> necessary infrastructure to attach it on the MT8135 / MT8173 SoCs. >>> >>> The infrastructure includes: >>> >>> - pericfg / infracfg controller support >>> The pericfg / infracfg controllers contain miscellaneous registers for >>> reset controllers and clocks. >>> >>> - PMIC wrapper support >>> On MediaTek MT8135, MT8173 and other SoCs the PMIC is connected via >>> SPI. The SPI master interface is not directly visible to the CPU, but >>> only through the PMIC wrapper inside the SoC. The communication between >>> the SoC and the PMIC can optionally be encrypted. Also a non standard >>> Dual IO SPI mode can be used to increase speed. The MT8135 also supports >>> a special feature named "IP Pairing". With IP Pairing the pins of some >>> SoC internal peripherals can be on the PMIC. The signals of these pins >>> are routed over the SPI bus using the pwrap bridge. Because of these >>> optional non SPI conform features the PMIC driver is not implemented as >>> a SPI bus master driver. >>> >>> The MT6397 PMIC itself is implemented as a regular mfd device driver which >>> uses regmap to access the PMIC registers. >>> >>> This series also adds regulator support for the MT6397 PMIC. >>> >>> The first 6 patches can be merged through the ARM SoC tree. The mfd >>> patch is independent of the first 6 patches and can be merged through the >>> mfd maintainer trees. >>> >>> Changes since v1: >>> >>> - document reset bindings for infracfg/pericfg >>> - fix base addresses in infracfg binding example >>> - Remove more Email addresses from Flora Fu (She is not working at >>> MediaTek anymore, her address is no longer valid) >>> - drop Regulator support patch, it's already in next >>> >>> Sascha >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>> >> >> -- >> Pengutronix e.K. | | >> Industrial Linux Solutions | http://www.pengutronix.de/ | >> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > > -- > motzblog.wordpress.com -- motzblog.wordpress.com