LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs
@ 2015-03-15 22:00 Andreas Färber
  2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
                   ` (5 more replies)
  0 siblings, 6 replies; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

Hello,

This series adds a dedicated ODROID-XU device tree and enhances it with 
LED configuration, to match the downstream 3.14 based behavior.

Regards,
Andreas

v3 -> v4:
* Rebased pinctrl (.label field dropped, const'ified, __initconst)
* Edited dts subjects to match Kukjin's preferred style

v2 -> v3:
* Actually rebased pinctrl (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
* Added wake-up IRQ controller node (Tomasz Figa)

v1 -> v2:
* Inserted needed Sobs from Hakjoo Kim

Andreas Färber (3):
  ARM: dts: Clean up exynos5410-smdk5410 indentation
  ARM: dts: Prepare exynos5410-odroidxu device tree
  ARM: dts: Add LEDs to exynos5410-odroidxu

Hakjoo Kim (2):
  pinctrl: exynos: add exynos5410 SoC specific data
  ARM: dts: add pinctrl support to Exynos5410

 .../bindings/pinctrl/samsung-pinctrl.txt           |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/exynos5410-odroidxu.dts          | 103 ++++++
 arch/arm/boot/dts/exynos5410-pinctrl.dtsi          | 406 +++++++++++++++++++++
 arch/arm/boot/dts/exynos5410-smdk5410.dts          |   6 +-
 arch/arm/boot/dts/exynos5410.dtsi                  |  36 ++
 drivers/pinctrl/samsung/pinctrl-exynos.c           | 103 ++++++
 drivers/pinctrl/samsung/pinctrl-samsung.c          |   2 +
 drivers/pinctrl/samsung/pinctrl-samsung.h          |   1 +
 9 files changed, 656 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
 create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi

-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
@ 2015-03-15 22:00 ` Andreas Färber
  2015-03-16  7:24   ` Javier Martinez Canillas
  2015-06-02 12:58   ` Krzysztof Kozlowski
  2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
                   ` (4 subsequent siblings)
  5 siblings, 2 replies; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

The UART status properties are indented one level too deep, and we want
to derive a device tree for the ODROID-XU. Fix this before it propagates.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2 -> v3: Unchanged
 
 arch/arm/boot/dts/exynos5410-smdk5410.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts b/arch/arm/boot/dts/exynos5410-smdk5410.dts
index be3e02530b42..cebeaab3abec 100644
--- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
+++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
@@ -62,13 +62,13 @@
 };
 
 &uart0 {
-		status = "okay";
+	status = "okay";
 };
 
 &uart1 {
-		status = "okay";
+	status = "okay";
 };
 
 &uart2 {
-		status = "okay";
+	status = "okay";
 };
-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
  2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
@ 2015-03-15 22:00 ` Andreas Färber
  2015-03-16  7:56   ` Javier Martinez Canillas
  2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

Derived from exynos5410-smdk5410.dts.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2 -> v3: Unchanged
 
 arch/arm/boot/dts/Makefile                |  1 +
 arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++++++++++++++++++++++++++++++
 2 files changed, 79 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a1c776b8dcec..b040737edcbc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
 	exynos5250-snow.dtb \
 	exynos5250-spring.dtb \
 	exynos5260-xyref5260.dtb \
+	exynos5410-odroidxu.dtb \
 	exynos5410-smdk5410.dtb \
 	exynos5420-arndale-octa.dtb \
 	exynos5420-peach-pit.dtb \
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
new file mode 100644
index 000000000000..97310bb727e2
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -0,0 +1,78 @@
+/*
+ * Hardkernel ODROID-XU device tree source
+ *
+ * Copyright (c) 2014 SUSE LINUX Products GmbH
+ *
+ * Based on exynos5410-smdk5410.dts:
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ *		http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include "exynos5410.dtsi"
+/ {
+	model = "ODROID-XU based on EXYNOS5410";
+	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
+
+	memory {
+		reg = <0x40000000 0x80000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttySAC2,115200";
+	};
+
+	fin_pll: xxti {
+		compatible = "fixed-clock";
+		clock-frequency = <24000000>;
+		clock-output-names = "fin_pll";
+		#clock-cells = <0>;
+	};
+
+	firmware@02037000 {
+		compatible = "samsung,secure-firmware";
+		reg = <0x02037000 0x1000>;
+	};
+
+};
+
+&mmc_0 {
+	status = "okay";
+	num-slots = <1>;
+	cap-mmc-highspeed;
+	broken-cd;
+	card-detect-delay = <200>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <2 3>;
+	samsung,dw-mshc-ddr-timing = <1 2>;
+	bus-width = <8>;
+};
+
+&mmc_2 {
+	status = "okay";
+	num-slots = <1>;
+	cap-sd-highspeed;
+	card-detect-delay = <200>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <2 3>;
+	samsung,dw-mshc-ddr-timing = <1 2>;
+	bus-width = <4>;
+	disable-wp;
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
  2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
  2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
@ 2015-03-15 22:00 ` Andreas Färber
  2015-03-23 17:22   ` Tomasz Figa
  2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

From: Hakjoo Kim <ruppi.kim@hardkernel.com>

Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5410.

Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
[AF: Rebased onto Exynos5260, irq_chip consolidation, const'ification]
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2 -> v3:
 * Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
 
 v1 -> v2:
 * Filled in Sob from Hakjoo Kim
 
 .../bindings/pinctrl/samsung-pinctrl.txt           |   1 +
 drivers/pinctrl/samsung/pinctrl-exynos.c           | 103 +++++++++++++++++++++
 drivers/pinctrl/samsung/pinctrl-samsung.c          |   2 +
 drivers/pinctrl/samsung/pinctrl-samsung.h          |   1 +
 4 files changed, 107 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
index 9d2a995293e6..6db16b90873a 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
@@ -17,6 +17,7 @@ Required Properties:
   - "samsung,exynos4x12-pinctrl": for Exynos4x12 compatible pin-controller.
   - "samsung,exynos5250-pinctrl": for Exynos5250 compatible pin-controller.
   - "samsung,exynos5260-pinctrl": for Exynos5260 compatible pin-controller.
+  - "samsung,exynos5410-pinctrl": for Exynos5410 compatible pin-controller.
   - "samsung,exynos5420-pinctrl": for Exynos5420 compatible pin-controller.
   - "samsung,exynos7-pinctrl": for Exynos7 compatible pin-controller.
 
diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index c8f83f96546c..fa50fdd74d45 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -1150,6 +1150,109 @@ const struct samsung_pin_ctrl exynos5260_pin_ctrl[] __initconst = {
 	},
 };
 
+/* pin banks of exynos5410 pin-controller 0 */
+static const struct samsung_pin_bank_data exynos5410_pin_banks0[] __initconst = {
+	EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpa0", 0x00),
+	EXYNOS_PIN_BANK_EINTG(6, 0x020, "gpa1", 0x04),
+	EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpa2", 0x08),
+	EXYNOS_PIN_BANK_EINTG(5, 0x060, "gpb0", 0x0c),
+	EXYNOS_PIN_BANK_EINTG(5, 0x080, "gpb1", 0x10),
+	EXYNOS_PIN_BANK_EINTG(4, 0x0A0, "gpb2", 0x14),
+	EXYNOS_PIN_BANK_EINTG(4, 0x0C0, "gpb3", 0x18),
+	EXYNOS_PIN_BANK_EINTG(7, 0x0E0, "gpc0", 0x1c),
+	EXYNOS_PIN_BANK_EINTG(4, 0x100, "gpc3", 0x20),
+	EXYNOS_PIN_BANK_EINTG(7, 0x120, "gpc1", 0x24),
+	EXYNOS_PIN_BANK_EINTG(7, 0x140, "gpc2", 0x28),
+	EXYNOS_PIN_BANK_EINTN(2, 0x160, "gpm5"),
+	EXYNOS_PIN_BANK_EINTG(8, 0x180, "gpd1", 0x2c),
+	EXYNOS_PIN_BANK_EINTG(8, 0x1A0, "gpe0", 0x30),
+	EXYNOS_PIN_BANK_EINTG(2, 0x1C0, "gpe1", 0x34),
+	EXYNOS_PIN_BANK_EINTG(6, 0x1E0, "gpf0", 0x38),
+	EXYNOS_PIN_BANK_EINTG(8, 0x200, "gpf1", 0x3c),
+	EXYNOS_PIN_BANK_EINTG(8, 0x220, "gpg0", 0x40),
+	EXYNOS_PIN_BANK_EINTG(8, 0x240, "gpg1", 0x44),
+	EXYNOS_PIN_BANK_EINTG(2, 0x260, "gpg2", 0x48),
+	EXYNOS_PIN_BANK_EINTG(4, 0x280, "gph0", 0x4c),
+	EXYNOS_PIN_BANK_EINTG(8, 0x2A0, "gph1", 0x50),
+	EXYNOS_PIN_BANK_EINTN(8, 0x2C0, "gpm7"),
+	EXYNOS_PIN_BANK_EINTN(6, 0x2E0, "gpy0"),
+	EXYNOS_PIN_BANK_EINTN(4, 0x300, "gpy1"),
+	EXYNOS_PIN_BANK_EINTN(6, 0x320, "gpy2"),
+	EXYNOS_PIN_BANK_EINTN(8, 0x340, "gpy3"),
+	EXYNOS_PIN_BANK_EINTN(8, 0x360, "gpy4"),
+	EXYNOS_PIN_BANK_EINTN(8, 0x380, "gpy5"),
+	EXYNOS_PIN_BANK_EINTN(8, 0x3A0, "gpy6"),
+	EXYNOS_PIN_BANK_EINTN(8, 0x3C0, "gpy7"),
+	EXYNOS_PIN_BANK_EINTW(8, 0xC00, "gpx0", 0x00),
+	EXYNOS_PIN_BANK_EINTW(8, 0xC20, "gpx1", 0x04),
+	EXYNOS_PIN_BANK_EINTW(8, 0xC40, "gpx2", 0x08),
+	EXYNOS_PIN_BANK_EINTW(8, 0xC60, "gpx3", 0x0c),
+};
+
+/* pin banks of exynos5410 pin-controller 1 */
+static const struct samsung_pin_bank_data exynos5410_pin_banks1[] __initconst = {
+	EXYNOS_PIN_BANK_EINTG(5, 0x000, "gpj0", 0x00),
+	EXYNOS_PIN_BANK_EINTG(8, 0x020, "gpj1", 0x04),
+	EXYNOS_PIN_BANK_EINTG(8, 0x040, "gpj2", 0x08),
+	EXYNOS_PIN_BANK_EINTG(8, 0x060, "gpj3", 0x0c),
+	EXYNOS_PIN_BANK_EINTG(2, 0x080, "gpj4", 0x10),
+	EXYNOS_PIN_BANK_EINTG(8, 0x0A0, "gpk0", 0x14),
+	EXYNOS_PIN_BANK_EINTG(8, 0x0C0, "gpk1", 0x18),
+	EXYNOS_PIN_BANK_EINTG(8, 0x0E0, "gpk2", 0x1c),
+	EXYNOS_PIN_BANK_EINTG(7, 0x100, "gpk3", 0x20),
+};
+
+/* pin banks of exynos5410 pin-controller 2 */
+static const struct samsung_pin_bank_data exynos5410_pin_banks2[] __initconst = {
+	EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpv0", 0x00),
+	EXYNOS_PIN_BANK_EINTG(8, 0x020, "gpv1", 0x04),
+	EXYNOS_PIN_BANK_EINTG(8, 0x060, "gpv2", 0x08),
+	EXYNOS_PIN_BANK_EINTG(8, 0x080, "gpv3", 0x0c),
+	EXYNOS_PIN_BANK_EINTG(2, 0x0C0, "gpv4", 0x10),
+};
+
+/* pin banks of exynos5410 pin-controller 3 */
+static const struct samsung_pin_bank_data exynos5410_pin_banks3[] __initconst = {
+	EXYNOS_PIN_BANK_EINTG(7, 0x000, "gpz", 0x00),
+};
+
+/*
+ * Samsung pinctrl driver data for Exynos5410 SoC. Exynos5410 SoC includes
+ * four gpio/pin-mux/pinconfig controllers.
+ */
+const struct samsung_pin_ctrl exynos5410_pin_ctrl[] __initconst = {
+	{
+		/* pin-controller instance 0 data */
+		.pin_banks	= exynos5410_pin_banks0,
+		.nr_banks	= ARRAY_SIZE(exynos5410_pin_banks0),
+		.eint_gpio_init = exynos_eint_gpio_init,
+		.eint_wkup_init = exynos_eint_wkup_init,
+		.suspend	= exynos_pinctrl_suspend,
+		.resume		= exynos_pinctrl_resume,
+	}, {
+		/* pin-controller instance 1 data */
+		.pin_banks	= exynos5410_pin_banks1,
+		.nr_banks	= ARRAY_SIZE(exynos5410_pin_banks1),
+		.eint_gpio_init = exynos_eint_gpio_init,
+		.suspend	= exynos_pinctrl_suspend,
+		.resume		= exynos_pinctrl_resume,
+	}, {
+		/* pin-controller instance 2 data */
+		.pin_banks	= exynos5410_pin_banks2,
+		.nr_banks	= ARRAY_SIZE(exynos5410_pin_banks2),
+		.eint_gpio_init = exynos_eint_gpio_init,
+		.suspend	= exynos_pinctrl_suspend,
+		.resume		= exynos_pinctrl_resume,
+	}, {
+		/* pin-controller instance 3 data */
+		.pin_banks	= exynos5410_pin_banks3,
+		.nr_banks	= ARRAY_SIZE(exynos5410_pin_banks3),
+		.eint_gpio_init = exynos_eint_gpio_init,
+		.suspend	= exynos_pinctrl_suspend,
+		.resume		= exynos_pinctrl_resume,
+	},
+};
+
 /* pin banks of exynos5420 pin-controller 0 */
 static const struct samsung_pin_bank_data exynos5420_pin_banks0[] __initconst = {
 	EXYNOS_PIN_BANK_EINTG(8, 0x000, "gpy7", 0x00),
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index ec580af35856..1f45636b011d 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1237,6 +1237,8 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = {
 		.data = (void *)exynos5250_pin_ctrl },
 	{ .compatible = "samsung,exynos5260-pinctrl",
 		.data = (void *)exynos5260_pin_ctrl },
+	{ .compatible = "samsung,exynos5410-pinctrl",
+		.data = (void *)exynos5410_pin_ctrl },
 	{ .compatible = "samsung,exynos5420-pinctrl",
 		.data = (void *)exynos5420_pin_ctrl },
 	{ .compatible = "samsung,s5pv210-pinctrl",
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.h b/drivers/pinctrl/samsung/pinctrl-samsung.h
index 1b8c0139d604..b87e2f58ded7 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.h
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.h
@@ -270,6 +270,7 @@ extern const struct samsung_pin_ctrl exynos4x12_pin_ctrl[];
 extern const struct samsung_pin_ctrl exynos4415_pin_ctrl[];
 extern const struct samsung_pin_ctrl exynos5250_pin_ctrl[];
 extern const struct samsung_pin_ctrl exynos5260_pin_ctrl[];
+extern const struct samsung_pin_ctrl exynos5410_pin_ctrl[];
 extern const struct samsung_pin_ctrl exynos5420_pin_ctrl[];
 extern const struct samsung_pin_ctrl exynos7_pin_ctrl[];
 extern const struct samsung_pin_ctrl s3c64xx_pin_ctrl[];
-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
                   ` (2 preceding siblings ...)
  2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
@ 2015-03-15 22:00 ` Andreas Färber
  2015-06-02 12:59   ` Krzysztof Kozlowski
  2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
  2015-03-31 19:48 ` [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Ben Gamari
  5 siblings, 1 reply; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

From: Hakjoo Kim <ruppi.kim@hardkernel.com>

Add the required pin configuration support to Exynos5410 using pinctrl
interface.

Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
[AF: Rebased, style changes]
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2 -> v3:
 * Added wake-up IRQ controller node (Tomasz Figa)
 
 v1 -> v2:
 * Filled in Sob from Hakjoo Kim
 
 arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 ++++++++++++++++++++++++++++++
 arch/arm/boot/dts/exynos5410.dtsi         |  36 +++
 2 files changed, 442 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi

diff --git a/arch/arm/boot/dts/exynos5410-pinctrl.dtsi b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
new file mode 100644
index 000000000000..f9aa6bb55464
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5410-pinctrl.dtsi
@@ -0,0 +1,406 @@
+/*
+ * Exynos5410 SoC pin-mux and pin-config device tree source
+ *
+ * Copyright (c) 2013 Hardkernel Co., Ltd.
+ *              http://www.hardkernel.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+&pinctrl_0 {
+	gpa0: gpa0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpa1: gpa1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpa2: gpa2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpb0: gpb0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpb1: gpb1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpb2: gpb2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpb3: gpb3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpc0: gpc0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpc3: gpc3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpc1: gpc1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpc2: gpc2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpm5: gpm5 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpd1: gpd1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpe0: gpe0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpe1: gpe1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpf0: gpf0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpf1: gpf1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpg0: gpg0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpg1: gpg1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpg2: gpg2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gph0: gph0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gph1: gph1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpm7: gpm7 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy0: gpy0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy1: gpy1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy2: gpy2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy3: gpy3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy4: gpy4 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy5: gpy5 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy6: gpy6 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpy7: gpy7 {
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
+	gpx0: gpx0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		interrupt-parent = <&combiner>;
+		#interrupt-cells = <2>;
+		interrupts = <23 0>,
+		             <24 0>,
+		             <25 0>,
+		             <25 1>,
+		             <26 0>,
+		             <26 1>,
+		             <27 0>,
+		             <27 1>;
+	};
+
+	gpx1: gpx1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		interrupt-parent = <&combiner>;
+		#interrupt-cells = <2>;
+		interrupts = <28 0>,
+		             <28 1>,
+		             <29 0>,
+		             <29 1>,
+		             <30 0>,
+		             <30 1>,
+		             <31 0>,
+		             <31 1>;
+	};
+
+	gpx2: gpx2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpx3: gpx3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
+
+&pinctrl_1 {
+	gpj0: gpj0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpj1: gpj1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpj2: gpj2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpj3: gpj3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpj4: gpj4 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpk0: gpk0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpk1: gpk1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpk2: gpk2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpk3: gpk3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
+
+&pinctrl_2 {
+	gpv0: gpv0 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpv1: gpv1 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpv2: gpv2 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpv3: gpv3 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	gpv4: gpv4 {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
+
+&pinctrl_3 {
+	gpz: gpz {
+		gpio-controller;
+		#gpio-cells = <2>;
+
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
index 731eefd23fa9..460335606466 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi
@@ -21,6 +21,10 @@
 	interrupt-parent = <&gic>;
 
 	aliases {
+		pinctrl0 = &pinctrl_0;
+		pinctrl1 = &pinctrl_1;
+		pinctrl2 = &pinctrl_2;
+		pinctrl3 = &pinctrl_3;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;
@@ -218,4 +222,36 @@
 			status = "disabled";
 		};
 	};
+
+	pinctrl_0: pinctrl@13400000 {
+		compatible = "samsung,exynos5410-pinctrl";
+		reg = <0x13400000 0x1000>;
+		interrupts = <0 45 0>;
+
+		wakeup-interrupt-controller {
+			compatible = "samsung,exynos4210-wakeup-eint";
+			interrupt-parent = <&gic>;
+			interrupts = <0 32 0>;
+		};
+	};
+
+	pinctrl_1: pinctrl@14000000 {
+		compatible = "samsung,exynos5410-pinctrl";
+		reg = <0x14000000 0x1000>;
+		interrupts = <0 46 0>;
+	};
+
+	pinctrl_2: pinctrl@10d10000 {
+		compatible = "samsung,exynos5410-pinctrl";
+		reg = <0x10d10000 0x1000>;
+		interrupts = <0 50 0>;
+	};
+
+	pinctrl_3: pinctrl@03860000 {
+		compatible = "samsung,exynos5410-pinctrl";
+		reg = <0x03860000 0x1000>;
+		interrupts = <0 47 0>;
+	};
 };
+
+#include "exynos5410-pinctrl.dtsi"
-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
                   ` (3 preceding siblings ...)
  2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
@ 2015-03-15 22:00 ` Andreas Färber
  2015-03-16  8:02   ` Javier Martinez Canillas
  2015-06-02 13:02   ` Krzysztof Kozlowski
  2015-03-31 19:48 ` [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Ben Gamari
  5 siblings, 2 replies; 21+ messages in thread
From: Andreas Färber @ 2015-03-15 22:00 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel, Andreas Färber

Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2 -> v3: Unchanged
 
 v1 -> v2:
 * Filled in Sob from Hakjoo Kim
 
 arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 97310bb727e2..b02cd3ab7b38 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -15,6 +15,7 @@
 
 /dts-v1/;
 #include "exynos5410.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 / {
 	model = "ODROID-XU based on EXYNOS5410";
 	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
@@ -39,6 +40,30 @@
 		reg = <0x02037000 0x1000>;
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		blue {
+			label = "blue:heartbeat";
+			gpios = <&gpb2 2 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+			linux,default-trigger = "heartbeat";
+		};
+
+		green {
+			label = "green:activity";
+			gpios = <&gpb2 1 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+			linux,default-trigger = "mmc0";
+		};
+
+		red {
+			label = "red:activity";
+			gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+			linux,default-trigger = "mmc1";
+		};
+	};
 };
 
 &mmc_0 {
-- 
2.3.1


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation
  2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
@ 2015-03-16  7:24   ` Javier Martinez Canillas
  2015-06-02 12:58   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 21+ messages in thread
From: Javier Martinez Canillas @ 2015-03-16  7:24 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, Linux Kernel

Hello Andreas,

On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> The UART status properties are indented one level too deep, and we want
> to derive a device tree for the ODROID-XU. Fix this before it propagates.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
@ 2015-03-16  7:56   ` Javier Martinez Canillas
  2015-03-16 10:27     ` Andreas Färber
  0 siblings, 1 reply; 21+ messages in thread
From: Javier Martinez Canillas @ 2015-03-16  7:56 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, Linux Kernel

Hello Andreas,

On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> Derived from exynos5410-smdk5410.dts.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v1 -> v2 -> v3: Unchanged
>
>  arch/arm/boot/dts/Makefile                |  1 +
>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++++++++++++++++++++++++++++++
>  2 files changed, 79 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index a1c776b8dcec..b040737edcbc 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
>         exynos5250-snow.dtb \
>         exynos5250-spring.dtb \
>         exynos5260-xyref5260.dtb \
> +       exynos5410-odroidxu.dtb \
>         exynos5410-smdk5410.dtb \
>         exynos5420-arndale-octa.dtb \
>         exynos5420-peach-pit.dtb \
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> new file mode 100644
> index 000000000000..97310bb727e2
> --- /dev/null
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -0,0 +1,78 @@
> +/*
> + * Hardkernel ODROID-XU device tree source
> + *
> + * Copyright (c) 2014 SUSE LINUX Products GmbH
> + *
> + * Based on exynos5410-smdk5410.dts:
> + *
> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> + *             http://www.samsung.com
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +/dts-v1/;
> +#include "exynos5410.dtsi"
> +/ {
> +       model = "ODROID-XU based on EXYNOS5410";
> +       compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
> +
> +       memory {
> +               reg = <0x40000000 0x80000000>;
> +       };
> +
> +       chosen {
> +               bootargs = "console=ttySAC2,115200";
> +       };
> +

After commit a208ffd251d0 ("of: Enable console on serial ports
specified by /chosen/stdout-path") the kernel is able to know what
serial console to use if the DT defined an stdout-path property so
should be preferred instead of using a console= parameter.

I'll post today a series to change that on all exynos5 boards so you
can base on that.

> +       fin_pll: xxti {
> +               compatible = "fixed-clock";
> +               clock-frequency = <24000000>;
> +               clock-output-names = "fin_pll";
> +               #clock-cells = <0>;
> +       };
> +

I think this should be defined in exynos5410.dtsi instead since is an
IP block in the SoC and referenced in the .dts using a label to change
the clock-frequency in the board.

> +       firmware@02037000 {
> +               compatible = "samsung,secure-firmware";
> +               reg = <0x02037000 0x1000>;
> +       };
> +
> +};
> +
> +&mmc_0 {
> +       status = "okay";
> +       num-slots = <1>;
> +       cap-mmc-highspeed;
> +       broken-cd;
> +       card-detect-delay = <200>;
> +       samsung,dw-mshc-ciu-div = <3>;
> +       samsung,dw-mshc-sdr-timing = <2 3>;
> +       samsung,dw-mshc-ddr-timing = <1 2>;
> +       bus-width = <8>;
> +};
> +
> +&mmc_2 {
> +       status = "okay";
> +       num-slots = <1>;
> +       cap-sd-highspeed;
> +       card-detect-delay = <200>;
> +       samsung,dw-mshc-ciu-div = <3>;
> +       samsung,dw-mshc-sdr-timing = <2 3>;
> +       samsung,dw-mshc-ddr-timing = <1 2>;
> +       bus-width = <4>;
> +       disable-wp;
> +};
> +
> +&uart0 {
> +       status = "okay";
> +};
> +
> +&uart1 {
> +       status = "okay";
> +};
> +
> +&uart2 {
> +       status = "okay";
> +};
> --

With those two changes:

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
  2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
@ 2015-03-16  8:02   ` Javier Martinez Canillas
  2015-06-02 13:02   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 21+ messages in thread
From: Javier Martinez Canillas @ 2015-03-16  8:02 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, Linux Kernel

Hello Andreas,

On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote:
> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2 -> v3: Unchanged
>
>  v1 -> v2:
>  * Filled in Sob from Hakjoo Kim
>
>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> index 97310bb727e2..b02cd3ab7b38 100644
> --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
> @@ -15,6 +15,7 @@
>
>  /dts-v1/;
>  #include "exynos5410.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>  / {
>         model = "ODROID-XU based on EXYNOS5410";
>         compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
> @@ -39,6 +40,30 @@
>                 reg = <0x02037000 0x1000>;
>         };
>
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               blue {
> +                       label = "blue:heartbeat";
> +                       gpios = <&gpb2 2 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               green {
> +                       label = "green:activity";
> +                       gpios = <&gpb2 1 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "mmc0";
> +               };
> +
> +               red {
> +                       label = "red:activity";
> +                       gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>;
> +                       default-state = "off";
> +                       linux,default-trigger = "mmc1";
> +               };

I see that you are sorting alphabetically using the node name but for
example in pinctrl lines we were sorting using the GPIO bank and
offset so if we want to use the same policy here, this should be
green, blue and red.

Either way is good to me though so is up to you.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-16  7:56   ` Javier Martinez Canillas
@ 2015-03-16 10:27     ` Andreas Färber
  2015-03-16 10:58       ` Javier Martinez Canillas
  2015-06-02 12:43       ` Krzysztof Kozlowski
  0 siblings, 2 replies; 21+ messages in thread
From: Andreas Färber @ 2015-03-16 10:27 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, Linux Kernel

Hi Javier,

Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
> On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote:
>> Derived from exynos5410-smdk5410.dts.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v1 -> v2 -> v3: Unchanged

Forgot to update the in-patch changelogs: v4 is unchanged as well

>>
>>  arch/arm/boot/dts/Makefile                |  1 +
>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++++++++++++++++++++++++++++++
>>  2 files changed, 79 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index a1c776b8dcec..b040737edcbc 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
>>         exynos5250-snow.dtb \
>>         exynos5250-spring.dtb \
>>         exynos5260-xyref5260.dtb \
>> +       exynos5410-odroidxu.dtb \
>>         exynos5410-smdk5410.dtb \
>>         exynos5420-arndale-octa.dtb \
>>         exynos5420-peach-pit.dtb \
>> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
>> new file mode 100644
>> index 000000000000..97310bb727e2
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
>> @@ -0,0 +1,78 @@
>> +/*
>> + * Hardkernel ODROID-XU device tree source
>> + *
>> + * Copyright (c) 2014 SUSE LINUX Products GmbH
>> + *
>> + * Based on exynos5410-smdk5410.dts:
>> + *
>> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
>> + *             http://www.samsung.com
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> +*/
>> +
>> +/dts-v1/;
>> +#include "exynos5410.dtsi"
>> +/ {
>> +       model = "ODROID-XU based on EXYNOS5410";
>> +       compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
>> +
>> +       memory {
>> +               reg = <0x40000000 0x80000000>;
>> +       };
>> +
>> +       chosen {
>> +               bootargs = "console=ttySAC2,115200";
>> +       };
>> +
> 
> After commit a208ffd251d0 ("of: Enable console on serial ports
> specified by /chosen/stdout-path") the kernel is able to know what
> serial console to use if the DT defined an stdout-path property so
> should be preferred instead of using a console= parameter.
> 
> I'll post today a series to change that on all exynos5 boards so you
> can base on that.

Okay, if no one else does, I could update smdk5410 before splitting.

>> +       fin_pll: xxti {
>> +               compatible = "fixed-clock";
>> +               clock-frequency = <24000000>;
>> +               clock-output-names = "fin_pll";
>> +               #clock-cells = <0>;
>> +       };
>> +
> 
> I think this should be defined in exynos5410.dtsi instead since is an
> IP block in the SoC and referenced in the .dts using a label to change
> the clock-frequency in the board.

I hope you understood that this is a literal copy of smdk5410, so I'm
not going to make random changes here. If the Samsung guys want to make
this change for smdk5410, then fine, but otherwise - like for Snow and
Spring - I want to keep the diff -u low between the two.

>> +       firmware@02037000 {
>> +               compatible = "samsung,secure-firmware";
>> +               reg = <0x02037000 0x1000>;
>> +       };
>> +
>> +};
>> +
>> +&mmc_0 {
>> +       status = "okay";
>> +       num-slots = <1>;
>> +       cap-mmc-highspeed;
>> +       broken-cd;
>> +       card-detect-delay = <200>;
>> +       samsung,dw-mshc-ciu-div = <3>;
>> +       samsung,dw-mshc-sdr-timing = <2 3>;
>> +       samsung,dw-mshc-ddr-timing = <1 2>;
>> +       bus-width = <8>;
>> +};
>> +
>> +&mmc_2 {
>> +       status = "okay";
>> +       num-slots = <1>;
>> +       cap-sd-highspeed;
>> +       card-detect-delay = <200>;
>> +       samsung,dw-mshc-ciu-div = <3>;
>> +       samsung,dw-mshc-sdr-timing = <2 3>;
>> +       samsung,dw-mshc-ddr-timing = <1 2>;
>> +       bus-width = <4>;
>> +       disable-wp;
>> +};
>> +
>> +&uart0 {
>> +       status = "okay";
>> +};
>> +
>> +&uart1 {
>> +       status = "okay";
>> +};
>> +
>> +&uart2 {
>> +       status = "okay";
>> +};
>> --
> 
> With those two changes:
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Thanks, first review after posting for the third time... ;)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-16 10:27     ` Andreas Färber
@ 2015-03-16 10:58       ` Javier Martinez Canillas
  2015-03-17  2:10         ` Kukjin Kim
  2015-06-02 12:43       ` Krzysztof Kozlowski
  1 sibling, 1 reply; 21+ messages in thread
From: Javier Martinez Canillas @ 2015-03-16 10:58 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, Linux Kernel

Hello Andreas,

On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber <afaerber@suse.de> wrote:
> Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
>>
>> I think this should be defined in exynos5410.dtsi instead since is an
>> IP block in the SoC and referenced in the .dts using a label to change
>> the clock-frequency in the board.
>
> I hope you understood that this is a literal copy of smdk5410, so I'm
> not going to make random changes here. If the Samsung guys want to make
> this change for smdk5410, then fine, but otherwise - like for Snow and
> Spring - I want to keep the diff -u low between the two.
>

Yes I did understand that it was a copy but I thought it could be
improved anyways. But I don't have a strong opinion either to block
this series and always both DTS can be changed as a follow-up. So I'm
ok with your decision to keeping the delta to the minimum for now.

>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Thanks, first review after posting for the third time... ;)
>

You are welcome.

I usually try to review new Exynos5 DTS but I missed your series
before because I was not in the cc list. I only noticed now because
you talked about it on irc.

> Regards,
> Andreas
>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 21+ messages in thread

* RE: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-16 10:58       ` Javier Martinez Canillas
@ 2015-03-17  2:10         ` Kukjin Kim
  0 siblings, 0 replies; 21+ messages in thread
From: Kukjin Kim @ 2015-03-17  2:10 UTC (permalink / raw)
  To: 'Javier Martinez Canillas', 'Andreas Färber'
  Cc: linux-samsung-soc, 'Kukjin Kim',
	'김학주', 'Tomasz Figa',
	'Humberto Naves', 'Jan Kiszka',
	'Johann Pfefferl', 'Ben Gamari',
	linux-arm-kernel, 'Linux Kernel'

Javier Martinez Canillas wrote:
> 
> Hello Andreas,
> 
Hi,

> On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber <afaerber@suse.de> wrote:
> > Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
> >>
> >> I think this should be defined in exynos5410.dtsi instead since is an
> >> IP block in the SoC and referenced in the .dts using a label to change
> >> the clock-frequency in the board.
> >
> > I hope you understood that this is a literal copy of smdk5410, so I'm
> > not going to make random changes here. If the Samsung guys want to make
> > this change for smdk5410, then fine, but otherwise - like for Snow and
> > Spring - I want to keep the diff -u low between the two.
> >
> 
> Yes I did understand that it was a copy but I thought it could be
> improved anyways. But I don't have a strong opinion either to block
> this series and always both DTS can be changed as a follow-up. So I'm
> ok with your decision to keeping the delta to the minimum for now.
> 
Yeah, everybody can update everything in mainline if it can be got review in
mailinglist. BTW asthe fin_pll can be different according to board condition
that's why it is defined in each boart DT file, it is mostly same on each
boards though...So I think keeping it would be more make sense.

Thanks,
Kukjin


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data
  2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
@ 2015-03-23 17:22   ` Tomasz Figa
  2015-06-02 12:46     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 21+ messages in thread
From: Tomasz Figa @ 2015-03-23 17:22 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, 김학주,
	Humberto Naves, Jan Kiszka, Johann Pfefferl, Ben Gamari,
	linux-arm-kernel, linux-kernel

Hi Andreas, Hakjoo,

Thanks for the patch.

2015-03-16 7:00 GMT+09:00 Andreas Färber <afaerber@suse.de>:
> From: Hakjoo Kim <ruppi.kim@hardkernel.com>
>
> Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
> support for all platforms based on EXYNOS5410.
>
> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
> [AF: Rebased onto Exynos5260, irq_chip consolidation, const'ification]
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2 -> v3:
>  * Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
>
>  v1 -> v2:
>  * Filled in Sob from Hakjoo Kim
>
>  .../bindings/pinctrl/samsung-pinctrl.txt           |   1 +
>  drivers/pinctrl/samsung/pinctrl-exynos.c           | 103 +++++++++++++++++++++
>  drivers/pinctrl/samsung/pinctrl-samsung.c          |   2 +
>  drivers/pinctrl/samsung/pinctrl-samsung.h          |   1 +
>  4 files changed, 107 insertions(+)
>

Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs
  2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
                   ` (4 preceding siblings ...)
  2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
@ 2015-03-31 19:48 ` Ben Gamari
  5 siblings, 0 replies; 21+ messages in thread
From: Ben Gamari @ 2015-03-31 19:48 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	linux-arm-kernel, linux-kernel, Andreas Färber

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Andreas Färber <afaerber@suse.de> writes:

> Hello,
>
> This series adds a dedicated ODROID-XU device tree and enhances it with 
> LED configuration, to match the downstream 3.14 based behavior.
>
Any word on merging this?

Cheers,

- Ben

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
  2015-03-16 10:27     ` Andreas Färber
  2015-03-16 10:58       ` Javier Martinez Canillas
@ 2015-06-02 12:43       ` Krzysztof Kozlowski
  1 sibling, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 12:43 UTC (permalink / raw)
  To: Andreas Färber, Javier Martinez Canillas
  Cc: Humberto Naves, linux-samsung-soc, Jan Kiszka, Tomasz Figa,
	Linux Kernel, Kukjin Kim, 김학주,
	Johann Pfefferl, Ben Gamari, linux-arm-kernel

W dniu 16.03.2015 o 19:27, Andreas Färber pisze:
> Hi Javier,
> 
> Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
>> On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote:
>>> Derived from exynos5410-smdk5410.dts.
>>>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>>  v1 -> v2 -> v3: Unchanged
> 
> Forgot to update the in-patch changelogs: v4 is unchanged as well
> 
>>>
>>>  arch/arm/boot/dts/Makefile                |  1 +
>>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 78 +++++++++++++++++++++++++++++++
>>>  2 files changed, 79 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/exynos5410-odroidxu.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index a1c776b8dcec..b040737edcbc 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -103,6 +103,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
>>>         exynos5250-snow.dtb \
>>>         exynos5250-spring.dtb \
>>>         exynos5260-xyref5260.dtb \
>>> +       exynos5410-odroidxu.dtb \
>>>         exynos5410-smdk5410.dtb \
>>>         exynos5420-arndale-octa.dtb \
>>>         exynos5420-peach-pit.dtb \
>>> diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
>>> new file mode 100644
>>> index 000000000000..97310bb727e2
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
>>> @@ -0,0 +1,78 @@
>>> +/*
>>> + * Hardkernel ODROID-XU device tree source
>>> + *
>>> + * Copyright (c) 2014 SUSE LINUX Products GmbH
>>> + *
>>> + * Based on exynos5410-smdk5410.dts:
>>> + *
>>> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
>>> + *             http://www.samsung.com
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> +*/
>>> +
>>> +/dts-v1/;
>>> +#include "exynos5410.dtsi"
>>> +/ {
>>> +       model = "ODROID-XU based on EXYNOS5410";
>>> +       compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
>>> +
>>> +       memory {
>>> +               reg = <0x40000000 0x80000000>;
>>> +       };
>>> +
>>> +       chosen {
>>> +               bootargs = "console=ttySAC2,115200";
>>> +       };
>>> +
>>
>> After commit a208ffd251d0 ("of: Enable console on serial ports
>> specified by /chosen/stdout-path") the kernel is able to know what
>> serial console to use if the DT defined an stdout-path property so
>> should be preferred instead of using a console= parameter.
>>
>> I'll post today a series to change that on all exynos5 boards so you
>> can base on that.
> 
> Okay, if no one else does, I could update smdk5410 before splitting.

Could you do this? At least for new board if you cannot test it on SMDK5410.

> 
>>> +       fin_pll: xxti {
>>> +               compatible = "fixed-clock";
>>> +               clock-frequency = <24000000>;
>>> +               clock-output-names = "fin_pll";
>>> +               #clock-cells = <0>;
>>> +       };
>>> +
>>
>> I think this should be defined in exynos5410.dtsi instead since is an
>> IP block in the SoC and referenced in the .dts using a label to change
>> the clock-frequency in the board.
> 
> I hope you understood that this is a literal copy of smdk5410, so I'm
> not going to make random changes here. If the Samsung guys want to make
> this change for smdk5410, then fine, but otherwise - like for Snow and
> Spring - I want to keep the diff -u low between the two.

Moving the node to DTSI won't change the DTB for boards so the change is
safe. However to me it looks unusual that exynos5410.dtsi references
fin_pll phandle which is defined in the board.

However Kukjin mentioned that it is fine so it is okay with me also.

The rest looks fine, so:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data
  2015-03-23 17:22   ` Tomasz Figa
@ 2015-06-02 12:46     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 12:46 UTC (permalink / raw)
  To: Tomasz Figa, Andreas Färber
  Cc: Humberto Naves, linux-samsung-soc, Jan Kiszka, linux-kernel,
	Kukjin Kim, 김학주,
	Johann Pfefferl, Ben Gamari, linux-arm-kernel

W dniu 24.03.2015 o 02:22, Tomasz Figa pisze:
> Hi Andreas, Hakjoo,
> 
> Thanks for the patch.
> 
> 2015-03-16 7:00 GMT+09:00 Andreas Färber <afaerber@suse.de>:
>> From: Hakjoo Kim <ruppi.kim@hardkernel.com>
>>
>> Add Samsung EXYNOS5410 SoC specific data to enable pinctrl
>> support for all platforms based on EXYNOS5410.
>>
>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
>> [AF: Rebased onto Exynos5260, irq_chip consolidation, const'ification]
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v2 -> v3:
>>  * Rebased (.svc, .{g,w}eint_{con,mask,pend} fields dropped)
>>
>>  v1 -> v2:
>>  * Filled in Sob from Hakjoo Kim
>>
>>  .../bindings/pinctrl/samsung-pinctrl.txt           |   1 +
>>  drivers/pinctrl/samsung/pinctrl-exynos.c           | 103 +++++++++++++++++++++
>>  drivers/pinctrl/samsung/pinctrl-samsung.c          |   2 +
>>  drivers/pinctrl/samsung/pinctrl-samsung.h          |   1 +
>>  4 files changed, 107 insertions(+)
>>
> 
> Acked-by: Tomasz Figa <tomasz.figa@gmail.com>

So I assume this may go through Kukjin tree.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation
  2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
  2015-03-16  7:24   ` Javier Martinez Canillas
@ 2015-06-02 12:58   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 12:58 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc
  Cc: Humberto Naves, Jan Kiszka, Tomasz Figa, linux-kernel,
	Kukjin Kim, 김학주,
	Johann Pfefferl, Ben Gamari, linux-arm-kernel

W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
> The UART status properties are indented one level too deep, and we want
> to derive a device tree for the ODROID-XU. Fix this before it propagates.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Applied to my tree. If Kukjin won't grab it from here, I'll push it
later to Kukjin depending on other pull requests.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410
  2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
@ 2015-06-02 12:59   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 12:59 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel

W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
> From: Hakjoo Kim <ruppi.kim@hardkernel.com>
> 
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.
> 
> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
> [AF: Rebased, style changes]
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2 -> v3:
>  * Added wake-up IRQ controller node (Tomasz Figa)
>  
>  v1 -> v2:
>  * Filled in Sob from Hakjoo Kim
>  
>  arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 ++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/exynos5410.dtsi         |  36 +++
>  2 files changed, 442 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi

Changes look fine:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
  2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
  2015-03-16  8:02   ` Javier Martinez Canillas
@ 2015-06-02 13:02   ` Krzysztof Kozlowski
  2015-06-02 13:38     ` Andreas Färber
  1 sibling, 1 reply; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 13:02 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel

W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2 -> v3: Unchanged
>  
>  v1 -> v2:
>  * Filled in Sob from Hakjoo Kim
>  
>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

What is the rationale behind doing this in separate patch, not as part
of 2/5? You can just add new board DTS with all of its features at once,
but maybe I am missing something?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
  2015-06-02 13:02   ` Krzysztof Kozlowski
@ 2015-06-02 13:38     ` Andreas Färber
  2015-06-02 23:55       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 21+ messages in thread
From: Andreas Färber @ 2015-06-02 13:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski, linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel

Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski:
> W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v2 -> v3: Unchanged
>>  
>>  v1 -> v2:
>>  * Filled in Sob from Hakjoo Kim
>>  
>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
> 
> What is the rationale behind doing this in separate patch, not as part
> of 2/5? You can just add new board DTS with all of its features at once,
> but maybe I am missing something?

This patch depends on the pinctrl driver, 2/5 on nothing.

By keeping it a separate patch it was intended to go in more quickly
(clear fail there ;)) and it's easier to review the actual changes -
squashing is always easier than picking apart.

Thanks for your review! Both me and Ben have follow-ups once this moves
forward.

Kind regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
  2015-06-02 13:38     ` Andreas Färber
@ 2015-06-02 23:55       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 21+ messages in thread
From: Krzysztof Kozlowski @ 2015-06-02 23:55 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc
  Cc: Kukjin Kim, 김학주,
	Tomasz Figa, Humberto Naves, Jan Kiszka, Johann Pfefferl,
	Ben Gamari, linux-arm-kernel, linux-kernel

On 02.06.2015 22:38, Andreas Färber wrote:
> Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski:
>> W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
>>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>>  v2 -> v3: Unchanged
>>>  
>>>  v1 -> v2:
>>>  * Filled in Sob from Hakjoo Kim
>>>  
>>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>>>  1 file changed, 25 insertions(+)
>>
>> What is the rationale behind doing this in separate patch, not as part
>> of 2/5? You can just add new board DTS with all of its features at once,
>> but maybe I am missing something?
> 
> This patch depends on the pinctrl driver, 2/5 on nothing.
> 
> By keeping it a separate patch it was intended to go in more quickly
> (clear fail there ;)) and it's easier to review the actual changes -
> squashing is always easier than picking apart.

OK, I'm fine with it.

The patch looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Can you resend everything with the change in chosen/console?

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2015-06-02 23:56 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
2015-03-16  7:24   ` Javier Martinez Canillas
2015-06-02 12:58   ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
2015-03-16  7:56   ` Javier Martinez Canillas
2015-03-16 10:27     ` Andreas Färber
2015-03-16 10:58       ` Javier Martinez Canillas
2015-03-17  2:10         ` Kukjin Kim
2015-06-02 12:43       ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
2015-03-23 17:22   ` Tomasz Figa
2015-06-02 12:46     ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
2015-06-02 12:59   ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
2015-03-16  8:02   ` Javier Martinez Canillas
2015-06-02 13:02   ` Krzysztof Kozlowski
2015-06-02 13:38     ` Andreas Färber
2015-06-02 23:55       ` Krzysztof Kozlowski
2015-03-31 19:48 ` [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Ben Gamari

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).