LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daeho Jeong <daeho43@gmail.com>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
	Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option
Date: Fri, 3 Sep 2021 13:33:11 -0700	[thread overview]
Message-ID: <CACOAw_yovM592K3-2fQzA6M29XqWu8s_2f+zXawKo-QpNSXq0w@mail.gmail.com> (raw)
In-Reply-To: <9ab17089-accc-c3a3-a5dc-007fc4eeaa20@kernel.org>

>         if (f2fs_need_seq_seg(sbi))
>                 return 0;
>
> static inline bool f2fs_need_seq_seg(struct f2fs_sb_info *sbi)
> {
>         return F2FS_OPTION(sbi).fs_mode == FS_MODE_FRAGMENT_FIXED_BLK;
> }
>

Do you need this in select_policy(), either?
Like,
        if (f2fs_need_rand_seg(sbi))
                p->offset = prandom_u32() % (MAIN_SECS(sbi) *
sbi->segs_per_sec);
        else if (f2fs_need_seq_seg(sbi))
                p->offset = 0;

> One more concern... we'd better to save fragment_remained_hole as well
> as fragment_remained_chunk,  otherwise, if fragment_chunk_size +
> fragment_hole_size > 512, fragment hole will be truncated to 512 -
> fragment_chunk_size due to we won't create hole with enough size as
> seg->next_blkoff has crossed end of current segment.
>

Sorry, I don't get it. You mean making fragment_remained_hole as a
global variable?
Maybe, we run into the same race condition issue you told before for
fragment_remained_chunk.
Could you clarify this more?

Thanks,

  reply	other threads:[~2021-09-03 20:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 17:24 Daeho Jeong
2021-09-02 23:57 ` [f2fs-dev] " Chao Yu
2021-09-03 20:33   ` Daeho Jeong [this message]
2021-09-04  3:33     ` Chao Yu
2021-09-04  4:40       ` Daeho Jeong
2021-09-04  6:45         ` Chao Yu
2021-09-07 18:12           ` Daeho Jeong
2021-09-09 23:50             ` Chao Yu
2021-09-10 14:34               ` Daeho Jeong
2021-09-10 15:24                 ` Daeho Jeong
2021-09-11 10:42                   ` Chao Yu
2021-09-10 23:13 ` Jaegeuk Kim
2021-09-11 23:45   ` [f2fs-dev] " Chao Yu
2021-09-20 22:57     ` Jaegeuk Kim
2021-09-22 15:23       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACOAw_yovM592K3-2fQzA6M29XqWu8s_2f+zXawKo-QpNSXq0w@mail.gmail.com \
    --to=daeho43@gmail.com \
    --cc=chao@kernel.org \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [f2fs-dev] [PATCH v4] f2fs: introduce fragment allocation mode mount option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).