LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Rob Herring <robh@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Karol Gugala <kgugala@antmicro.com>,
	Mateusz Holenko <mholenko@antmicro.com>,
	devicetree <devicetree@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH
Date: Wed, 25 Aug 2021 03:00:28 +0000	[thread overview]
Message-ID: <CACPK8Xey50=7CGb--Myue-KzFLqGKWRMiW5j0z+fp4PLnYBUqA@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+q6o88_6910brD4wEWBTi068jGDmaD8pucEFrT5FcWMw@mail.gmail.com>

On Tue, 24 Aug 2021 at 11:52, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Aug 23, 2021 at 10:52 PM Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Mon, 23 Aug 2021 at 18:44, Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Fri, Aug 20, 2021 at 05:17:25PM +0930, Joel Stanley wrote:
> >
> > > > +
> > > > +  interrupts:
> > > > +    maxItems: 1
> > > > +
> > >
> > > > +  rx-fifo-depth: true
> > > > +  tx-fifo-depth: true
> > >
> > > Needs a vendor prefix, type, description and constraints.
> >
> > These are the standard properties from the ethernet-controller.yaml. I
> > switched the driver to using those once I discovered they existed (v1
> > defined these in terms of slots, whereas the ethernet-controller
> > bindings use bytes).
>
> Indeed (grepping the wrong repo didn't work too well :) ).
>
> Still, I'd assume there's some valid range for this h/w you can
> define? Or 0 - 2^32 is valid?

0 would be problematic, but there's not really any bound on it.

I'll send a v3 with the reg-names documented. Thanks for the review.

Cheers,

Joel

  reply	other threads:[~2021-08-25  3:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  7:47 [PATCH v2 0/2] net: Add LiteETH network driver Joel Stanley
2021-08-20  7:47 ` [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH Joel Stanley
2021-08-20 17:41   ` Andrew Lunn
2021-08-23 18:44   ` Rob Herring
2021-08-24  3:51     ` Joel Stanley
2021-08-24 11:52       ` Rob Herring
2021-08-25  3:00         ` Joel Stanley [this message]
2021-08-20  7:47 ` [PATCH v2 2/2] net: Add driver for LiteX's LiteEth network interface Joel Stanley
2021-08-20 11:50   ` kernel test robot
2021-08-24 19:43   ` Gabriel L. Somlo
2021-08-25  6:35     ` Joel Stanley
2021-08-25  6:41       ` Joel Stanley
2021-08-25 12:00       ` Gabriel L. Somlo
2021-08-27  2:11       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8Xey50=7CGb--Myue-KzFLqGKWRMiW5j0z+fp4PLnYBUqA@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kgugala@antmicro.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mholenko@antmicro.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for LiteETH' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).