LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: NET_VENDOR_LITEX should depend on LITEX
@ 2021-08-31 13:20 Geert Uytterhoeven
  2021-08-31 13:36 ` Joel Stanley
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-08-31 13:20 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski, Joel Stanley, Gabriel Somlo,
	David Shah, Stafford Horne
  Cc: Karol Gugala, Mateusz Holenko, netdev, linux-kernel, Geert Uytterhoeven

LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
dependency on LITEX, to prevent asking the user about drivers for these
devices when configuring a kernel without LiteX SoC Builder support.

Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/litex/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
index 265dba414b41ec22..bfad1df1368866d3 100644
--- a/drivers/net/ethernet/litex/Kconfig
+++ b/drivers/net/ethernet/litex/Kconfig
@@ -5,6 +5,7 @@
 config NET_VENDOR_LITEX
 	bool "LiteX devices"
 	default y
+	depends on LITEX || COMPILE_TEST
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX
  2021-08-31 13:20 [PATCH] net: NET_VENDOR_LITEX should depend on LITEX Geert Uytterhoeven
@ 2021-08-31 13:36 ` Joel Stanley
  2021-08-31 15:52   ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2021-08-31 13:36 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David S . Miller, Jakub Kicinski, Gabriel Somlo, David Shah,
	Stafford Horne, Karol Gugala, Mateusz Holenko, Networking,
	Linux Kernel Mailing List

On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> dependency on LITEX, to prevent asking the user about drivers for these
> devices when configuring a kernel without LiteX SoC Builder support.

nak.

They can be present on any soc that uses them. We have an example in
mainline already; microwatt uses liteeth but is not a litex soc.

Cheers,

Joel

>
> Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/net/ethernet/litex/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> index 265dba414b41ec22..bfad1df1368866d3 100644
> --- a/drivers/net/ethernet/litex/Kconfig
> +++ b/drivers/net/ethernet/litex/Kconfig
> @@ -5,6 +5,7 @@
>  config NET_VENDOR_LITEX
>         bool "LiteX devices"
>         default y
> +       depends on LITEX || COMPILE_TEST
>         help
>           If you have a network (Ethernet) card belonging to this class, say Y.
>
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: NET_VENDOR_LITEX should depend on LITEX
  2021-08-31 13:36 ` Joel Stanley
@ 2021-08-31 15:52   ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-08-31 15:52 UTC (permalink / raw)
  To: Joel Stanley
  Cc: David S . Miller, Jakub Kicinski, Gabriel Somlo, David Shah,
	Stafford Horne, Karol Gugala, Mateusz Holenko, Networking,
	Linux Kernel Mailing List

Hi Joel,

On Tue, Aug 31, 2021 at 3:37 PM Joel Stanley <joel@jms.id.au> wrote:
> On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > LiteX Ethernet devices are only present on LiteX SoCs.  Hence add a
> > dependency on LITEX, to prevent asking the user about drivers for these
> > devices when configuring a kernel without LiteX SoC Builder support.
>
> nak.
>
> They can be present on any soc that uses them. We have an example in
> mainline already; microwatt uses liteeth but is not a litex soc.

But liiteeth.c uses <linux/litex.h>?
And https://github.com/enjoy-digital/litex can be used with a microwatt
CPU core?

The idea behind the LITEX config symbol was to gate off any driver
using LiteX interfaces.

> > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- a/drivers/net/ethernet/litex/Kconfig
> > +++ b/drivers/net/ethernet/litex/Kconfig
> > @@ -5,6 +5,7 @@
> >  config NET_VENDOR_LITEX
> >         bool "LiteX devices"
> >         default y
> > +       depends on LITEX || COMPILE_TEST
> >         help
> >           If you have a network (Ethernet) card belonging to this class, say Y.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-31 15:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-31 13:20 [PATCH] net: NET_VENDOR_LITEX should depend on LITEX Geert Uytterhoeven
2021-08-31 13:36 ` Joel Stanley
2021-08-31 15:52   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).