LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Linus Walleij <email@example.com> To: Michal Simek <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, Michal Simek <email@example.com>, Steffen Trumtrar <firstname.lastname@example.org>, Peter Crosthwaite <email@example.com>, "open list:GPIO SUBSYSTEM" <firstname.lastname@example.org>, Rob Herring <email@example.com>, Linux ARM <firstname.lastname@example.org> Subject: Re: [PATCH] gpio: zynq: Setup chip->base based on alias ID Date: Wed, 2 May 2018 15:01:24 +0200 [thread overview] Message-ID: <CACRpkdYgw+HaC5bUCZKiD7j+2ZLYbCTG+DdPdAEkRDq0xF5b3w@mail.gmail.com> (raw) In-Reply-To: <email@example.com> On Wed, May 2, 2018 at 12:15 PM, Michal Simek <firstname.lastname@example.org> wrote: > On 2.5.2018 12:10, Linus Walleij wrote: >> On Thu, Apr 26, 2018 at 3:35 PM, Michal Simek <email@example.com> wrote: >>> Yes, it is about legacy application which I have seen recently and there >>> is no source code for application calls it because board vendor doesn't >>> provide it. >>> >>> You are right that -1 was used from the beginning in mainline but >>> unfortunately this driver was in vendor tree for a while and it uses 0 >>> there. >>> >>> In upstreaming this was changed to -1 but customers have a lot of code >>> which developed against vendor tree and they want to use >>> latest&greatest. And without this they are not able to run that >>> applications. >>> >>> I found that this logic is already in 5 drivers in mainline that's why I >>> send this patch to be +1. >> >> I see. >> >> Sadly comaptibility with out-of-tree driver code is none of our >> (community) business. >> >> We do pay a lot of effort not to break the ABI to userspace, but >> it needs to be an ABI coming from the mainline kernel, not from >> a vendor tree. >> >> So to the mainline kernel this is no regression. > > I understand your statement. On the other hand it is feature which was > permitted in past for some drivers and this is +1. But was it permitted because of breaking out of tree code? I know people have done questionable things in the past, but two wrongs does not make one right. Yours, Linus Walleij
next prev parent reply other threads:[~2018-05-02 13:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-11 13:55 [PATCH] gpio: zynq: Setup chip->base based on alias ID Michal Simek 2018-04-26 13:08 ` Linus Walleij 2018-04-26 13:35 ` Michal Simek 2018-05-02 10:10 ` Linus Walleij 2018-05-02 10:15 ` Michal Simek 2018-05-02 13:01 ` Linus Walleij [this message] 2018-05-02 13:41 ` Michal Simek 2018-05-02 13:56 ` Linus Walleij 2018-05-02 14:19 ` Michal Simek 2018-05-15 13:26 ` Michal Simek 2018-05-23 9:44 ` Linus Walleij 2018-05-23 10:26 ` Michal Simek 2018-05-23 9:42 ` Linus Walleij 2018-05-23 10:17 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACRpkdYgw+HaC5bUCZKiD7j+2ZLYbCTG+DdPdAEkRDq0xF5b3w@mail.gmail.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).