LKML Archive on
help / color / mirror / Atom feed
From: Linus Walleij <>
To: Phil Edworthy <>
Cc: Andy Shevchenko <>,
	Hoan Tran <>, Mark Rutland <>,
	Rob Herring <>,
	Lee Jones <>,
	Michel Pollet <>,
	"open list:GPIO SUBSYSTEM" <>,
	Linux-Renesas <>,
	"" <>
Subject: Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO
Date: Wed, 23 May 2018 10:29:20 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, May 11, 2018 at 10:31 AM, Phil Edworthy
<> wrote:

> The DesignWare GPIO IP can be configured for either 1 interrupt or 1
> per GPIO in port A, but the driver currently only supports 1 interrupt.
> See the DesignWare DW_apb_gpio Databook description of the
> 'GPIO_INTR_IO' parameter.
> This change allows the driver to work with up to 32 interrupts, it will
> get as many interrupts as specified in the DT 'interrupts' property.
> It doesn't do anything clever with the different interrupts, it just calls
> the same handler used for single interrupt hardware.
> Signed-off-by: Phil Edworthy <>
> Reviewed-by: Rob Herring <>
> Acked-by: Lee Jones <>
> ---
> One point to mention is that I have made it possible for users to have
> unconnected interrupts by specifying holes in the list of interrupts. This is
> done by supporting the interrupts-extended DT prop.
> However, I have no use for this and had to hack some test case for this.
> Perhaps the driver should support 1 interrupt or all GPIOa as interrupts?
> v6:
>  - Treat DT and ACPI the same as much as possible. Note that we can't use
>    platform_get_irq() to get the DT interrupts as they are in the port
>    sub-node and hence do not have an associated platform device.

I already applied this patch in some version, can you check what is
in my devel branch and send incremental patches on top if
something needs changing?

Sorry for not knowing by heart what was applied or when, it's
just too much for me sometimes.

Linus Walleij

  parent reply	other threads:[~2018-05-23  8:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  8:31 Phil Edworthy
2018-05-15  7:42 ` Simon Horman
2018-05-16 21:40 ` Hoan Tran
2018-05-17  6:25   ` Lee Jones
2018-05-17 16:46     ` Hoan Tran
2018-05-23  8:29 ` Linus Walleij [this message]
2018-05-23  8:45   ` Phil Edworthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).