LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero'
@ 2019-05-13  7:34 Lee Jones
  2019-05-13  7:34 ` [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here' Lee Jones
  2019-05-13  8:16 ` [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: Lee Jones @ 2019-05-13  7:34 UTC (permalink / raw)
  To: linus.walleij; +Cc: linux-arm-kernel, linux-kernel, amelie.delaunay, Lee Jones

smatch warnings:
drivers/pinctrl/pinctrl-stmfx.c:225 stmfx_pinconf_get() warn: unsigned 'dir' is never less than zero.
drivers/pinctrl/pinctrl-stmfx.c:228 stmfx_pinconf_get() warn: unsigned 'type' is never less than zero.
drivers/pinctrl/pinctrl-stmfx.c:231 stmfx_pinconf_get() warn: unsigned 'pupd' is never less than zero.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/pinctrl/pinctrl-stmfx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index bcd81269445e..074c8fa3e75c 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -213,9 +213,8 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev,
 	struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
 	u32 param = pinconf_to_config_param(*config);
 	struct pinctrl_gpio_range *range;
-	u32 dir, type, pupd;
 	u32 arg = 0;
-	int ret;
+	int ret, dir, type, pupd;
 
 	range = pinctrl_find_gpio_range_from_pin_nolock(pctldev, pin);
 	if (!range)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here'
  2019-05-13  7:34 [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Lee Jones
@ 2019-05-13  7:34 ` Lee Jones
  2019-05-13  8:18   ` Linus Walleij
  2019-05-13  8:16 ` [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Linus Walleij
  1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2019-05-13  7:34 UTC (permalink / raw)
  To: linus.walleij; +Cc: linux-arm-kernel, linux-kernel, amelie.delaunay, Lee Jones

drivers/pinctrl/pinctrl-stmfx.c:441 stmfx_pinctrl_irq_set_type() warn: bitwise AND condition is false here

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/pinctrl/pinctrl-stmfx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index 074c8fa3e75c..eba872ce4a7c 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -437,7 +437,7 @@ static int stmfx_pinctrl_irq_set_type(struct irq_data *data, unsigned int type)
 	u32 reg = get_reg(data->hwirq);
 	u32 mask = get_mask(data->hwirq);
 
-	if (type & IRQ_TYPE_NONE)
+	if (type == IRQ_TYPE_NONE)
 		return -EINVAL;
 
 	if (type & IRQ_TYPE_EDGE_BOTH) {
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero'
  2019-05-13  7:34 [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Lee Jones
  2019-05-13  7:34 ` [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here' Lee Jones
@ 2019-05-13  8:16 ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-05-13  8:16 UTC (permalink / raw)
  To: Lee Jones; +Cc: Linux ARM, linux-kernel, Amelie Delaunay

On Mon, May 13, 2019 at 9:34 AM Lee Jones <lee.jones@linaro.org> wrote:

> smatch warnings:
> drivers/pinctrl/pinctrl-stmfx.c:225 stmfx_pinconf_get() warn: unsigned 'dir' is never less than zero.
> drivers/pinctrl/pinctrl-stmfx.c:228 stmfx_pinconf_get() warn: unsigned 'type' is never less than zero.
> drivers/pinctrl/pinctrl-stmfx.c:231 stmfx_pinconf_get() warn: unsigned 'pupd' is never less than zero.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here'
  2019-05-13  7:34 ` [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here' Lee Jones
@ 2019-05-13  8:18   ` Linus Walleij
  0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-05-13  8:18 UTC (permalink / raw)
  To: Lee Jones; +Cc: Linux ARM, linux-kernel, Amelie Delaunay

On Mon, May 13, 2019 at 9:34 AM Lee Jones <lee.jones@linaro.org> wrote:

> drivers/pinctrl/pinctrl-stmfx.c:441 stmfx_pinctrl_irq_set_type() warn: bitwise AND condition is false here
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-05-13  8:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13  7:34 [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Lee Jones
2019-05-13  7:34 ` [PATCH 2/2] pinctrl: stmfx: Fix 'warn: bitwise AND condition is false here' Lee Jones
2019-05-13  8:18   ` Linus Walleij
2019-05-13  8:16 ` [PATCH 1/2] pinctrl: stmfx: Fix 'warn: unsigned <VAR> is never less than zero' Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).