LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Krzysztof Halasa <khalasa@piap.pl>, Arnd Bergmann <arnd@arndb.de>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: ixp4xx: fix printing resources
Date: Wed, 4 Aug 2021 01:37:42 +0200	[thread overview]
Message-ID: <CACRpkdZOzCPKMiCaB3McYAmXZ1oC=L6jKER9a7g2oM6EHE55Fg@mail.gmail.com> (raw)
In-Reply-To: <20210803082034.2085618-1-arnd@kernel.org>

On Tue, Aug 3, 2021 at 10:20 AM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> When compile-testing with 64-bit resource_size_t, gcc reports an invalid
> printk format string:
>
> In file included from include/linux/dma-mapping.h:7,
>                  from drivers/soc/ixp4xx/ixp4xx-npe.c:15:
> drivers/soc/ixp4xx/ixp4xx-npe.c: In function 'ixp4xx_npe_probe':
> drivers/soc/ixp4xx/ixp4xx-npe.c:694:18: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
>     dev_info(dev, "NPE%d at 0x%08x-0x%08x not available\n",
>
> Use the special %pR format string to print the resources.
>
> Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2021-08-03 23:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  8:20 Arnd Bergmann
2021-08-03 23:37 ` Linus Walleij [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-03  8:07 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZOzCPKMiCaB3McYAmXZ1oC=L6jKER9a7g2oM6EHE55Fg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=khalasa@piap.pl \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] soc: ixp4xx: fix printing resources' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).