LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Grigoryev Denis <grigoryev@fastwel.ru>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown
Date: Wed, 23 May 2018 11:48:23 +0200	[thread overview]
Message-ID: <CACRpkdZtE6tD2aM49DNovfEz5DYEjfmh0_=WxaAUY6jLz_tigg@mail.gmail.com> (raw)
In-Reply-To: <no_message-id@ru>

On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis <grigoryev@fastwel.ru> wrote:

> The driver stores the result of irq_set_type() in the internal variables
> irq_trig_raise and irq_trig_fall, which later are used to determine
> the GPIOs that must be re-configured as input. These variables retain their
> value between gpiolib's  export / unexport, resulting in an incorrect
> state in some cases. The corresponding bits in the variables
> irq_trig_raise and irq_trig_fall should be cleared in irq_shutdown().
>
> Signed-off-by: Denis Grigoryev <grigoryev@fastwel.ru>

Patch applied with Andy's ACK.

If there are issues we can just revert it.

Yours,
Linus Walleij

      parent reply	other threads:[~2018-05-23  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 16:53 Grigoryev Denis
2018-05-16 12:51 ` Linus Walleij
2018-05-16 13:14   ` Andy Shevchenko
2018-05-23  9:48 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZtE6tD2aM49DNovfEz5DYEjfmh0_=WxaAUY6jLz_tigg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=grigoryev@fastwel.ru \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).